All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] why so little use of ft_system_setup()?
@ 2016-05-19 18:19 Robert P. J. Day
  2016-05-20 16:12 ` Stephen Warren
  0 siblings, 1 reply; 3+ messages in thread
From: Robert P. J. Day @ 2016-05-19 18:19 UTC (permalink / raw)
  To: u-boot


  still crawling through the code related to FDTs, and while i see a
pile of boards that define CONFIG_OF_SYSTEM_SETUP, i see very few that
define the corresponding(?) ft_system_setup() routine.

$ grep -r CONFIG_OF_SYSTEM_SETUP *
cmd/fdt.c:#ifdef CONFIG_OF_SYSTEM_SETUP
cmd/fdt.c:#ifdef CONFIG_OF_SYSTEM_SETUP
configs/apalis_t30_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/paz00_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/plutux_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/venice2_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/p2571_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/beaver_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/ventana_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/p2371-0000_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/tec-ng_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/seaboard_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/dalmore_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/harmony_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/cardhu_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/p2371-2180_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/trimslice_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/colibri_t30_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/colibri_t20_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/whistler_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/tec_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/jetson-tk1_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/e2220-1170_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/medcom-wide_defconfig:CONFIG_OF_SYSTEM_SETUP=y
configs/nyan-big_defconfig:CONFIG_OF_SYSTEM_SETUP=y
include/image.h:#ifdef CONFIG_OF_SYSTEM_SETUP
include/fdt_support.h: * This function is called if CONFIG_OF_SYSTEM_SETUP is defined
README:		CONFIG_OF_SYSTEM_SETUP
$

  and yet ...

$ grep -rw ft_system_setup *
arch/arm/mach-tegra/board2.c:int ft_system_setup(void *blob, bd_t *bd)
cmd/fdt.c:		int err = ft_system_setup(working_fdt, gd->bd);
common/image-fdt.c:		fdt_ret = ft_system_setup(blob, gd->bd);
include/fdt_support.h:int ft_system_setup(void *blob, bd_t *bd);
Kconfig:	  This causes U-Boot to call ft_system_setup() before booting into
README:		This causes ft_system_setup() to be called before booting
$

  am i missing something? what is the point of a board defining that
setting but not defining the associated(?) ft_system_setup() function?
what else is that CONFIG setting being used for? thanks.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] why so little use of ft_system_setup()?
  2016-05-19 18:19 [U-Boot] why so little use of ft_system_setup()? Robert P. J. Day
@ 2016-05-20 16:12 ` Stephen Warren
  2016-05-20 17:43   ` Robert P. J. Day
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Warren @ 2016-05-20 16:12 UTC (permalink / raw)
  To: u-boot

On 05/19/2016 12:19 PM, Robert P. J. Day wrote:
>
>    still crawling through the code related to FDTs, and while i see a
> pile of boards that define CONFIG_OF_SYSTEM_SETUP, i see very few that
> define the corresponding(?) ft_system_setup() routine.
>
> $ grep -r CONFIG_OF_SYSTEM_SETUP *

> configs/apalis_t30_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/paz00_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/plutux_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/venice2_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/p2571_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/beaver_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/ventana_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/p2371-0000_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/tec-ng_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/seaboard_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/dalmore_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/harmony_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/cardhu_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/p2371-2180_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/trimslice_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/colibri_t30_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/colibri_t20_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/whistler_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/tec_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/jetson-tk1_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/e2220-1170_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/medcom-wide_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> configs/nyan-big_defconfig:CONFIG_OF_SYSTEM_SETUP=y

All of those are Tegra boards.

>    and yet ...
>
> $ grep -rw ft_system_setup *
> arch/arm/mach-tegra/board2.c:int ft_system_setup(void *blob, bd_t *bd)

... which link in that file.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] why so little use of ft_system_setup()?
  2016-05-20 16:12 ` Stephen Warren
@ 2016-05-20 17:43   ` Robert P. J. Day
  0 siblings, 0 replies; 3+ messages in thread
From: Robert P. J. Day @ 2016-05-20 17:43 UTC (permalink / raw)
  To: u-boot

On Fri, 20 May 2016, Stephen Warren wrote:

> On 05/19/2016 12:19 PM, Robert P. J. Day wrote:
> >
> >    still crawling through the code related to FDTs, and while i see a
> > pile of boards that define CONFIG_OF_SYSTEM_SETUP, i see very few that
> > define the corresponding(?) ft_system_setup() routine.
> >
> > $ grep -r CONFIG_OF_SYSTEM_SETUP *
>
> > configs/apalis_t30_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/paz00_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/plutux_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/venice2_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/p2571_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/beaver_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/ventana_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/p2371-0000_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/tec-ng_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/seaboard_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/dalmore_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/harmony_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/cardhu_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/p2371-2180_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/trimslice_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/colibri_t30_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/colibri_t20_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/whistler_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/tec_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/jetson-tk1_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/e2220-1170_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/medcom-wide_defconfig:CONFIG_OF_SYSTEM_SETUP=y
> > configs/nyan-big_defconfig:CONFIG_OF_SYSTEM_SETUP=y
>
> All of those are Tegra boards.
>
> >    and yet ...
> >
> > $ grep -rw ft_system_setup *
> > arch/arm/mach-tegra/board2.c:int ft_system_setup(void *blob, bd_t *bd)
>
> ... which link in that file.

  ah, quite so, sorry for not noticing that.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-05-20 17:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-19 18:19 [U-Boot] why so little use of ft_system_setup()? Robert P. J. Day
2016-05-20 16:12 ` Stephen Warren
2016-05-20 17:43   ` Robert P. J. Day

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.