From: Rob Landley <rob@landley.net>
To: Rich Felker <dalias@libc.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2 09/12] clocksource: add J-Core PIT/RTC driver
Date: Sat, 21 May 2016 15:55:43 +0000 [thread overview]
Message-ID: <574084FF.1070901@landley.net> (raw)
In-Reply-To: <20160521031515.GZ21636@brightrain.aerifal.cx>
On 05/20/2016 10:15 PM, Rich Felker wrote:
> On Fri, May 20, 2016 at 04:01:56PM +0200, Daniel Lezcano wrote:
>>> + return ((u64)sechi << 32 | seclo) * 1000000000 + nsec;
>>
>> s/1000000000/NSEC_PER_SEC/
...
>>> + hwirq = irq_get_irq_data(pit_irq)->hwirq;
>>> + enable_val = (1<<26) | ((hwirq&0x3c)<<18) | (hwirq<<12);
>>
>> Can you explain? (and replace litterals by macros).
"Hiding numbers that are used just once into defines to put them
out of sight does not really help readability." - Pavel Machek
http://lkml.iu.edu/hypermail/linux/kernel/1407.1/00299.html
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Landley <rob@landley.net>
To: Rich Felker <dalias@libc.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2 09/12] clocksource: add J-Core PIT/RTC driver
Date: Sat, 21 May 2016 10:55:43 -0500 [thread overview]
Message-ID: <574084FF.1070901@landley.net> (raw)
In-Reply-To: <20160521031515.GZ21636@brightrain.aerifal.cx>
On 05/20/2016 10:15 PM, Rich Felker wrote:
> On Fri, May 20, 2016 at 04:01:56PM +0200, Daniel Lezcano wrote:
>>> + return ((u64)sechi << 32 | seclo) * 1000000000 + nsec;
>>
>> s/1000000000/NSEC_PER_SEC/
...
>>> + hwirq = irq_get_irq_data(pit_irq)->hwirq;
>>> + enable_val = (1<<26) | ((hwirq&0x3c)<<18) | (hwirq<<12);
>>
>> Can you explain? (and replace litterals by macros).
"Hiding numbers that are used just once into defines to put them
out of sight does not really help readability." - Pavel Machek
http://lkml.iu.edu/hypermail/linux/kernel/1407.1/00299.html
Rob
next prev parent reply other threads:[~2016-05-21 15:55 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 2:53 [PATCH v2 00/12] J-core J2 cpu and SoC peripherals support Rich Felker
2016-05-20 2:53 ` [PATCH v2 02/12] of: add J-Core cpu bindings Rich Felker
2016-05-20 2:53 ` Rich Felker
[not found] ` <f3c89e4834665790ff13478c571cc9aaa9de5559.1463708766.git.dalias-8zAoT0mYgF4@public.gmane.org>
2016-05-23 20:48 ` Rob Herring
2016-05-23 20:48 ` Rob Herring
2016-05-23 20:48 ` Rob Herring
2016-05-23 21:03 ` Rich Felker
2016-05-23 21:03 ` Rich Felker
2016-05-23 23:29 ` Rob Herring
2016-05-23 23:29 ` Rob Herring
2016-05-24 2:39 ` Rich Felker
2016-05-24 2:39 ` Rich Felker
2016-05-24 21:30 ` Rob Landley
2016-05-24 21:30 ` Rob Landley
2016-05-25 1:13 ` Rob Herring
2016-05-25 1:13 ` Rob Herring
2016-05-25 2:33 ` Rich Felker
2016-05-25 2:33 ` Rich Felker
2016-05-25 13:13 ` Rob Herring
2016-05-25 13:13 ` Rob Herring
[not found] ` <cover.1463708766.git.dalias-8zAoT0mYgF4@public.gmane.org>
2016-05-20 2:53 ` [PATCH v2 01/12] of: add vendor prefix for J-Core Rich Felker
2016-05-20 2:53 ` Rich Felker
2016-05-20 2:53 ` Rich Felker
2016-05-23 20:49 ` Rob Herring
2016-05-23 20:49 ` Rob Herring
2016-05-20 2:53 ` [PATCH v2 12/12] sh: add device tree source for J2 FPGA on Mimas v2 board Rich Felker
2016-05-20 2:53 ` Rich Felker
2016-05-20 2:53 ` Rich Felker
[not found] ` <9960d6526523727d1bee3d11c6704e09e600c6fe.1463708766.git.dalias-8zAoT0mYgF4@public.gmane.org>
2016-05-20 8:17 ` Geert Uytterhoeven
2016-05-20 8:17 ` Geert Uytterhoeven
2016-05-20 8:17 ` Geert Uytterhoeven
2016-05-20 22:42 ` Rich Felker
2016-05-20 22:42 ` Rich Felker
2016-05-20 2:53 ` [PATCH v2 07/12] sh: add AT_HWCAP flag for J-Core cas.l instruction Rich Felker
2016-05-20 2:53 ` [PATCH v2 09/12] clocksource: add J-Core PIT/RTC driver Rich Felker
2016-05-20 14:01 ` Daniel Lezcano
2016-05-20 14:01 ` Daniel Lezcano
2016-05-21 3:15 ` Rich Felker
2016-05-21 3:15 ` Rich Felker
2016-05-21 15:55 ` Rob Landley [this message]
2016-05-21 15:55 ` Rob Landley
2016-05-23 20:32 ` Daniel Lezcano
2016-05-23 20:32 ` Daniel Lezcano
2016-05-24 2:25 ` Rich Felker
2016-05-24 2:25 ` Rich Felker
2016-05-20 2:53 ` [PATCH v2 04/12] of: add J-Core timer bindings Rich Felker
2016-05-20 8:03 ` Geert Uytterhoeven
2016-05-20 8:03 ` Geert Uytterhoeven
2016-05-20 2:53 ` [PATCH v2 10/12] spi: add driver for J-Core SPI controller Rich Felker
2016-05-20 2:53 ` Rich Felker
2016-05-20 8:15 ` Geert Uytterhoeven
2016-05-20 8:15 ` Geert Uytterhoeven
2016-05-20 22:50 ` Rich Felker
2016-05-20 22:50 ` Rich Felker
2016-05-20 10:23 ` Mark Brown
2016-05-20 10:23 ` Mark Brown
2016-05-20 23:24 ` Rich Felker
2016-05-20 23:24 ` Rich Felker
2016-05-23 15:30 ` Mark Brown
2016-05-23 15:30 ` Mark Brown
2016-05-23 20:29 ` Rich Felker
2016-05-23 20:29 ` Rich Felker
[not found] ` <20160523202938.GD21636-C3MtFaGISjmo6RMmaWD+6Sb1p8zYI1N1@public.gmane.org>
2016-05-23 22:11 ` Mark Brown
2016-05-23 22:11 ` Mark Brown
2016-05-23 22:11 ` Mark Brown
2016-05-20 2:53 ` [PATCH v2 03/12] of: add J-Core interrupt controller bindings Rich Felker
2016-05-20 8:04 ` Geert Uytterhoeven
2016-05-20 8:04 ` Geert Uytterhoeven
[not found] ` <CAMuHMdVs9=8BGwmCBuYch2abJBnCLKoEx7i3EMghW3UUjXc7dA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-20 22:34 ` Rich Felker
2016-05-20 22:34 ` Rich Felker
2016-05-20 22:34 ` Rich Felker
2016-05-21 18:07 ` Geert Uytterhoeven
2016-05-21 18:07 ` Geert Uytterhoeven
2016-05-21 19:17 ` Rich Felker
2016-05-21 19:17 ` Rich Felker
2016-05-23 20:53 ` Rob Herring
2016-05-23 20:53 ` Rob Herring
2016-05-23 21:13 ` Rich Felker
2016-05-23 21:13 ` Rich Felker
2016-05-23 21:13 ` Rich Felker
[not found] ` <20160523211342.GG21636-C3MtFaGISjmo6RMmaWD+6Sb1p8zYI1N1@public.gmane.org>
2016-05-24 8:09 ` Marc Zyngier
2016-05-24 8:09 ` Marc Zyngier
2016-05-24 8:09 ` Marc Zyngier
[not found] ` <57440C45.5040105-5wv7dgnIgG8@public.gmane.org>
2016-05-25 2:25 ` Rich Felker
2016-05-25 2:25 ` Rich Felker
2016-05-25 2:25 ` Rich Felker
2016-05-20 2:53 ` [PATCH v2 11/12] sh: add defconfig for J-Core J2 Rich Felker
2016-05-20 2:53 ` [PATCH v2 06/12] sh: add support for J-Core J2 processor Rich Felker
2016-05-20 2:53 ` Rich Felker
2016-05-20 2:53 ` [PATCH v2 05/12] of: add J-Core SPI master bindings Rich Felker
2016-05-20 8:05 ` Geert Uytterhoeven
2016-05-20 8:05 ` Geert Uytterhoeven
2016-05-20 8:05 ` Geert Uytterhoeven
2016-05-23 21:00 ` Rob Herring
2016-05-23 21:00 ` Rob Herring
2016-05-23 21:06 ` Rich Felker
2016-05-23 21:06 ` Rich Felker
[not found] ` <20160523210618.GF21636-C3MtFaGISjmo6RMmaWD+6Sb1p8zYI1N1@public.gmane.org>
2016-05-23 23:16 ` Rob Herring
2016-05-23 23:16 ` Rob Herring
2016-05-23 23:16 ` Rob Herring
2016-05-20 2:53 ` [PATCH v2 08/12] irqchip: add J-Core AIC driver Rich Felker
2016-05-20 8:08 ` Geert Uytterhoeven
2016-05-20 8:08 ` Geert Uytterhoeven
2016-05-20 8:15 ` Marc Zyngier
2016-05-20 8:15 ` Marc Zyngier
2016-05-25 4:29 ` Rich Felker
2016-05-25 4:29 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574084FF.1070901@landley.net \
--to=rob@landley.net \
--cc=dalias@libc.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.