[dm-crypt] A couple of strings that could be reviewed

[dm-crypt] A couple of strings that could be reviewed

[Rafael Fontenelle]

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

Hello there!

I'm currently translating cryptsetup to Brazilian Portuguese and notice a
small detail in two strings that maybe you want to take a look at.

First is "Cannot open device %s\n", in file src/cryptsetup_reencrypt.c,
line 154.  I believe a full stop/period punctuation would be welcome in
there, since other messages nearby have it. Please take a look in the
catalog messsages file (a.k.a translation file).

Second is "Cannot use passed UUID unless decryption in progress.\n", in
file src/cryptsetup_reencrypt.c, line 1180.  My interpretation of it is
that decryption must not be in progress to be allowed passing UUID.  If I'm
correct, then I suggestion adding a "is" in "..decryption IS in progress".

Cheers,
Rafael Fontenelle

[-- Attachment #2: Type: text/html, Size: 923 bytes --]

Re: [dm-crypt] A couple of strings that could be reviewed

[Michael Kjörling]

On 20 May 2016 05:24 -0300, from rffontenelle@gmail.com (Rafael Fontenelle):
> First is "Cannot open device %s\n", in file src/cryptsetup_reencrypt.c,
> line 154.  I believe a full stop/period punctuation would be welcome in
> there, since other messages nearby have it. Please take a look in the
> catalog messsages file (a.k.a translation file).

I disagree, at least given how the message is written now. (It could
in principle be rewritten so that this doesn't apply.) It's a small
detail, but because the message _ends_ with something that is to be
taken literally (in this case, the name of the problematic device),
adding additional characters at the end can potentially be confusing,
and I don't see doing so leading to significantly increased
readability. In other words, a potential loss of precision for no gain
in usability. That seems to me like a poor trade-off.

It's a bit like the old example: _The default password is "abcdefgh."_
Based only on that information, what exactly is the default password:
does it have a period at the end or not? Where does the sentence that
makes that statement end?

-- 
Michael Kjörling • https://michael.kjorling.se • michael@kjorling.se
                 “People who think they know everything really annoy
                 those of us who know we don’t.” (Bjarne Stroustrup)

Re: [dm-crypt] A couple of strings that could be reviewed

[Milan Broz]

On 05/20/2016 10:24 AM, Rafael Fontenelle wrote:
> Hello there!
> 
> I'm currently translating cryptsetup to Brazilian Portuguese and
> notice a small detail in two strings that maybe you want to take a
> look at.
> 
> First is "Cannot open device %s\n", in file
> src/cryptsetup_reencrypt.c, line 154.  I believe a full stop/period
> punctuation would be welcome in there, since other messages nearby
> have it. Please take a look in the catalog messsages file (a.k.a
> translation file).

Hi,

yes, it should be the same as other messages (despite punctuation
could be confusing as already mentioned).
Anyway, messages should not alternate according to random context.

I'll fix it, but it is not worth to submit translation file for 1.7.2 again
(the proper string is already there).

> Second is "Cannot use passed UUID unless decryption in progress.\n",
> in file src/cryptsetup_reencrypt.c, line 1180.  My interpretation of
> it is that decryption must not be in progress to be allowed passing
> UUID.  If I'm correct, then I suggestion adding a "is" in
> "..decryption IS in progress".

Quite terse error message, missed that :) It should be more like
  "Provided UUID can be used only when resuming decryption."

Man page description is

--uuid <uuid>
  Use only while resuming an interrupted decryption process (see --decrypt). 

Will fix this in next version, that message is very rare...

Thanks!
Milan

Re: [dm-crypt] A couple of strings that could be reviewed

[Rafael Fontenelle]

[-- Attachment #1: Type: text/plain, Size: 1685 bytes --]

2016-05-23 5:41 GMT-03:00 Milan Broz <gmazyland@gmail.com>:

>
> On 05/20/2016 10:24 AM, Rafael Fontenelle wrote:
> > Hello there!
> >
> > I'm currently translating cryptsetup to Brazilian Portuguese and
> > notice a small detail in two strings that maybe you want to take a
> > look at.
> >
> > First is "Cannot open device %s\n", in file
> > src/cryptsetup_reencrypt.c, line 154.  I believe a full stop/period
> > punctuation would be welcome in there, since other messages nearby
> > have it. Please take a look in the catalog messsages file (a.k.a
> > translation file).
>
> Hi,
>
> yes, it should be the same as other messages (despite punctuation
> could be confusing as already mentioned).
> Anyway, messages should not alternate according to random context.
>
> I'll fix it, but it is not worth to submit translation file for 1.7.2 again
> (the proper string is already there).
>
> > Second is "Cannot use passed UUID unless decryption in progress.\n",
> > in file src/cryptsetup_reencrypt.c, line 1180.  My interpretation of
> > it is that decryption must not be in progress to be allowed passing
> > UUID.  If I'm correct, then I suggestion adding a "is" in
> > "..decryption IS in progress".
>
> Quite terse error message, missed that :) It should be more like
>   "Provided UUID can be used only when resuming decryption."
>
> Man page description is
>
> --uuid <uuid>
>   Use only while resuming an interrupted decryption process (see
> --decrypt).
>
> Will fix this in next version, that message is very rare...
>
> Thanks!
> Milan
>

Indeed, my report is really a minor issue. No problem, I'm just happy to
report and, eventually, solve this.

Cheers,
Rafael Fontenelle

[-- Attachment #2: Type: text/html, Size: 2494 bytes --]