* [PATCH 1/2 v2] kni: fix inverted function comments
@ 2016-05-21 7:25 Alex Wang
2016-05-21 7:25 ` [PATCH 2/2 v2] kni: Add documentation for the mempool capacity Alex Wang
2016-05-23 17:00 ` [PATCH 1/2 v2] kni: fix inverted function comments Ferruh Yigit
0 siblings, 2 replies; 6+ messages in thread
From: Alex Wang @ 2016-05-21 7:25 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, Alex Wang
From: Alex Wang <alex@awakenetworks.com>
The 'mbufs' alloc/free descriptions for
'rte_kni_tx_burst()' and 'rte_kni_rx_burst()'
should be inverted.
Fixes: 3fc5ca2 (kni: initial import)
Signed-off-by: Alex Wang <alex@awakenetworks.com>
---
lib/librte_kni/rte_kni.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h
index ef9faa9..25fa45e 100644
--- a/lib/librte_kni/rte_kni.h
+++ b/lib/librte_kni/rte_kni.h
@@ -161,8 +161,8 @@ extern int rte_kni_handle_request(struct rte_kni *kni);
/**
* Retrieve a burst of packets from a KNI interface. The retrieved packets are
* stored in rte_mbuf structures whose pointers are supplied in the array of
- * mbufs, and the maximum number is indicated by num. It handles the freeing of
- * the mbufs in the free queue of KNI interface.
+ * mbufs, and the maximum number is indicated by num. It handles allocating
+ * the mbufs for KNI interface alloc queue.
*
* @param kni
* The KNI interface context.
@@ -180,8 +180,8 @@ extern unsigned rte_kni_rx_burst(struct rte_kni *kni,
/**
* Send a burst of packets to a KNI interface. The packets to be sent out are
* stored in rte_mbuf structures whose pointers are supplied in the array of
- * mbufs, and the maximum number is indicated by num. It handles allocating
- * the mbufs for KNI interface alloc queue.
+ * mbufs, and the maximum number is indicated by num. It handles the freeing of
+ * the mbufs in the free queue of KNI interface.
*
* @param kni
* The KNI interface context.
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2 v2] kni: Add documentation for the mempool capacity
2016-05-21 7:25 [PATCH 1/2 v2] kni: fix inverted function comments Alex Wang
@ 2016-05-21 7:25 ` Alex Wang
2016-05-23 17:00 ` Ferruh Yigit
2016-05-23 17:00 ` [PATCH 1/2 v2] kni: fix inverted function comments Ferruh Yigit
1 sibling, 1 reply; 6+ messages in thread
From: Alex Wang @ 2016-05-21 7:25 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, Alex Wang
From: Alex Wang <alex@awakenetworks.com>
Function like 'rte_kni_rx_burst()' keeps
allocating 'MAX_MBUF_BURST_NUM' mbufs to
kni fifo queue unless the queue's capacity
('KNI_FIFO_COUNT_MAX') is reached. So, if
the mempool is under-provisioned, user may
run into "Out of Memory" logs from KNI code.
This commit documents the need to provision
mempool capacity of more than
"2 x KNI_FIFO_COUNT_MAX" for each KNI interface.
Signed-off-by: Alex Wang <alex@awakenetworks.com>
---
lib/librte_kni/rte_kni.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h
index 25fa45e..ac11148 100644
--- a/lib/librte_kni/rte_kni.h
+++ b/lib/librte_kni/rte_kni.h
@@ -113,6 +113,9 @@ extern void rte_kni_init(unsigned int max_kni_ifaces);
* The rte_kni_alloc shall not be called before rte_kni_init() has been
* called. rte_kni_alloc is thread safe.
*
+ * The mempool should have capacity of more than "2 x KNI_FIFO_COUNT_MAX"
+ * elements for each KNI interface allocated.
+ *
* @param pktmbuf_pool
* The mempool for allocting mbufs for packets.
* @param conf
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2 v2] kni: Add documentation for the mempool capacity
2016-05-21 7:25 ` [PATCH 2/2 v2] kni: Add documentation for the mempool capacity Alex Wang
@ 2016-05-23 17:00 ` Ferruh Yigit
2016-05-23 17:10 ` Ferruh Yigit
0 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2016-05-23 17:00 UTC (permalink / raw)
To: Alex Wang, dev; +Cc: Alex Wang
On 5/21/2016 8:25 AM, Alex Wang wrote:
> From: Alex Wang <alex@awakenetworks.com>
>
> Function like 'rte_kni_rx_burst()' keeps
> allocating 'MAX_MBUF_BURST_NUM' mbufs to
> kni fifo queue unless the queue's capacity
> ('KNI_FIFO_COUNT_MAX') is reached. So, if
> the mempool is under-provisioned, user may
> run into "Out of Memory" logs from KNI code.
> This commit documents the need to provision
> mempool capacity of more than
> "2 x KNI_FIFO_COUNT_MAX" for each KNI interface.
>
> Signed-off-by: Alex Wang <alex@awakenetworks.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2 v2] kni: Add documentation for the mempool capacity
2016-05-23 17:00 ` Ferruh Yigit
@ 2016-05-23 17:10 ` Ferruh Yigit
2016-05-23 17:12 ` Alex Wang
0 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2016-05-23 17:10 UTC (permalink / raw)
To: Alex Wang, dev; +Cc: Alex Wang
On 5/23/2016 6:00 PM, Ferruh Yigit wrote:
> On 5/21/2016 8:25 AM, Alex Wang wrote:
>> From: Alex Wang <alex@awakenetworks.com>
>>
>> Function like 'rte_kni_rx_burst()' keeps
>> allocating 'MAX_MBUF_BURST_NUM' mbufs to
>> kni fifo queue unless the queue's capacity
>> ('KNI_FIFO_COUNT_MAX') is reached. So, if
>> the mempool is under-provisioned, user may
>> run into "Out of Memory" logs from KNI code.
>> This commit documents the need to provision
>> mempool capacity of more than
>> "2 x KNI_FIFO_COUNT_MAX" for each KNI interface.
>>
>> Signed-off-by: Alex Wang <alex@awakenetworks.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
Hi Alex,
This is detail but I just recognized patch subject after tag starts with
uppercase. Would you mind sending another patch? You can keep my ack
with it.
Thanks,
ferruh
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2 v2] kni: Add documentation for the mempool capacity
2016-05-23 17:10 ` Ferruh Yigit
@ 2016-05-23 17:12 ` Alex Wang
0 siblings, 0 replies; 6+ messages in thread
From: Alex Wang @ 2016-05-23 17:12 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: Alex Wang, dev
Shoooot, sorry for missing that, sending V3,
On Mon, May 23, 2016 at 10:10 AM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:
> On 5/23/2016 6:00 PM, Ferruh Yigit wrote:
> > On 5/21/2016 8:25 AM, Alex Wang wrote:
> >> From: Alex Wang <alex@awakenetworks.com>
> >>
> >> Function like 'rte_kni_rx_burst()' keeps
> >> allocating 'MAX_MBUF_BURST_NUM' mbufs to
> >> kni fifo queue unless the queue's capacity
> >> ('KNI_FIFO_COUNT_MAX') is reached. So, if
> >> the mempool is under-provisioned, user may
> >> run into "Out of Memory" logs from KNI code.
> >> This commit documents the need to provision
> >> mempool capacity of more than
> >> "2 x KNI_FIFO_COUNT_MAX" for each KNI interface.
> >>
> >> Signed-off-by: Alex Wang <alex@awakenetworks.com>
> >
> > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >
>
> Hi Alex,
>
> This is detail but I just recognized patch subject after tag starts with
> uppercase. Would you mind sending another patch? You can keep my ack
> with it.
>
> Thanks,
> ferruh
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2 v2] kni: fix inverted function comments
2016-05-21 7:25 [PATCH 1/2 v2] kni: fix inverted function comments Alex Wang
2016-05-21 7:25 ` [PATCH 2/2 v2] kni: Add documentation for the mempool capacity Alex Wang
@ 2016-05-23 17:00 ` Ferruh Yigit
1 sibling, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2016-05-23 17:00 UTC (permalink / raw)
To: Alex Wang, dev; +Cc: Alex Wang
On 5/21/2016 8:25 AM, Alex Wang wrote:
> From: Alex Wang <alex@awakenetworks.com>
>
> The 'mbufs' alloc/free descriptions for
> 'rte_kni_tx_burst()' and 'rte_kni_rx_burst()'
> should be inverted.
>
> Fixes: 3fc5ca2 (kni: initial import)
>
> Signed-off-by: Alex Wang <alex@awakenetworks.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-05-23 17:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-21 7:25 [PATCH 1/2 v2] kni: fix inverted function comments Alex Wang
2016-05-21 7:25 ` [PATCH 2/2 v2] kni: Add documentation for the mempool capacity Alex Wang
2016-05-23 17:00 ` Ferruh Yigit
2016-05-23 17:10 ` Ferruh Yigit
2016-05-23 17:12 ` Alex Wang
2016-05-23 17:00 ` [PATCH 1/2 v2] kni: fix inverted function comments Ferruh Yigit
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.