From: Corey Minyard <cminyard@mvista.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
minyard@acm.org
Cc: "Michael S . Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v5 5/6] acpi: Add IPMI table entries
Date: Mon, 23 May 2016 14:25:21 -0500 [thread overview]
Message-ID: <57435921.1090909@mvista.com> (raw)
In-Reply-To: <fb9d2e05-7a1b-5bfb-08a1-d34128a2e4a9@redhat.com>
On 05/23/2016 01:06 PM, Paolo Bonzini wrote:
>
> On 20/05/2016 11:53, Igor Mammedov wrote:
>>>> diff --git a/hw/acpi/noipmi.c b/hw/acpi/noipmi.c
>>>> new file mode 100644
>>>> index 0000000..dd7590d
>>>> --- /dev/null
>>>> +++ b/hw/acpi/noipmi.c
>> move this to .a/stubs/
>>
> Don't overuse stubs. The stubs library is mostly to share code between
> QEMU and the tools. What Corey did is more similar to what hw/ already
> does in other places.
Should I change it back?
> Unfortunately, weak symbols are not portable. :(
Yeah, that's really a pain.
-corey
> Paolo
next prev parent reply other threads:[~2016-05-23 19:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 15:23 [Qemu-devel] [PATCH v5 0/6] Add IPMI to firmware tables minyard
2016-05-19 15:23 ` [Qemu-devel] [PATCH v5 1/6] ipmi: rework the fwinfo to be fetched from the interface minyard
2016-05-19 15:23 ` [Qemu-devel] [PATCH v5 2/6] pc: Postpone SMBIOS table installation to post machine init minyard
2016-05-20 8:59 ` Igor Mammedov
2016-05-19 15:23 ` [Qemu-devel] [PATCH v5 3/6] smbios: Move table build tools into an include file minyard
2016-05-19 15:24 ` [Qemu-devel] [PATCH v5 4/6] ipmi: Add SMBIOS table entry minyard
2016-05-20 9:11 ` Igor Mammedov
2016-05-19 15:24 ` [Qemu-devel] [PATCH v5 5/6] acpi: Add IPMI table entries minyard
2016-05-20 9:53 ` Igor Mammedov
2016-05-22 0:28 ` Corey Minyard
2016-05-23 9:05 ` Marcel Apfelbaum
2016-05-23 13:39 ` Corey Minyard
2016-05-23 13:51 ` Marcel Apfelbaum
2016-05-23 15:55 ` Corey Minyard
2016-05-23 10:01 ` Igor Mammedov
2016-05-23 12:42 ` Corey Minyard
2016-05-23 13:15 ` Igor Mammedov
2016-05-23 18:06 ` Paolo Bonzini
2016-05-23 19:25 ` Corey Minyard [this message]
2016-05-24 10:03 ` Paolo Bonzini
2016-05-24 7:17 ` Igor Mammedov
2016-05-24 10:03 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57435921.1090909@mvista.com \
--to=cminyard@mvista.com \
--cc=imammedo@redhat.com \
--cc=minyard@acm.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.