From: Chao Yu <chao@kernel.org>
To: Daeho Jeong <daeho43@gmail.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Cc: Daeho Jeong <daehojeong@google.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs: include non-compressed blocks in compr_written_block
Date: Sat, 9 Oct 2021 12:44:07 +0800 [thread overview]
Message-ID: <5743eeca-a6e8-87d4-5799-c622fbada429@kernel.org> (raw)
In-Reply-To: <20211006174910.2964885-1-daeho43@gmail.com>
On 2021/10/7 1:49, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> Need to include non-compressed blocks in compr_written_block to
> estimate average compression ratio more accurately.
>
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
> ---
> fs/f2fs/compress.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
> index c1bf9ad4c220..9b663eaf4805 100644
> --- a/fs/f2fs/compress.c
> +++ b/fs/f2fs/compress.c
> @@ -1530,6 +1530,7 @@ int f2fs_write_multi_pages(struct compress_ctx *cc,
> if (cluster_may_compress(cc)) {
> err = f2fs_compress_pages(cc);
> if (err == -EAGAIN) {
> + add_compr_block_stat(cc->inode, cc->cluster_size);
Shouldn't we relocate this after 'write' label?
One more concern, it looks we've changed what compr_block stat indicated,
literally, the block we account should be compressed..., how about accounting
it by introducing .presist_blocks, used_blocks or occupied_blocks.... thoughts?
Thanks,
> goto write;
> } else if (err) {
> f2fs_put_rpages_wbc(cc, wbc, true, 1);
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: Daeho Jeong <daeho43@gmail.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Cc: Daeho Jeong <daehojeong@google.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs: include non-compressed blocks in compr_written_block
Date: Sat, 9 Oct 2021 12:44:07 +0800 [thread overview]
Message-ID: <5743eeca-a6e8-87d4-5799-c622fbada429@kernel.org> (raw)
In-Reply-To: <20211006174910.2964885-1-daeho43@gmail.com>
On 2021/10/7 1:49, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> Need to include non-compressed blocks in compr_written_block to
> estimate average compression ratio more accurately.
>
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
> ---
> fs/f2fs/compress.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
> index c1bf9ad4c220..9b663eaf4805 100644
> --- a/fs/f2fs/compress.c
> +++ b/fs/f2fs/compress.c
> @@ -1530,6 +1530,7 @@ int f2fs_write_multi_pages(struct compress_ctx *cc,
> if (cluster_may_compress(cc)) {
> err = f2fs_compress_pages(cc);
> if (err == -EAGAIN) {
> + add_compr_block_stat(cc->inode, cc->cluster_size);
Shouldn't we relocate this after 'write' label?
One more concern, it looks we've changed what compr_block stat indicated,
literally, the block we account should be compressed..., how about accounting
it by introducing .presist_blocks, used_blocks or occupied_blocks.... thoughts?
Thanks,
> goto write;
> } else if (err) {
> f2fs_put_rpages_wbc(cc, wbc, true, 1);
>
next prev parent reply other threads:[~2021-10-09 4:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 17:49 [f2fs-dev] [PATCH] f2fs: include non-compressed blocks in compr_written_block Daeho Jeong
2021-10-06 17:49 ` Daeho Jeong
2021-10-09 4:44 ` Chao Yu [this message]
2021-10-09 4:44 ` [f2fs-dev] " Chao Yu
2021-10-11 16:02 ` Daeho Jeong
2021-10-11 16:02 ` Daeho Jeong
2021-10-13 14:17 ` Chao Yu
2021-10-13 14:17 ` Chao Yu
2021-10-13 17:52 ` Daeho Jeong
2021-10-13 17:52 ` Daeho Jeong
2021-10-21 11:57 ` Chao Yu
2021-10-21 11:57 ` Chao Yu
2021-10-21 15:51 ` Daeho Jeong
2021-10-21 15:51 ` Daeho Jeong
2021-10-21 21:18 ` Jaegeuk Kim
2021-10-21 21:18 ` Jaegeuk Kim
2021-10-22 14:16 ` Chao Yu
2021-10-22 14:16 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5743eeca-a6e8-87d4-5799-c622fbada429@kernel.org \
--to=chao@kernel.org \
--cc=daeho43@gmail.com \
--cc=daehojeong@google.com \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.