From: Michael Wood <michael.g.wood@intel.com>
To: toaster@yoctoproject.org
Subject: Re: [PATCH 106/106] toaster: Unique project names to Boostrap 3
Date: Tue, 24 May 2016 16:34:12 +0100 [thread overview]
Message-ID: <57447474.4010301@intel.com> (raw)
In-Reply-To: <1464090003-23469-107-git-send-email-belen.barros.pena@linux.intel.com>
Phew! great work, thank you!!
So on my TODO list the next steps are
- Fix the indentation of patches #77, #80 , #81, 82, #91. #92, #93, #94,
#96, #98, #102
- Drop #59
- Fixup/squash patches which rewrite the same parts.
- Fix the authorship of the typeahead patch - somehow it's been
attributed to me
- Revert the bootstrap-toaster theme related stuff
- Fix the tests which probably will have broken
Then we'll merge it into toaster-next, get the build analysis stuff
done, let it settle for a bit and then submit it upstream.
Michael
On 24/05/16 12:40, Belen Barros Pena wrote:
> We recently added functionality to enforce unique project names. Such
> functionality was marked up for Boostrap 2, and some changes are
> required to ensure it works with Bootstrap 3.
>
> Signed-off-by: Belen Barros Pena <belen.barros.pena@linux.intel.com>
> ---
> bitbake/lib/toaster/toastergui/static/js/libtoaster.js | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bitbake/lib/toaster/toastergui/static/js/libtoaster.js b/bitbake/lib/toaster/toastergui/static/js/libtoaster.js
> index a56e84a..e4e4f6c 100644
> --- a/bitbake/lib/toaster/toastergui/static/js/libtoaster.js
> +++ b/bitbake/lib/toaster/toastergui/static/js/libtoaster.js
> @@ -393,11 +393,11 @@ var libtoaster = (function () {
> data.results[0].name === projectName) {
> // This project name exists hence show the error and disable
> // the save button
> - ctrlGrpValidateProjectName.addClass('control-group error');
> + ctrlGrpValidateProjectName.addClass('has-error');
> hintError.show();
> enableOrDisableBtn.attr('disabled', 'disabled');
> } else {
> - ctrlGrpValidateProjectName.removeClass('control-group error');
> + ctrlGrpValidateProjectName.removeClass('has-error');
> hintError.hide();
> enableOrDisableBtn.removeAttr('disabled');
> }
prev parent reply other threads:[~2016-05-24 15:34 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 11:38 [PATCH 000/106] Migrate configuration functionality to Boostrap 3 Belen Barros Pena
2016-05-24 11:38 ` [PATCH 001/106] toaster: Auto convert bootstrap 2 to bootstrap 3 Belen Barros Pena
2016-05-24 11:38 ` [PATCH 003/106] toaster: templates Base add bootstrap-toaster-theme overlay Belen Barros Pena
2016-05-24 11:38 ` [PATCH 004/106] toaster: Top bar layout fixes Belen Barros Pena
2016-05-24 11:38 ` [PATCH 005/106] toaster: Fix layout of 'All builds' page Belen Barros Pena
2016-05-24 11:38 ` [PATCH 006/106] toaster: Fix layout of 'All projects' page Belen Barros Pena
2016-05-24 11:38 ` [PATCH 007/106] toaster: templates Add additional divs for modals in bootstrap3 Belen Barros Pena
2016-05-24 11:38 ` [PATCH 008/106] toaster: templates Use old style input appends instead of input-group Belen Barros Pena
2016-05-24 11:38 ` [PATCH 009/106] toaster: bootstrap3-transition Remove top margin on New project button Belen Barros Pena
2016-05-24 11:38 ` [PATCH 010/106] toaster: default.css Remove 80% width for search as this is no longer needed Belen Barros Pena
2016-05-24 11:38 ` [PATCH 011/106] toaster: migrate typeahead library Belen Barros Pena
2016-05-24 11:38 ` [PATCH 012/106] toaster: Layout fixes for project configuration Belen Barros Pena
2016-05-24 11:38 ` [PATCH 013/106] toaster: Fix toaster table footer controls Belen Barros Pena
2016-05-24 11:38 ` [PATCH 014/106] toaster: Fix layout of 'project builds' page Belen Barros Pena
2016-05-24 11:38 ` [PATCH 015/106] toaster: small changes to 'import layer' page Belen Barros Pena
2016-05-24 11:38 ` [PATCH 016/106] toaster: Remove hovering from disabled buttons Belen Barros Pena
2016-05-24 11:38 ` [PATCH 017/106] toaster: Fix layout in "new custom image" page Belen Barros Pena
2016-05-24 11:38 ` [PATCH 018/106] toaster: table.js Fix the edit columns drop down Belen Barros Pena
2016-05-24 11:38 ` [PATCH 019/106] toaster: templates Use old style icon classes Belen Barros Pena
2016-05-24 11:38 ` [PATCH 020/106] toaster: Fix breadcrumbs Belen Barros Pena
2016-05-24 11:38 ` [PATCH 021/106] toaster: Fix "custom image details" layout Belen Barros Pena
2016-05-24 11:38 ` [PATCH 022/106] toaster: remove row from base template Belen Barros Pena
2016-05-24 11:38 ` [PATCH 023/106] toaster: Fix image recipe details layout Belen Barros Pena
2016-05-24 11:38 ` [PATCH 024/106] toaster: Fix layer " Belen Barros Pena
2016-05-24 11:38 ` [PATCH 025/106] toaster: Set correct margins for table search Belen Barros Pena
2016-05-24 11:38 ` [PATCH 027/106] toaster: Fix breadcrumb in build data pages Belen Barros Pena
2016-05-24 11:38 ` [PATCH 028/106] toaster: indentation fixes Belen Barros Pena
2016-05-24 11:38 ` [PATCH 029/106] toaster: Fix layout in build dashboard page Belen Barros Pena
2016-05-24 11:38 ` [PATCH 030/106] toaster: Fix breadcrumb in Chrome Belen Barros Pena
2016-05-24 11:38 ` [PATCH 031/106] toaster: Adjust width of non-toastertables search Belen Barros Pena
2016-05-24 11:38 ` [PATCH 032/106] toaster: Alignment of table controls Belen Barros Pena
2016-05-24 11:38 ` [PATCH 033/106] toaster: Fix pagination in non-toastertables Belen Barros Pena
2016-05-24 11:38 ` [PATCH 034/106] toaster: Fix layout of packages installed page Belen Barros Pena
2016-05-24 11:38 ` [PATCH 035/106] toaster: Fix layout of configuration page Belen Barros Pena
2016-05-24 11:38 ` [PATCH 036/106] toaster: Fix layout of variable history page Belen Barros Pena
2016-05-24 11:38 ` [PATCH 037/106] toaster: Fix layout in package details pages Belen Barros Pena
2016-05-24 11:38 ` [PATCH 038/106] toaster: Fix layout in recipe details page Belen Barros Pena
2016-05-24 11:38 ` [PATCH 039/106] toaster: Fix layout in task " Belen Barros Pena
2016-05-24 11:38 ` [PATCH 040/106] toaster: revert auto change to icon class for spinner Belen Barros Pena
2016-05-24 11:38 ` [PATCH 041/106] toaster: Remove the pagination-centered class Belen Barros Pena
2016-05-24 11:38 ` [PATCH 042/106] toaster: Style typeaheads Belen Barros Pena
2016-05-24 11:39 ` [PATCH 043/106] toaster: Fix filters Belen Barros Pena
2016-05-24 11:39 ` [PATCH 044/106] toaster: Fix no results pages Belen Barros Pena
2016-05-24 11:39 ` [PATCH 045/106] toaster: Edit inaccurate comment Belen Barros Pena
2016-05-24 11:39 ` [PATCH 046/106] toaster: fix buttons in tables Belen Barros Pena
2016-05-24 11:39 ` [PATCH 047/106] toaster: Fix popover content Belen Barros Pena
2016-05-24 11:39 ` [PATCH 048/106] toaster: Tweaking modal dialogs Belen Barros Pena
2016-05-24 11:39 ` [PATCH 049/106] toaster: Fix buttons in custom image details page Belen Barros Pena
2016-05-24 11:39 ` [PATCH 050/106] toaster: More width to the "Edit columns" menu Belen Barros Pena
2016-05-24 11:39 ` [PATCH 051/106] toaster: Adjust labels in modal dialogs Belen Barros Pena
2016-05-24 11:39 ` [PATCH 052/106] toaster: Fix 'New project' page Belen Barros Pena
2016-05-24 11:39 ` [PATCH 053/106] toaster: Fix the project created notification Belen Barros Pena
2016-05-24 11:39 ` [PATCH 054/106] toaster: Fix errors and warnings info Belen Barros Pena
2016-05-24 11:39 ` [PATCH 055/106] toaster: Fix landing page Belen Barros Pena
2016-05-24 11:39 ` [PATCH 056/106] toaster: Fix reverse dependencies modal dialogs Belen Barros Pena
2016-05-24 11:39 ` [PATCH 057/106] toaster: Table cell notifications style Belen Barros Pena
2016-05-24 11:39 ` [PATCH 058/106] toaster: importlayer Make sure we eat the default event on submit Belen Barros Pena
2016-05-24 11:39 ` [PATCH 059/106] toaster: Update OE json file Belen Barros Pena
2016-05-24 14:57 ` Michael Wood
2016-05-24 11:39 ` [PATCH 060/106] toaster: work-around our lack of a synchronous fetch for typeaheads Belen Barros Pena
2016-05-24 11:39 ` [PATCH 061/106] toaster: Remove old bootstrap files left behind Belen Barros Pena
2016-05-24 11:39 ` [PATCH 062/106] toaster: Fix the custom image modal dialogs Belen Barros Pena
2016-05-24 11:39 ` [PATCH 063/106] toaster: Comment out unnecessary css Belen Barros Pena
2016-05-24 11:39 ` [PATCH 064/106] toaster: Create new custom css file Belen Barros Pena
2016-05-24 11:39 ` [PATCH 065/106] toaster: Base template to Bootstrap 3 Belen Barros Pena
2016-05-24 11:39 ` [PATCH 066/106] toaster: body styles for " Belen Barros Pena
2016-05-24 11:39 ` [PATCH 067/106] toaster: Move latest builds to " Belen Barros Pena
2016-05-24 11:39 ` [PATCH 068/106] toaster: Fix the recipe file download Belen Barros Pena
2016-05-24 11:39 ` [PATCH 069/106] toaster: Table controls to Bootstrap 3 Belen Barros Pena
2016-05-24 11:39 ` [PATCH 070/106] toaster: Fix the toastertable table headings Belen Barros Pena
2016-05-24 11:39 ` [PATCH 071/106] toaster: Remove spurious div Belen Barros Pena
2016-05-24 11:39 ` [PATCH 072/106] toaster: Fix 'all builds' table content Belen Barros Pena
2016-05-24 11:39 ` [PATCH 073/106] toaster: Fix bottom table controls Belen Barros Pena
2016-05-24 11:39 ` [PATCH 074/106] toaster: Fix 'all projects' table content Belen Barros Pena
2016-05-24 11:39 ` [PATCH 075/106] toaster: Configuration page to Bootstrap 3 Belen Barros Pena
2016-05-24 11:39 ` [PATCH 076/106] toaster: 'Project builds' " Belen Barros Pena
2016-05-24 11:39 ` [PATCH 077/106] toaster: Project builds empty state Belen Barros Pena
2016-05-24 11:39 ` [PATCH 078/106] toaster: Style typeaheads Belen Barros Pena
2016-05-24 11:39 ` [PATCH 079/106] toaster: Fix display of failed tasks Belen Barros Pena
2016-05-24 11:39 ` [PATCH 080/106] toaster: Fix the import layer form Belen Barros Pena
2016-05-24 11:39 ` [PATCH 081/106] toaster: Fix the toaster tables no results Belen Barros Pena
2016-05-24 11:39 ` [PATCH 082/106] toaster: Show heading in no results page Belen Barros Pena
2016-05-24 11:39 ` [PATCH 083/106] toaster: Fix new custom image page Belen Barros Pena
2016-05-24 11:39 ` [PATCH 084/106] toaster: toaster tables Enable complex empty states Belen Barros Pena
2016-05-24 11:39 ` [PATCH 085/106] toaster: Custom images to Bootstrap 3 Belen Barros Pena
2016-05-24 11:39 ` [PATCH 086/106] toaster: project builds Improve empty state Belen Barros Pena
2016-05-24 11:39 ` [PATCH 087/106] toaster: recipes tables Tweaks for Bootstrap 3 Belen Barros Pena
2016-05-24 11:39 ` [PATCH 088/106] toaster: machines table Changes " Belen Barros Pena
2016-05-24 11:39 ` [PATCH 089/106] toaster: layers " Belen Barros Pena
2016-05-24 11:39 ` [PATCH 090/106] toaster: breadcrumbs Fix " Belen Barros Pena
2016-05-24 11:39 ` [PATCH 091/106] toaster: layerdetails Fix the layer details page Belen Barros Pena
2016-05-24 11:39 ` [PATCH 092/106] toaster: custom recipe Fix the custom recipe " Belen Barros Pena
2016-05-24 11:39 ` [PATCH 093/106] toaster: recipe details Fix the image " Belen Barros Pena
2016-05-24 11:39 ` [PATCH 094/106] toaster: bb variables BitBake variables page to Bootstrap 3 Belen Barros Pena
2016-05-24 11:39 ` [PATCH 095/106] toaster: recent builds Consistent rebuild links Belen Barros Pena
2016-05-24 11:39 ` [PATCH 096/106] toaster: filters Filter modals to Bootstrap 3 Belen Barros Pena
2016-05-24 11:39 ` [PATCH 097/106] toaster: latest builds Style cancel option Belen Barros Pena
2016-05-24 11:39 ` [PATCH 098/106] toaster: custom image modals Move to Bootstrap 3 Belen Barros Pena
2016-05-24 11:39 ` [PATCH 099/106] toaster: modals Package dependencies modals " Belen Barros Pena
2016-05-24 11:39 ` [PATCH 100/106] toaster: modals Layer dependencies " Belen Barros Pena
2016-05-24 11:39 ` [PATCH 101/106] toaster: notifications Move to Boostrap 3 Belen Barros Pena
2016-05-24 11:39 ` [PATCH 102/106] toaster: new project " Belen Barros Pena
2016-05-24 11:40 ` [PATCH 103/106] toaster: notifications Add dismissible class Belen Barros Pena
2016-05-24 11:40 ` [PATCH 104/106] toaster: landing Move to Bootstrap 3 Belen Barros Pena
2016-05-24 11:40 ` [PATCH 105/106] toaster: Add new image type " Belen Barros Pena
2016-05-24 11:40 ` [PATCH 106/106] toaster: Unique project names to Boostrap 3 Belen Barros Pena
2016-05-24 15:34 ` Michael Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57447474.4010301@intel.com \
--to=michael.g.wood@intel.com \
--cc=toaster@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.