From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/4] tests: Remove unnecessary glib.h includes
Date: Tue, 24 May 2016 10:51:12 -0600 [thread overview]
Message-ID: <57448680.2070600@redhat.com> (raw)
In-Reply-To: <1464103479-26913-3-git-send-email-peter.maydell@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 677 bytes --]
On 05/24/2016 09:24 AM, Peter Maydell wrote:
> Remove glib.h includes, as it is provided by osdep.h.
>
> This commit was created with scripts/clean-includes.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> +++ b/tests/ds1338-test.c
> @@ -21,7 +21,6 @@
> #include "libqtest.h"
> #include "libqos/i2c.h"
>
> -#include <glib.h>
>
> #define IMX25_I2C_0_BASE 0x43F80000
I'm guessing we don't care about the double blank lines left for
cleanups like this (I know I don't, just pointing it out in case someone
else does).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 2/4] tests: Remove unnecessary glib.h includes
Date: Tue, 24 May 2016 10:51:12 -0600 [thread overview]
Message-ID: <57448680.2070600@redhat.com> (raw)
In-Reply-To: <1464103479-26913-3-git-send-email-peter.maydell@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 677 bytes --]
On 05/24/2016 09:24 AM, Peter Maydell wrote:
> Remove glib.h includes, as it is provided by osdep.h.
>
> This commit was created with scripts/clean-includes.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> +++ b/tests/ds1338-test.c
> @@ -21,7 +21,6 @@
> #include "libqtest.h"
> #include "libqos/i2c.h"
>
> -#include <glib.h>
>
> #define IMX25_I2C_0_BASE 0x43F80000
I'm guessing we don't care about the double blank lines left for
cleanups like this (I know I don't, just pointing it out in case someone
else does).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-05-24 16:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 15:24 [Qemu-trivial] [PATCH 0/4] Remove unnecessary glib.h includes Peter Maydell
2016-05-24 15:24 ` [Qemu-devel] " Peter Maydell
2016-05-24 15:24 ` [Qemu-trivial] [PATCH 1/4] clean-includes: Add glib.h to list of unneeded includes Peter Maydell
2016-05-24 15:24 ` [Qemu-devel] " Peter Maydell
2016-05-24 15:24 ` [Qemu-trivial] [PATCH 2/4] tests: Remove unnecessary glib.h includes Peter Maydell
2016-05-24 15:24 ` [Qemu-devel] " Peter Maydell
2016-05-24 16:51 ` Eric Blake [this message]
2016-05-24 16:51 ` Eric Blake
2016-05-24 15:24 ` [Qemu-trivial] [PATCH 3/4] qga: " Peter Maydell
2016-05-24 15:24 ` [Qemu-devel] " Peter Maydell
2016-05-24 15:24 ` [Qemu-trivial] [PATCH 4/4] all: " Peter Maydell
2016-05-24 15:24 ` [Qemu-devel] " Peter Maydell
2016-05-24 17:01 ` [Qemu-trivial] [Qemu-devel] [PATCH 0/4] " Eric Blake
2016-05-24 17:01 ` Eric Blake
2016-05-29 8:48 ` [Qemu-trivial] " Michael Tokarev
2016-05-29 8:48 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57448680.2070600@redhat.com \
--to=eblake@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.