From: Jens Axboe <axboe@kernel.dk>
To: Ben England <bengland@redhat.com>, fio@vger.kernel.org
Cc: Tim Wilkinson <twilkins@redhat.com>
Subject: Re: assert failing with latency log
Date: Tue, 24 May 2016 18:41:42 -0600 [thread overview]
Message-ID: <5744F4C6.5060700@kernel.dk> (raw)
In-Reply-To: <897324962.65623516.1464126010451.JavaMail.zimbra@redhat.com>
On 05/24/2016 03:40 PM, Ben England wrote:
> If I run this fio jobfile with absolute latest upstream code:
>
> [global]
> directory=/var/tmp
>
> [randreads]
> direct=1
> rate_iops=1000
> size=512m
> ioengine=sync
> bs=4k
> rw=randread
> filename=ben.dd
> runtime=30
> write_lat_log=foo
>
> It fails with
>
> fio: stat.c:1988: get_cur_log: Assertion `iolog->pending->nr_samples < iolog->pending->max_samples' failed.
>
> But if I take out the "write_lat_log=foo" line, it succeeds. The assertion seems to be in the code path for latency logs, right? Anyone else seen this?
Gah, that's my bad, I broke sync IO engines with logging. I pushed a fix:
http://git.kernel.dk/cgit/fio/commit/?id=cf2c8d5260c9676964854e79382cba3eb498fd2e
I'll tag a new version as well, this is pretty unfortunate.
--
Jens Axboe
next prev parent reply other threads:[~2016-05-25 0:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <632274204.65621860.1464125206824.JavaMail.zimbra@redhat.com>
2016-05-24 21:40 ` assert failing with latency log Ben England
2016-05-25 0:41 ` Jens Axboe [this message]
2016-05-25 2:02 ` Ben England
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5744F4C6.5060700@kernel.dk \
--to=axboe@kernel.dk \
--cc=bengland@redhat.com \
--cc=fio@vger.kernel.org \
--cc=twilkins@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.