* assert failing with latency log [not found] <632274204.65621860.1464125206824.JavaMail.zimbra@redhat.com> @ 2016-05-24 21:40 ` Ben England 2016-05-25 0:41 ` Jens Axboe 0 siblings, 1 reply; 3+ messages in thread From: Ben England @ 2016-05-24 21:40 UTC (permalink / raw) To: fio; +Cc: Tim Wilkinson If I run this fio jobfile with absolute latest upstream code: [global] directory=/var/tmp [randreads] direct=1 rate_iops=1000 size=512m ioengine=sync bs=4k rw=randread filename=ben.dd runtime=30 write_lat_log=foo It fails with fio: stat.c:1988: get_cur_log: Assertion `iolog->pending->nr_samples < iolog->pending->max_samples' failed. But if I take out the "write_lat_log=foo" line, it succeeds. The assertion seems to be in the code path for latency logs, right? Anyone else seen this? ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: assert failing with latency log 2016-05-24 21:40 ` assert failing with latency log Ben England @ 2016-05-25 0:41 ` Jens Axboe 2016-05-25 2:02 ` Ben England 0 siblings, 1 reply; 3+ messages in thread From: Jens Axboe @ 2016-05-25 0:41 UTC (permalink / raw) To: Ben England, fio; +Cc: Tim Wilkinson On 05/24/2016 03:40 PM, Ben England wrote: > If I run this fio jobfile with absolute latest upstream code: > > [global] > directory=/var/tmp > > [randreads] > direct=1 > rate_iops=1000 > size=512m > ioengine=sync > bs=4k > rw=randread > filename=ben.dd > runtime=30 > write_lat_log=foo > > It fails with > > fio: stat.c:1988: get_cur_log: Assertion `iolog->pending->nr_samples < iolog->pending->max_samples' failed. > > But if I take out the "write_lat_log=foo" line, it succeeds. The assertion seems to be in the code path for latency logs, right? Anyone else seen this? Gah, that's my bad, I broke sync IO engines with logging. I pushed a fix: http://git.kernel.dk/cgit/fio/commit/?id=cf2c8d5260c9676964854e79382cba3eb498fd2e I'll tag a new version as well, this is pretty unfortunate. -- Jens Axboe ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: assert failing with latency log 2016-05-25 0:41 ` Jens Axboe @ 2016-05-25 2:02 ` Ben England 0 siblings, 0 replies; 3+ messages in thread From: Ben England @ 2016-05-25 2:02 UTC (permalink / raw) To: Jens Axboe; +Cc: fio, Tim Wilkinson thx, that worked. -ben ----- Original Message ----- > From: "Jens Axboe" <axboe@kernel.dk> > To: "Ben England" <bengland@redhat.com>, fio@vger.kernel.org > Cc: "Tim Wilkinson" <twilkins@redhat.com> > Sent: Tuesday, May 24, 2016 8:41:42 PM > Subject: Re: assert failing with latency log > > On 05/24/2016 03:40 PM, Ben England wrote: > > If I run this fio jobfile with absolute latest upstream code: > > > > [global] > > directory=/var/tmp > > > > [randreads] > > direct=1 > > rate_iops=1000 > > size=512m > > ioengine=sync > > bs=4k > > rw=randread > > filename=ben.dd > > runtime=30 > > write_lat_log=foo > > > > It fails with > > > > fio: stat.c:1988: get_cur_log: Assertion `iolog->pending->nr_samples < > > iolog->pending->max_samples' failed. > > > > But if I take out the "write_lat_log=foo" line, it succeeds. The assertion > > seems to be in the code path for latency logs, right? Anyone else seen > > this? > > Gah, that's my bad, I broke sync IO engines with logging. I pushed a fix: > > http://git.kernel.dk/cgit/fio/commit/?id=cf2c8d5260c9676964854e79382cba3eb498fd2e > > I'll tag a new version as well, this is pretty unfortunate. > > -- > Jens Axboe > > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-25 2:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <632274204.65621860.1464125206824.JavaMail.zimbra@redhat.com>
2016-05-24 21:40 ` assert failing with latency log Ben England
2016-05-25 0:41 ` Jens Axboe
2016-05-25 2:02 ` Ben England
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.