From: Heiko Stuebner <heiko@sntech.de>
To: John Keeping <john@metanate.com>
Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org
Subject: Re: [RFC/PATCH] drm/rockchip: don't wait for vblank if fb hasn't changed
Date: Sun, 17 Jan 2016 16:21:08 +0100 [thread overview]
Message-ID: <5745581.hZKD3MVpjF@phil> (raw)
In-Reply-To: <1452689614-6570-1-git-send-email-john@metanate.com>
Am Mittwoch, 13. Januar 2016, 12:53:34 schrieb John Keeping:
> As commented in drm_atomic_helper_wait_for_vblanks(), userspace relies
> on cursor ioctls being unsynced. Converting the rockchip driver to
> atomic has significantly impacted cursor performance by making every
> cursor update wait for vblank.
>
> By skipping the vblank sync when the framebuffer has not changed (as is
> done in drm_atomic_helper_wait_for_vblanks()) we can avoid this for the
> common case of moving the cursor and only need to delay the cursor ioctl
> when the cursor icon changes.
>
> I originally inserted a check on legacy_cursor_update as well, but that
> caused a storm of iommu page faults. I didn't investigate the cause of
> those since this change gives enough of a performance improvement for my
> use case.
>
> This is RFC because of that and because the framebuffer_changed()
> function is copied from drm_atomic_helper.c as a quick way to test the
> result.
>
> Signed-off-by: John Keeping <john@metanate.com>
I've seen the effects now as well after making the atomic parts work on in
my devtree - i.e. sluggish cursor movements.
This patch fixes that issue, so at least:
Tested-by: Heiko Stuebner <heiko@sntech.de>
Right now I still see flickering on animated cursors though (like ones used
by KDE), that wasn't present before.
Heiko
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC/PATCH] drm/rockchip: don't wait for vblank if fb hasn't changed
Date: Sun, 17 Jan 2016 16:21:08 +0100 [thread overview]
Message-ID: <5745581.hZKD3MVpjF@phil> (raw)
In-Reply-To: <1452689614-6570-1-git-send-email-john@metanate.com>
Am Mittwoch, 13. Januar 2016, 12:53:34 schrieb John Keeping:
> As commented in drm_atomic_helper_wait_for_vblanks(), userspace relies
> on cursor ioctls being unsynced. Converting the rockchip driver to
> atomic has significantly impacted cursor performance by making every
> cursor update wait for vblank.
>
> By skipping the vblank sync when the framebuffer has not changed (as is
> done in drm_atomic_helper_wait_for_vblanks()) we can avoid this for the
> common case of moving the cursor and only need to delay the cursor ioctl
> when the cursor icon changes.
>
> I originally inserted a check on legacy_cursor_update as well, but that
> caused a storm of iommu page faults. I didn't investigate the cause of
> those since this change gives enough of a performance improvement for my
> use case.
>
> This is RFC because of that and because the framebuffer_changed()
> function is copied from drm_atomic_helper.c as a quick way to test the
> result.
>
> Signed-off-by: John Keeping <john@metanate.com>
I've seen the effects now as well after making the atomic parts work on in
my devtree - i.e. sluggish cursor movements.
This patch fixes that issue, so at least:
Tested-by: Heiko Stuebner <heiko@sntech.de>
Right now I still see flickering on animated cursors though (like ones used
by KDE), that wasn't present before.
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: John Keeping <john@metanate.com>
Cc: Mark Yao <mark.yao@rock-chips.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC/PATCH] drm/rockchip: don't wait for vblank if fb hasn't changed
Date: Sun, 17 Jan 2016 16:21:08 +0100 [thread overview]
Message-ID: <5745581.hZKD3MVpjF@phil> (raw)
In-Reply-To: <1452689614-6570-1-git-send-email-john@metanate.com>
Am Mittwoch, 13. Januar 2016, 12:53:34 schrieb John Keeping:
> As commented in drm_atomic_helper_wait_for_vblanks(), userspace relies
> on cursor ioctls being unsynced. Converting the rockchip driver to
> atomic has significantly impacted cursor performance by making every
> cursor update wait for vblank.
>
> By skipping the vblank sync when the framebuffer has not changed (as is
> done in drm_atomic_helper_wait_for_vblanks()) we can avoid this for the
> common case of moving the cursor and only need to delay the cursor ioctl
> when the cursor icon changes.
>
> I originally inserted a check on legacy_cursor_update as well, but that
> caused a storm of iommu page faults. I didn't investigate the cause of
> those since this change gives enough of a performance improvement for my
> use case.
>
> This is RFC because of that and because the framebuffer_changed()
> function is copied from drm_atomic_helper.c as a quick way to test the
> result.
>
> Signed-off-by: John Keeping <john@metanate.com>
I've seen the effects now as well after making the atomic parts work on in
my devtree - i.e. sluggish cursor movements.
This patch fixes that issue, so at least:
Tested-by: Heiko Stuebner <heiko@sntech.de>
Right now I still see flickering on animated cursors though (like ones used
by KDE), that wasn't present before.
Heiko
next prev parent reply other threads:[~2016-01-17 15:21 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 12:53 [RFC/PATCH] drm/rockchip: don't wait for vblank if fb hasn't changed John Keeping
2016-01-13 12:53 ` John Keeping
2016-01-13 12:53 ` John Keeping
2016-01-13 14:23 ` Daniel Vetter
2016-01-13 14:23 ` Daniel Vetter
2016-01-13 14:23 ` Daniel Vetter
2016-01-13 14:34 ` John Keeping
2016-01-13 14:34 ` John Keeping
2016-01-13 14:34 ` John Keeping
2016-01-13 15:40 ` Daniel Vetter
2016-01-13 15:40 ` Daniel Vetter
2016-01-13 15:40 ` Daniel Vetter
2016-01-13 15:55 ` John Keeping
2016-01-13 15:55 ` John Keeping
2016-01-13 15:55 ` John Keeping
2016-01-13 16:21 ` Daniel Vetter
2016-01-13 16:21 ` Daniel Vetter
2016-01-13 16:21 ` Daniel Vetter
2016-01-13 16:40 ` John Keeping
2016-01-13 16:40 ` John Keeping
2016-01-13 16:40 ` John Keeping
2016-01-13 17:19 ` Daniel Vetter
2016-01-13 17:19 ` Daniel Vetter
2016-01-13 17:19 ` Daniel Vetter
2016-01-13 17:39 ` John Keeping
2016-01-13 17:39 ` John Keeping
2016-01-13 17:39 ` John Keeping
2016-01-14 1:16 ` Mark yao
2016-01-14 1:16 ` Mark yao
2016-01-14 1:16 ` Mark yao
2016-01-14 8:32 ` Daniel Vetter
2016-01-14 8:32 ` Daniel Vetter
2016-01-14 8:32 ` Daniel Vetter
2016-01-14 8:46 ` Mark yao
2016-01-14 8:46 ` Mark yao
2016-01-14 8:46 ` Mark yao
2016-01-14 14:20 ` Daniel Vetter
2016-01-14 14:20 ` Daniel Vetter
2016-01-14 14:20 ` Daniel Vetter
2016-01-14 14:39 ` [PATCH 0/3] drm/rockchip: fix cursor performance with atomic John Keeping
2016-01-14 14:39 ` John Keeping
2016-01-14 14:39 ` John Keeping
2016-01-14 14:39 ` [PATCH 1/3] drm/atomic-helper: Export framebuffer_changed() John Keeping
2016-01-14 14:39 ` John Keeping
2016-01-14 14:39 ` John Keeping
2016-01-14 14:56 ` Daniel Vetter
2016-01-14 14:56 ` Daniel Vetter
2016-01-14 14:56 ` Daniel Vetter
2016-01-14 14:39 ` [PATCH 2/3] drm/rockchip: don't wait for vblank if fb hasn't changed John Keeping
2016-01-14 14:39 ` John Keeping
2016-01-14 14:39 ` [PATCH 3/3] drm/rockchip: explain why we can't wait_for_vblanks John Keeping
2016-01-14 14:39 ` John Keeping
2016-01-14 14:39 ` John Keeping
2016-01-14 14:57 ` Thierry Reding
2016-01-14 14:57 ` Thierry Reding
2016-01-14 14:57 ` Thierry Reding
2016-01-14 16:26 ` John Keeping
2016-01-14 16:26 ` John Keeping
2016-01-14 16:26 ` John Keeping
2016-01-18 1:40 ` Mark yao
2016-01-18 1:40 ` Mark yao
2016-01-18 1:40 ` Mark yao
2016-01-19 10:46 ` [PATCH v2 0/3] drm/rockchip: fix cursor performance with atomic John Keeping
2016-01-19 10:46 ` John Keeping
2016-01-19 10:46 ` John Keeping
2016-01-19 10:46 ` [PATCH v2 1/3] drm/atomic-helper: Export framebuffer_changed() John Keeping
2016-01-19 10:46 ` John Keeping
2016-01-19 10:46 ` John Keeping
2016-01-19 11:03 ` Daniel Vetter
2016-01-19 11:03 ` Daniel Vetter
2016-01-19 11:03 ` Daniel Vetter
2016-01-19 10:46 ` [PATCH v2 2/3] drm/rockchip: don't wait for vblank if fb hasn't changed John Keeping
2016-01-19 10:46 ` John Keeping
2016-01-19 10:46 ` John Keeping
2016-01-19 10:47 ` [PATCH v2 3/3] drm/rockchip: explain why we can't wait_for_vblanks John Keeping
2016-01-19 10:47 ` John Keeping
2016-01-19 10:47 ` John Keeping
2016-01-21 0:51 ` [PATCH v2 0/3] drm/rockchip: fix cursor performance with atomic Mark yao
2016-01-21 0:51 ` Mark yao
2016-01-21 0:51 ` Mark yao
2016-01-17 15:21 ` Heiko Stuebner [this message]
2016-01-17 15:21 ` [RFC/PATCH] drm/rockchip: don't wait for vblank if fb hasn't changed Heiko Stuebner
2016-01-17 15:21 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5745581.hZKD3MVpjF@phil \
--to=heiko@sntech.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=john@metanate.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.