From: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: Stefano Stabellini
<sstabellini-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
Bartlomiej Zolnierkiewicz
<b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 0/4] dma-mapping: Constify dma_attrs
Date: Wed, 25 May 2016 14:37:13 +0200 [thread overview]
Message-ID: <57459C79.8060204@samsung.com> (raw)
In-Reply-To: <20160524090938.GA13166-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
On 05/24/2016 11:09 AM, Christoph Hellwig wrote:
> I think this is moving into the wrong direction. The right fix here
> is to get of all the dma_attrs boilerplate code and just replace it
> with a simple enum dma_flags. This would simplify both the callers
> and most importantly the wrappers for the flag-less versions a lot.
The dma attrs are additive so maybe not an enum but an unsigned long and
#defines:
#define DMA_ATTR_WRITE_BARRIER 0x0001u
#define DMA_ATTR_WEAK_ORDERING 0x0002u
#define DMA_ATTR_WRITE_COMBINE 0x0004u
...
The intrusiveness of it would be similar but indeed looks simpler - when
reading the code and when setting the dma_attrs.
If that seems reasonable, I will send a follow up with new approach.
Thanks for feedback!
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] dma-mapping: Constify dma_attrs
Date: Wed, 25 May 2016 14:37:13 +0200 [thread overview]
Message-ID: <57459C79.8060204@samsung.com> (raw)
In-Reply-To: <20160524090938.GA13166@infradead.org>
On 05/24/2016 11:09 AM, Christoph Hellwig wrote:
> I think this is moving into the wrong direction. The right fix here
> is to get of all the dma_attrs boilerplate code and just replace it
> with a simple enum dma_flags. This would simplify both the callers
> and most importantly the wrappers for the flag-less versions a lot.
The dma attrs are additive so maybe not an enum but an unsigned long and
#defines:
#define DMA_ATTR_WRITE_BARRIER 0x0001u
#define DMA_ATTR_WEAK_ORDERING 0x0002u
#define DMA_ATTR_WRITE_COMBINE 0x0004u
...
The intrusiveness of it would be similar but indeed looks simpler - when
reading the code and when setting the dma_attrs.
If that seems reasonable, I will send a follow up with new approach.
Thanks for feedback!
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Russell King <linux@armlinux.org.uk>,
Stefano Stabellini <sstabellini@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>, Joerg Roedel <joro@8bytes.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
iommu@lists.linux-foundation.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 0/4] dma-mapping: Constify dma_attrs
Date: Wed, 25 May 2016 14:37:13 +0200 [thread overview]
Message-ID: <57459C79.8060204@samsung.com> (raw)
In-Reply-To: <20160524090938.GA13166@infradead.org>
On 05/24/2016 11:09 AM, Christoph Hellwig wrote:
> I think this is moving into the wrong direction. The right fix here
> is to get of all the dma_attrs boilerplate code and just replace it
> with a simple enum dma_flags. This would simplify both the callers
> and most importantly the wrappers for the flag-less versions a lot.
The dma attrs are additive so maybe not an enum but an unsigned long and
#defines:
#define DMA_ATTR_WRITE_BARRIER 0x0001u
#define DMA_ATTR_WEAK_ORDERING 0x0002u
#define DMA_ATTR_WRITE_COMBINE 0x0004u
...
The intrusiveness of it would be similar but indeed looks simpler - when
reading the code and when setting the dma_attrs.
If that seems reasonable, I will send a follow up with new approach.
Thanks for feedback!
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-05-25 12:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 6:28 [PATCH 0/4] dma-mapping: Constify dma_attrs Krzysztof Kozlowski
2016-05-24 6:28 ` Krzysztof Kozlowski
2016-05-24 6:28 ` Krzysztof Kozlowski
2016-05-24 6:28 ` [PATCH 1/4] dma-mapping: Constify attrs passed to dma_get_attr Krzysztof Kozlowski
2016-05-24 6:28 ` [PATCH 2/4] ARM: dma-mapping: Constify attrs passed to internal functions Krzysztof Kozlowski
2016-05-24 6:28 ` [PATCH 3/4] arm64: " Krzysztof Kozlowski
2016-05-24 6:28 ` Krzysztof Kozlowski
2016-05-24 6:28 ` Krzysztof Kozlowski
[not found] ` <1464071290-15948-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-05-24 6:28 ` [PATCH 1/4] dma-mapping: Constify attrs passed to dma_get_attr Krzysztof Kozlowski
2016-05-24 6:28 ` Krzysztof Kozlowski
2016-05-24 6:28 ` Krzysztof Kozlowski
2016-05-24 6:28 ` [PATCH 2/4] ARM: dma-mapping: Constify attrs passed to internal functions Krzysztof Kozlowski
2016-05-24 6:28 ` Krzysztof Kozlowski
2016-05-24 6:28 ` Krzysztof Kozlowski
2016-05-24 8:35 ` Russell King - ARM Linux
2016-05-24 8:35 ` Russell King - ARM Linux
2016-05-24 8:35 ` Russell King - ARM Linux
2016-05-24 6:28 ` [RFC 4/4] dma-mapping: Constify dma_attrs Krzysztof Kozlowski
2016-05-24 6:28 ` Krzysztof Kozlowski
2016-05-24 6:28 ` Krzysztof Kozlowski
2016-05-24 6:28 ` Krzysztof Kozlowski
2016-05-24 9:09 ` [PATCH 0/4] " Christoph Hellwig
2016-05-24 9:09 ` Christoph Hellwig
2016-05-24 9:09 ` Christoph Hellwig
2016-05-25 12:37 ` Krzysztof Kozlowski
[not found] ` <20160524090938.GA13166-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-05-25 12:37 ` Krzysztof Kozlowski [this message]
2016-05-25 12:37 ` Krzysztof Kozlowski
2016-05-25 12:37 ` Krzysztof Kozlowski
2016-05-24 9:09 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2016-05-24 6:28 Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57459C79.8060204@samsung.com \
--to=k.kozlowski-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sstabellini-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
--cc=xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.