[PATCH v4 1/3] firmware: Amlogic: Add secure monitor driver

All of lore.kernel.org
 help / color / mirror / Atom feed

From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v4 1/3] firmware: Amlogic: Add secure monitor driver
Date: Thu, 26 May 2016 09:17:28 +0200	[thread overview]
Message-ID: <5746A308.8070606@baylibre.com> (raw)
In-Reply-To: <1464207511-11786-2-git-send-email-carlo@caione.org>

Hi Carlo,

On 05/25/2016 10:18 PM, Carlo Caione wrote:
> diff --git a/include/dt-bindings/firmware/meson-sm.h b/include/dt-bindings/firmware/meson-sm.h
> new file mode 100644
> index 0000000..3a52a13
> --- /dev/null
> +++ b/include/dt-bindings/firmware/meson-sm.h
> @@ -0,0 +1,20 @@
> +/*
> + * Copyright (C) 2016 Endless Mobile, Inc.
> + * Author: Carlo Caione <carlo@endlessm.com>
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * version 2 as published by the Free Software Foundation.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program. If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#ifndef _MESON_DT_H_
> +#define _MESON_DT_H_
> +
> +#define SM_EFUSE_READ		0
> +#define SM_EFUSE_WRITE		1
> +#define SM_EFUSE_USER_MAX	2
> +
> +#endif /* _MESON_DT_H_ */

Now this has been refactored, I don't see the point of this dt-bindings header ?

These defines should take place in linux/firmware/meson/meson-sm.h

Neil

WARNING: multiple messages have this Message-ID (diff)

From: narmstrong@baylibre.com (Neil Armstrong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/3] firmware: Amlogic: Add secure monitor driver
Date: Thu, 26 May 2016 09:17:28 +0200	[thread overview]
Message-ID: <5746A308.8070606@baylibre.com> (raw)
In-Reply-To: <1464207511-11786-2-git-send-email-carlo@caione.org>

Hi Carlo,

On 05/25/2016 10:18 PM, Carlo Caione wrote:
> diff --git a/include/dt-bindings/firmware/meson-sm.h b/include/dt-bindings/firmware/meson-sm.h
> new file mode 100644
> index 0000000..3a52a13
> --- /dev/null
> +++ b/include/dt-bindings/firmware/meson-sm.h
> @@ -0,0 +1,20 @@
> +/*
> + * Copyright (C) 2016 Endless Mobile, Inc.
> + * Author: Carlo Caione <carlo@endlessm.com>
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * version 2 as published by the Free Software Foundation.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program. If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#ifndef _MESON_DT_H_
> +#define _MESON_DT_H_
> +
> +#define SM_EFUSE_READ		0
> +#define SM_EFUSE_WRITE		1
> +#define SM_EFUSE_USER_MAX	2
> +
> +#endif /* _MESON_DT_H_ */

Now this has been refactored, I don't see the point of this dt-bindings header ?

These defines should take place in linux/firmware/meson/meson-sm.h

Neil

WARNING: multiple messages have this Message-ID (diff)

From: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
To: Carlo Caione <carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-6IF/jdPJHihWk0Htik3J/w@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: Carlo Caione <carlo-6IF/jdPJHihWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH v4 1/3] firmware: Amlogic: Add secure monitor driver
Date: Thu, 26 May 2016 09:17:28 +0200	[thread overview]
Message-ID: <5746A308.8070606@baylibre.com> (raw)
In-Reply-To: <1464207511-11786-2-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>

Hi Carlo,

On 05/25/2016 10:18 PM, Carlo Caione wrote:
> diff --git a/include/dt-bindings/firmware/meson-sm.h b/include/dt-bindings/firmware/meson-sm.h
> new file mode 100644
> index 0000000..3a52a13
> --- /dev/null
> +++ b/include/dt-bindings/firmware/meson-sm.h
> @@ -0,0 +1,20 @@
> +/*
> + * Copyright (C) 2016 Endless Mobile, Inc.
> + * Author: Carlo Caione <carlo-6IF/jdPJHihWk0Htik3J/w@public.gmane.org>
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * version 2 as published by the Free Software Foundation.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program. If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#ifndef _MESON_DT_H_
> +#define _MESON_DT_H_
> +
> +#define SM_EFUSE_READ		0
> +#define SM_EFUSE_WRITE		1
> +#define SM_EFUSE_USER_MAX	2
> +
> +#endif /* _MESON_DT_H_ */

Now this has been refactored, I don't see the point of this dt-bindings header ?

These defines should take place in linux/firmware/meson/meson-sm.h

Neil
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

next prev parent reply	other threads:[~2016-05-26  7:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-25 20:18 [PATCH v4 0/3] Add Amlogic secure monitor driver Carlo Caione
2016-05-25 20:18 ` Carlo Caione
2016-05-25 20:18 ` Carlo Caione
2016-05-25 20:18 ` [PATCH v4 1/3] firmware: Amlogic: Add " Carlo Caione
2016-05-25 20:18   ` Carlo Caione
2016-05-25 20:18   ` Carlo Caione
2016-05-26  7:17   ` Neil Armstrong [this message]
2016-05-26  7:17     ` Neil Armstrong
2016-05-26  7:17     ` Neil Armstrong
2016-05-26  7:45     ` Carlo Caione
2016-05-26  7:45       ` Carlo Caione
2016-05-26  7:45       ` Carlo Caione
2016-05-25 20:18 ` [PATCH v4 2/3] documentation: Add secure monitor binding documentation Carlo Caione
2016-05-25 20:18   ` Carlo Caione
2016-05-25 20:18   ` Carlo Caione
2016-05-26  7:20   ` Neil Armstrong
2016-05-26  7:20     ` Neil Armstrong
2016-05-26  7:20     ` Neil Armstrong
2016-05-25 20:18 ` [PATCH v4 3/3] ARM64: dts: amlogic: gxbb: Enable secure monitor Carlo Caione
2016-05-25 20:18   ` Carlo Caione
2016-05-25 20:18   ` Carlo Caione

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5746A308.8070606@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.