All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] PM / devfreq: exynos-nocp: Remove incorrect IS_ERR() check
Date: Thu, 26 May 2016 10:16:03 +0000	[thread overview]
Message-ID: <5746CCE3.5010701@samsung.com> (raw)
In-Reply-To: <20160526100238.GN11011@mwanda>

On 2016년 05월 26일 19:02, Dan Carpenter wrote:
> On Thu, May 26, 2016 at 05:12:19PM +0900, Chanwoo Choi wrote:
>> I don't recommend that you mention the name of engineer on patch description
>> directly. Except for this comment, looks good to me.
> 
> I always feel it's nicer to give credit.  Plus Julia is already a well
> known kernel dev and this was a pubic list.  (I wouldn't give credit if
> she had sent hurtful comments about my spelling to me privately, for
> example).

If you want to give credit as you mentioned, you can add the acked-by
or signed-off for Julia. But, usually, the patch description don't
include the engineer's name directly.

Thanks,
Chanwoo Choi


WARNING: multiple messages have this Message-ID (diff)
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] PM / devfreq: exynos-nocp: Remove incorrect IS_ERR() check
Date: Thu, 26 May 2016 19:16:03 +0900	[thread overview]
Message-ID: <5746CCE3.5010701@samsung.com> (raw)
In-Reply-To: <20160526100238.GN11011@mwanda>

On 2016년 05월 26일 19:02, Dan Carpenter wrote:
> On Thu, May 26, 2016 at 05:12:19PM +0900, Chanwoo Choi wrote:
>> I don't recommend that you mention the name of engineer on patch description
>> directly. Except for this comment, looks good to me.
> 
> I always feel it's nicer to give credit.  Plus Julia is already a well
> known kernel dev and this was a pubic list.  (I wouldn't give credit if
> she had sent hurtful comments about my spelling to me privately, for
> example).

If you want to give credit as you mentioned, you can add the acked-by
or signed-off for Julia. But, usually, the patch description don't
include the engineer's name directly.

Thanks,
Chanwoo Choi

  reply	other threads:[~2016-05-26 10:16 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-18 10:37 [patch] PM / devfreq: exynos-nocp: Checking for IS_ERR instead of NULL Dan Carpenter
2016-05-18 10:37 ` Dan Carpenter
2016-05-18 10:57 ` Chanwoo Choi
2016-05-18 10:57   ` Chanwoo Choi
2016-05-25 12:34 ` Chanwoo Choi
2016-05-25 12:34   ` Chanwoo Choi
2016-05-25 15:11   ` Julia Lawall
2016-05-25 15:11     ` Julia Lawall
2016-05-26  6:39     ` Dan Carpenter
2016-05-26  6:39       ` Dan Carpenter
2016-05-26  6:45     ` [patch v2] PM / devfreq: exynos-nocp: Remove incorrect IS_ERR() check Dan Carpenter
2016-05-26  6:45       ` Dan Carpenter
2016-05-26  8:12       ` Chanwoo Choi
2016-05-26  8:12         ` Chanwoo Choi
2016-05-26 10:02         ` Dan Carpenter
2016-05-26 10:02           ` Dan Carpenter
2016-05-26 10:16           ` Chanwoo Choi [this message]
2016-05-26 10:16             ` Chanwoo Choi
2016-05-26 10:51             ` Dan Carpenter
2016-05-26 10:51               ` Dan Carpenter
2016-05-26 10:57               ` Chanwoo Choi
2016-05-26 10:57                 ` Chanwoo Choi
2016-05-26 11:01                 ` Chanwoo Choi
2016-05-26 11:01                   ` Chanwoo Choi
2016-05-26 11:56         ` Dan Carpenter
2016-05-26 11:56           ` Dan Carpenter
2016-05-26 13:46           ` Chanwoo Choi
2016-05-26 13:46             ` Chanwoo Choi
2016-05-26 13:54             ` Julia Lawall
2016-05-26 13:54               ` Julia Lawall
2016-05-26 13:56             ` Dan Carpenter
2016-05-26 13:56               ` Dan Carpenter
2016-05-26 14:10               ` Chanwoo Choi
2016-05-26 14:10                 ` Chanwoo Choi
2016-05-26 14:15                 ` Julia Lawall
2016-05-26 14:15                   ` Julia Lawall
2016-05-26 16:06                 ` Dan Carpenter
2016-05-26 16:06                   ` Dan Carpenter
2016-05-26 11:13       ` Julia Lawall
2016-05-26 11:13         ` Julia Lawall
2016-06-01 10:25       ` MyungJoo Ham
2016-06-01 10:25         ` MyungJoo Ham
2016-06-01 11:33         ` Chanwoo Choi
2016-06-01 11:33           ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5746CCE3.5010701@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=dan.carpenter@oracle.com \
    --cc=julia.lawall@lip6.fr \
    --cc=k.kozlowski@samsung.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kgene@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.