All of lore.kernel.org
 help / color / mirror / Atom feed
From: xiaoqiang zhao <zxq_yx_007@163.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Rob Herring" <robh@kernel.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Alistair Francis" <alistair.francis@xilinx.com>,
	qemu-arm <qemu-arm@nongnu.org>,
	"Антон Павлов" <antonynpavlov@gmail.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH 1/6] hw/char: QOM'ify pl011 model
Date: Fri, 27 May 2016 10:06:04 +0800	[thread overview]
Message-ID: <5747AB8C.7040502@163.com> (raw)
In-Reply-To: <CAFEAcA8oEjC0wUudEpKKmtbk86eB87KOh-__QB+GrcW6LFy5uA@mail.gmail.com>


在 2016年05月25日 21:08, Peter Maydell 写道:
>> -
>> >      /* AUX / UART1 */
>> >-    /* TODO: don't call qemu_char_get_next_serial() here, instead set
>> >-     * chardev properties for each uart at the board level, once pl011
>> >-     * (uart0) has been updated to avoid qemu_char_get_next_serial()
>> >-     */
> This comment says this should be fixed by having board-level
> properties; you've removed it but this patch isn't adding
> the properties to this (SoC-level) device. I think the board
> level should be looking at serial_hds[], not this code.
>
Hi, Peter:

I found bcm2835-peripherals is only used by bcm2836 code, you mean 
this(bcm2836) is the 'board level' and I should set chardev properties 
here ?

Thanks.


WARNING: multiple messages have this Message-ID (diff)
From: xiaoqiang zhao <zxq_yx_007@163.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Rob Herring" <robh@kernel.org>,
	"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Alistair Francis" <alistair.francis@xilinx.com>,
	qemu-arm <qemu-arm@nongnu.org>,
	"Антон Павлов" <antonynpavlov@gmail.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/6] hw/char: QOM'ify pl011 model
Date: Fri, 27 May 2016 10:06:04 +0800	[thread overview]
Message-ID: <5747AB8C.7040502@163.com> (raw)
In-Reply-To: <CAFEAcA8oEjC0wUudEpKKmtbk86eB87KOh-__QB+GrcW6LFy5uA@mail.gmail.com>


在 2016年05月25日 21:08, Peter Maydell 写道:
>> -
>> >      /* AUX / UART1 */
>> >-    /* TODO: don't call qemu_char_get_next_serial() here, instead set
>> >-     * chardev properties for each uart at the board level, once pl011
>> >-     * (uart0) has been updated to avoid qemu_char_get_next_serial()
>> >-     */
> This comment says this should be fixed by having board-level
> properties; you've removed it but this patch isn't adding
> the properties to this (SoC-level) device. I think the board
> level should be looking at serial_hds[], not this code.
>
Hi, Peter:

I found bcm2835-peripherals is only used by bcm2836 code, you mean 
this(bcm2836) is the 'board level' and I should set chardev properties 
here ?

Thanks.

  parent reply	other threads:[~2016-05-27  2:06 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-25 10:58 [Qemu-devel] [PATCH 0/6] Drop the qemu_char_get_next_serial function xiaoqiang zhao
2016-05-25 10:58 ` xiaoqiang zhao
2016-05-25 10:58 ` [Qemu-devel] [PATCH 1/6] hw/char: QOM'ify pl011 model xiaoqiang zhao
2016-05-25 10:58   ` xiaoqiang zhao
2016-05-25 13:01   ` [Qemu-arm] " Paolo Bonzini
2016-05-25 13:01     ` [Qemu-devel] " Paolo Bonzini
2016-05-25 13:08   ` Peter Maydell
2016-05-25 13:08     ` Peter Maydell
2016-05-25 13:15     ` [Qemu-arm] " Paolo Bonzini
2016-05-25 13:15       ` [Qemu-devel] " Paolo Bonzini
2016-05-27  2:13       ` xiaoqiang zhao
2016-05-27  9:40         ` [Qemu-arm] " Paolo Bonzini
2016-05-27  9:40           ` Paolo Bonzini
2016-05-27  2:06     ` xiaoqiang zhao [this message]
2016-05-27  2:06       ` xiaoqiang zhao
2016-05-27  9:01       ` [Qemu-arm] " Peter Maydell
2016-05-27  9:01         ` Peter Maydell
2016-05-27  9:42         ` [Qemu-arm] " Paolo Bonzini
2016-05-27  9:42           ` Paolo Bonzini
2016-05-27 11:36           ` [Qemu-arm] " xiaoqiang zhao
2016-05-27 11:36             ` xiaoqiang zhao
2016-05-30 11:35     ` [Qemu-arm] " Markus Armbruster
2016-05-30 11:35       ` Markus Armbruster
2016-05-25 10:58 ` [Qemu-devel] [PATCH 2/6] hw/char: QOM'ify cadence_uart model xiaoqiang zhao
2016-05-25 10:58   ` xiaoqiang zhao
2016-05-25 10:58 ` [Qemu-arm] [PATCH 3/6] hw/char: QOM'ify digic-uart model xiaoqiang zhao
2016-05-25 10:58   ` [Qemu-devel] " xiaoqiang zhao
2016-05-25 10:58 ` [Qemu-arm] [PATCH 4/6] hw/char: QOM'ify stm32f2xx_usart model xiaoqiang zhao
2016-05-25 10:58   ` [Qemu-devel] " xiaoqiang zhao
2016-05-25 10:58 ` [Qemu-devel] [PATCH 5/6] hw/char: QOM'ify xilinx_uartlite model xiaoqiang zhao
2016-05-25 10:58   ` xiaoqiang zhao
2016-05-25 10:58 ` [Qemu-arm] [PATCH 6/6] char: get rid of qemu_char_get_next_serial xiaoqiang zhao
2016-05-25 10:58   ` [Qemu-devel] " xiaoqiang zhao
2016-05-25 13:03   ` [Qemu-arm] " Paolo Bonzini
2016-05-25 13:03     ` [Qemu-devel] " Paolo Bonzini
2016-05-25 13:03 ` [Qemu-arm] [PATCH 0/6] Drop the qemu_char_get_next_serial function Paolo Bonzini
2016-05-25 13:03   ` [Qemu-devel] " Paolo Bonzini
2016-06-03 18:24 ` Peter Maydell
2016-06-03 18:24   ` Peter Maydell
2016-06-04  7:13   ` xiaoqiang zhao
2016-06-04  7:13     ` xiaoqiang zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5747AB8C.7040502@163.com \
    --to=zxq_yx_007@163.com \
    --cc=alistair.francis@xilinx.com \
    --cc=antonynpavlov@gmail.com \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.