From: Stephen Warren <swarren@wwwdotorg.org>
To: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Cc: devicetree@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Kumar Gala <galak@codeaurora.org>,
linux-kernel@vger.kernel.org,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
linux-tegra@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
Alexandre Courbot <gnurou@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: tegra124: remove commas from unit addresses
Date: Fri, 27 May 2016 12:35:12 -0600 [thread overview]
Message-ID: <57489360.1030300@wwwdotorg.org> (raw)
In-Reply-To: <1464366471-23832-1-git-send-email-marcel.ziswiler@toradex.com>
On 05/27/2016 10:27 AM, Marcel Ziswiler wrote:
> Remove commas from unit addresses as suggested by Rob Herring upon me
> posting initial Apalis TK1 support:
>
> http://article.gmane.org/gmane.linux.ports.tegra/26608
> diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts
> - gpu@0,57000000 {
> + gpu@57000000 {
> /*
> * Node left disabled on purpose - the bootloader will enable
> * it after having set the VPR up
The last time a similar patch was proposed[1], I pointed out that U-Boot
uses the node name to enable the node, so this change will break GPU
functionality on this board. U-Boot has since been updated to find the
node to enable using compatible value rather than hard-coding the node
name, but this doesn't help people with existing bootloader binaries;
kernel changes shouldn't force them to upgrade the bootloader. I think
the DT node names are part of the ABI and shouldn't be changed. We can
fix this for completely new SoCs, but not existing SoCs.
[1] http://www.spinics.net/lists/devicetree/msg122164.html "[PATCH] ARM:
tegra: Remove 0, prefix from unit-addresses".
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: tegra124: remove commas from unit addresses
Date: Fri, 27 May 2016 12:35:12 -0600 [thread overview]
Message-ID: <57489360.1030300@wwwdotorg.org> (raw)
In-Reply-To: <1464366471-23832-1-git-send-email-marcel.ziswiler@toradex.com>
On 05/27/2016 10:27 AM, Marcel Ziswiler wrote:
> Remove commas from unit addresses as suggested by Rob Herring upon me
> posting initial Apalis TK1 support:
>
> http://article.gmane.org/gmane.linux.ports.tegra/26608
> diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts
> - gpu at 0,57000000 {
> + gpu at 57000000 {
> /*
> * Node left disabled on purpose - the bootloader will enable
> * it after having set the VPR up
The last time a similar patch was proposed[1], I pointed out that U-Boot
uses the node name to enable the node, so this change will break GPU
functionality on this board. U-Boot has since been updated to find the
node to enable using compatible value rather than hard-coding the node
name, but this doesn't help people with existing bootloader binaries;
kernel changes shouldn't force them to upgrade the bootloader. I think
the DT node names are part of the ABI and shouldn't be changed. We can
fix this for completely new SoCs, but not existing SoCs.
[1] http://www.spinics.net/lists/devicetree/msg122164.html "[PATCH] ARM:
tegra: Remove 0, prefix from unit-addresses".
next prev parent reply other threads:[~2016-05-27 18:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 16:27 [PATCH] arm: tegra124: remove commas from unit addresses Marcel Ziswiler
2016-05-27 16:27 ` Marcel Ziswiler
2016-05-27 16:27 ` Marcel Ziswiler
2016-05-27 18:35 ` Stephen Warren [this message]
2016-05-27 18:35 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57489360.1030300@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marcel.ziswiler@toradex.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.