From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Vincent Bernat <vincent@bernat.im>,
"David S. Miller" <davem@davemloft.net>,
Vijay Pandurangan <vijayp@vijayp.ca>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] veth: delay peer link configuration after interfaces are tied
Date: Mon, 30 May 2016 11:23:35 +0200 [thread overview]
Message-ID: <574C0697.6060506@6wind.com> (raw)
In-Reply-To: <1464520637-19784-1-git-send-email-vincent@bernat.im>
Le 29/05/2016 13:17, Vincent Bernat a écrit :
[snip]
> diff --git a/drivers/net/veth.c b/drivers/net/veth.c
> index f37a6e61d4ad..9726c4dbf659 100644
> --- a/drivers/net/veth.c
> +++ b/drivers/net/veth.c
> @@ -432,10 +432,6 @@ static int veth_newlink(struct net *src_net, struct net_device *dev,
>
> netif_carrier_off(peer);
>
> - err = rtnl_configure_link(peer, ifmp);
> - if (err < 0)
> - goto err_configure_peer;
> -
> /*
> * register dev last
> *
> @@ -466,6 +462,10 @@ static int veth_newlink(struct net *src_net, struct net_device *dev,
>
> priv = netdev_priv(peer);
> rcu_assign_pointer(priv->peer, dev);
> +
> + err = rtnl_configure_link(peer, ifmp);
> + if (err < 0)
> + goto err_configure_peer;
You should fix the error path. 'unregister_netdevice(dev)' is missing.
next prev parent reply other threads:[~2016-05-30 9:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-29 11:17 [PATCH] veth: delay peer link configuration after interfaces are tied Vincent Bernat
2016-05-30 9:23 ` Nicolas Dichtel [this message]
2016-05-30 10:11 ` Vincent Bernat
2016-05-30 15:19 ` Nicolas Dichtel
2016-05-30 15:26 ` Vincent Bernat
2016-05-30 15:47 ` Nicolas Dichtel
2016-05-30 15:58 ` [net v3] veth: advertise peer link once both links are tied together Vincent Bernat
2016-05-30 16:01 ` Vincent Bernat
2016-05-30 16:27 ` Nicolas Dichtel
2016-05-31 6:29 ` Vincent Bernat
2016-05-31 9:17 ` Nicolas Dichtel
2016-06-08 20:30 ` Lance Richardson
2016-06-10 13:15 ` Nicolas Dichtel
2016-06-10 13:20 ` Lance Richardson
2016-05-31 6:30 ` [net v4] " Vincent Bernat
2016-05-31 6:54 ` Vincent Bernat
2016-05-30 10:12 ` [PATCH] veth: delay peer link configuration after interfaces are tied Vincent Bernat
2016-05-30 10:14 ` Vincent Bernat
2016-05-30 10:13 ` Vincent Bernat
2016-05-30 15:19 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574C0697.6060506@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vijayp@vijayp.ca \
--cc=vincent@bernat.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.