From: Vincent Bernat <vincent@bernat.im>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Vijay Pandurangan <vijayp@vijayp.ca>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [net v3] veth: advertise peer link once both links are tied together
Date: Tue, 31 May 2016 08:29:29 +0200 [thread overview]
Message-ID: <m3fusyg2pi.fsf@neo.luffy.cx> (raw)
In-Reply-To: <574C69DE.3050305@6wind.com> (Nicolas Dichtel's message of "Mon, 30 May 2016 18:27:10 +0200")
❦ 30 mai 2016 18:27 CEST, Nicolas Dichtel <nicolas.dichtel@6wind.com> :
>>> +
>>> + rtmsg_ifinfo(RTM_NEWLINK, peer, IFF_SLAVE, GFP_KERNEL);
>>
>> Maybe ~0U would be better than hijacking IFF_SLAVE?
> IFF_SLAVE is wrong. It's a flag here, that will be put in the ifi_change field
> not an attribute number.
There are some use of IFF_SLAVE (in bonding/bond_main.c). But, I'll
update the patch nonetheless.
--
Use free-form input when possible.
- The Elements of Programming Style (Kernighan & Plauger)
next prev parent reply other threads:[~2016-05-31 6:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-29 11:17 [PATCH] veth: delay peer link configuration after interfaces are tied Vincent Bernat
2016-05-30 9:23 ` Nicolas Dichtel
2016-05-30 10:11 ` Vincent Bernat
2016-05-30 15:19 ` Nicolas Dichtel
2016-05-30 15:26 ` Vincent Bernat
2016-05-30 15:47 ` Nicolas Dichtel
2016-05-30 15:58 ` [net v3] veth: advertise peer link once both links are tied together Vincent Bernat
2016-05-30 16:01 ` Vincent Bernat
2016-05-30 16:27 ` Nicolas Dichtel
2016-05-31 6:29 ` Vincent Bernat [this message]
2016-05-31 9:17 ` Nicolas Dichtel
2016-06-08 20:30 ` Lance Richardson
2016-06-10 13:15 ` Nicolas Dichtel
2016-06-10 13:20 ` Lance Richardson
2016-05-31 6:30 ` [net v4] " Vincent Bernat
2016-05-31 6:54 ` Vincent Bernat
2016-05-30 10:12 ` [PATCH] veth: delay peer link configuration after interfaces are tied Vincent Bernat
2016-05-30 10:14 ` Vincent Bernat
2016-05-30 10:13 ` Vincent Bernat
2016-05-30 15:19 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fusyg2pi.fsf@neo.luffy.cx \
--to=vincent@bernat.im \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=vijayp@vijayp.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.