All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luis de Bethencourt <luisbg@osg.samsung.com>
To: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>,
	abbotti@mev.co.uk, hsweeten@visionengravers.com,
	gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue in s626.c
Date: Mon, 30 May 2016 15:15:02 +0100	[thread overview]
Message-ID: <574C4AE6.2010804@osg.samsung.com> (raw)
In-Reply-To: <1464413211-7947-3-git-send-email-ravishankarkm32@gmail.com>

On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the s626.c file that fixes up a
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> found by the checkpatch.pl tool
> 
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>

The patch looks good :) adding the int makes it more verbose.

Just the same comment as the previous patch, we can see in the diff which file
is affected by this. You can just say:
"This fixes a WARNING: Prefer 'unsigned int' ..."

Thanks,
Luis

  reply	other threads:[~2016-05-30 14:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-28  5:26 [PATCH v2 1/4] staging : comedi : fix type issues in s626.c Ravishankar Karkala Mallikarjunayya
2016-05-28  5:26 ` [PATCH v2 2/4] Staging: comedi: Fix WARNING issue " Ravishankar Karkala Mallikarjunayya
2016-05-30 14:11   ` Luis de Bethencourt
2016-05-31 10:30   ` Ian Abbott
2016-05-28  5:26 ` [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned " Ravishankar Karkala Mallikarjunayya
2016-05-30 14:15   ` Luis de Bethencourt [this message]
2016-05-31 10:31   ` Ian Abbott
2016-05-28  5:26 ` [PATCH v2 4/4] Staging: comedi: fix line over 80 characters " Ravishankar Karkala Mallikarjunayya
2016-05-30 14:21   ` Luis de Bethencourt
2016-06-18  3:51     ` Greg KH
2016-06-18 14:21       ` Luis de Bethencourt
2016-05-31 10:31   ` Ian Abbott
2016-05-30 14:01 ` [PATCH v2 1/4] staging : comedi : fix type issues " Luis de Bethencourt
2016-05-31 10:29 ` Ian Abbott
2016-05-31 17:07   ` Joe Perches
2016-06-01  9:28     ` Ian Abbott
2016-06-18  3:53 ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2016-05-20  6:22 [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue " Ravishankar Karkala Mallikarjunayya
2016-05-20 10:14 ` Ian Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=574C4AE6.2010804@osg.samsung.com \
    --to=luisbg@osg.samsung.com \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ravishankarkm32@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.