* [U-Boot] [PATCH] malloc: Remove control-L in malloc.h
@ 2016-05-30 15:22 Marek Vasut
2016-05-30 19:18 ` Måns Rullgård
2016-05-30 20:15 ` Wolfgang Denk
0 siblings, 2 replies; 7+ messages in thread
From: Marek Vasut @ 2016-05-30 15:22 UTC (permalink / raw)
To: u-boot
Remove what must've been a typo.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Tom Rini <trini@konsulko.com>
Cc: Simon Glass <sjg@chromium.org>
---
include/malloc.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/malloc.h b/include/malloc.h
index 8175c75..e065473 100644
--- a/include/malloc.h
+++ b/include/malloc.h
@@ -215,7 +215,6 @@
*/
-\f
#ifndef __MALLOC_H__
#define __MALLOC_H__
--
2.7.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] malloc: Remove control-L in malloc.h
2016-05-30 15:22 [U-Boot] [PATCH] malloc: Remove control-L in malloc.h Marek Vasut
@ 2016-05-30 19:18 ` Måns Rullgård
2016-05-30 20:15 ` Wolfgang Denk
1 sibling, 0 replies; 7+ messages in thread
From: Måns Rullgård @ 2016-05-30 19:18 UTC (permalink / raw)
To: u-boot
Marek Vasut <marex@denx.de> writes:
> Remove what must've been a typo.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Simon Glass <sjg@chromium.org>
> ---
> include/malloc.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/malloc.h b/include/malloc.h
> index 8175c75..e065473 100644
> --- a/include/malloc.h
> +++ b/include/malloc.h
> @@ -215,7 +215,6 @@
>
> */
>
> -
> #ifndef __MALLOC_H__
> #define __MALLOC_H__
>
> --
It was probably intentional. I've seen ^L (form feed) occasionally in
old code. Perhaps the author added it to make the file paginate better
if printed on paper.
That said, I don't mind if you remove it.
--
M?ns Rullg?rd
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] malloc: Remove control-L in malloc.h
2016-05-30 15:22 [U-Boot] [PATCH] malloc: Remove control-L in malloc.h Marek Vasut
2016-05-30 19:18 ` Måns Rullgård
@ 2016-05-30 20:15 ` Wolfgang Denk
2016-05-30 20:37 ` Marek Vasut
1 sibling, 1 reply; 7+ messages in thread
From: Wolfgang Denk @ 2016-05-30 20:15 UTC (permalink / raw)
To: u-boot
Dear Marek,
In message <1464621732-7617-1-git-send-email-marex@denx.de> you wrote:
> Remove what must've been a typo.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Simon Glass <sjg@chromium.org>
> ---
> include/malloc.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/malloc.h b/include/malloc.h
> index 8175c75..e065473 100644
> --- a/include/malloc.h
> +++ b/include/malloc.h
> @@ -215,7 +215,6 @@
>
> */
>
> -
> #ifndef __MALLOC_H__
> #define __MALLOC_H__
This is most likely NOT a typo, but an intentional page break (yes,
there was a time when people used to _print_ source code on dead
wood). And I bet if comes from the original imported dlmalloc code,
so please check twice befoire introducing an unneeded difference.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Where shall I begin, please your Majesty?" he asked. "Begin at the
beginning," the King said, gravely, "and go on till you come to the
end: then stop." - Alice's Adventures in Wonderland, Lewis Carroll
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] malloc: Remove control-L in malloc.h
2016-05-30 20:15 ` Wolfgang Denk
@ 2016-05-30 20:37 ` Marek Vasut
2016-05-30 20:38 ` Marek Vasut
0 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2016-05-30 20:37 UTC (permalink / raw)
To: u-boot
On 05/30/2016 10:15 PM, Wolfgang Denk wrote:
> Dear Marek,
>
> In message <1464621732-7617-1-git-send-email-marex@denx.de> you wrote:
>> Remove what must've been a typo.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Tom Rini <trini@konsulko.com>
>> Cc: Simon Glass <sjg@chromium.org>
>> ---
>> include/malloc.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/include/malloc.h b/include/malloc.h
>> index 8175c75..e065473 100644
>> --- a/include/malloc.h
>> +++ b/include/malloc.h
>> @@ -215,7 +215,6 @@
>>
>> */
>>
>> -
>> #ifndef __MALLOC_H__
>> #define __MALLOC_H__
>
> This is most likely NOT a typo, but an intentional page break (yes,
> there was a time when people used to _print_ source code on dead
> wood). And I bet if comes from the original imported dlmalloc code,
> so please check twice befoire introducing an unneeded difference.
Urgh, ok, feel free to drop this patch, I don't really care.
> Best regards,
>
> Wolfgang Denk
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] malloc: Remove control-L in malloc.h
2016-05-30 20:37 ` Marek Vasut
@ 2016-05-30 20:38 ` Marek Vasut
2016-05-31 10:27 ` Måns Rullgård
0 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2016-05-30 20:38 UTC (permalink / raw)
To: u-boot
On 05/30/2016 10:37 PM, Marek Vasut wrote:
> On 05/30/2016 10:15 PM, Wolfgang Denk wrote:
>> Dear Marek,
>>
>> In message <1464621732-7617-1-git-send-email-marex@denx.de> you wrote:
>>> Remove what must've been a typo.
>>>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>> Cc: Tom Rini <trini@konsulko.com>
>>> Cc: Simon Glass <sjg@chromium.org>
>>> ---
>>> include/malloc.h | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/include/malloc.h b/include/malloc.h
>>> index 8175c75..e065473 100644
>>> --- a/include/malloc.h
>>> +++ b/include/malloc.h
>>> @@ -215,7 +215,6 @@
>>>
>>> */
>>>
>>> -
>>> #ifndef __MALLOC_H__
>>> #define __MALLOC_H__
>>
>> This is most likely NOT a typo, but an intentional page break (yes,
>> there was a time when people used to _print_ source code on dead
>> wood). And I bet if comes from the original imported dlmalloc code,
>> so please check twice befoire introducing an unneeded difference.
>
> Urgh, ok, feel free to drop this patch, I don't really care.
...about this patch
I didn't expect to meet control-L in any files, that's new (old).
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] malloc: Remove control-L in malloc.h
2016-05-30 20:38 ` Marek Vasut
@ 2016-05-31 10:27 ` Måns Rullgård
2016-06-02 13:31 ` Wolfgang Denk
0 siblings, 1 reply; 7+ messages in thread
From: Måns Rullgård @ 2016-05-31 10:27 UTC (permalink / raw)
To: u-boot
Marek Vasut <marex@denx.de> writes:
> On 05/30/2016 10:37 PM, Marek Vasut wrote:
>> On 05/30/2016 10:15 PM, Wolfgang Denk wrote:
>>> Dear Marek,
>>>
>>> In message <1464621732-7617-1-git-send-email-marex@denx.de> you wrote:
>>>> Remove what must've been a typo.
>>>>
>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>> Cc: Tom Rini <trini@konsulko.com>
>>>> Cc: Simon Glass <sjg@chromium.org>
>>>> ---
>>>> include/malloc.h | 1 -
>>>> 1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/include/malloc.h b/include/malloc.h
>>>> index 8175c75..e065473 100644
>>>> --- a/include/malloc.h
>>>> +++ b/include/malloc.h
>>>> @@ -215,7 +215,6 @@
>>>>
>>>> */
>>>>
>>>> -
>>>> #ifndef __MALLOC_H__
>>>> #define __MALLOC_H__
>>>
>>> This is most likely NOT a typo, but an intentional page break (yes,
>>> there was a time when people used to _print_ source code on dead
>>> wood). And I bet if comes from the original imported dlmalloc code,
>>> so please check twice befoire introducing an unneeded difference.
>>
>> Urgh, ok, feel free to drop this patch, I don't really care.
>
> ...about this patch
>
> I didn't expect to meet control-L in any files, that's new (old).
Kids these days...
--
M?ns Rullg?rd
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] malloc: Remove control-L in malloc.h
2016-05-31 10:27 ` Måns Rullgård
@ 2016-06-02 13:31 ` Wolfgang Denk
0 siblings, 0 replies; 7+ messages in thread
From: Wolfgang Denk @ 2016-06-02 13:31 UTC (permalink / raw)
To: u-boot
Dear M?ns,
In message <yw1xvb1u4j5g.fsf@unicorn.mansr.com> you wrote:
>
> > I didn't expect to meet control-L in any files, that's new (old).
>
> Kids these days...
Right, never booted from a RK05 but complaining about code formatting
:-)
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Brain: an apparatus with which we think we think. - Ambrose Bierce
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-06-02 13:31 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-30 15:22 [U-Boot] [PATCH] malloc: Remove control-L in malloc.h Marek Vasut
2016-05-30 19:18 ` Måns Rullgård
2016-05-30 20:15 ` Wolfgang Denk
2016-05-30 20:37 ` Marek Vasut
2016-05-30 20:38 ` Marek Vasut
2016-05-31 10:27 ` Måns Rullgård
2016-06-02 13:31 ` Wolfgang Denk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.