From: Jyri Sarha <jsarha@ti.com>
To: Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Arnaud Pouliquen <arnaud.pouliquen@st.com>,
Liam Girdwood <lgirdwood@gmail.com>,
PC Liao <pc.liao@mediatek.com>
Subject: Re: [PATCH] ASoC: hdmi-codec: select CONFIG_HDMI
Date: Wed, 1 Jun 2016 09:32:42 +0300 [thread overview]
Message-ID: <574E818A.4000708@ti.com> (raw)
In-Reply-To: <1464729159-587126-1-git-send-email-arnd@arndb.de>
On 06/01/16 00:12, Arnd Bergmann wrote:
> SND_SOC_HDMI_CODEC can be enabled without HDMI support, leading
> to a link error:
>
> In function `hdmi_codec_hw_params':
> sound/soc/codecs/hdmi-codec.c:188: undefined reference to `hdmi_audio_infoframe_init'
> sound/built-in.o:(.debug_addr+0x1a5c0): undefined reference to `hdmi_audio_infoframe_init'
>
> This changes the Kconfig file to select HDMI, as the other codec using
> hdmi_audio_infoframe_init already does.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 09184118a8ab ("ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders")
Oops. I wonder how I missed that. Something in omap2plus_defconfig must
trigger the selecting of HDMI.
Acked-by: Jyri Sarha <jsarha@ti.com>
> ---
> sound/soc/codecs/Kconfig | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 4d82a58ff6b0..f3fb98f0a995 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -483,9 +483,10 @@ config SND_SOC_DMIC
> tristate
>
> config SND_SOC_HDMI_CODEC
> - tristate
> - select SND_PCM_ELD
> - select SND_PCM_IEC958
> + tristate
> + select SND_PCM_ELD
> + select SND_PCM_IEC958
> + select HDMI
>
> config SND_SOC_ES8328
> tristate "Everest Semi ES8328 CODEC"
>
WARNING: multiple messages have this Message-ID (diff)
From: Jyri Sarha <jsarha@ti.com>
To: Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>
Cc: Arnaud Pouliquen <arnaud.pouliquen@st.com>,
PC Liao <pc.liao@mediatek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: hdmi-codec: select CONFIG_HDMI
Date: Wed, 1 Jun 2016 09:32:42 +0300 [thread overview]
Message-ID: <574E818A.4000708@ti.com> (raw)
In-Reply-To: <1464729159-587126-1-git-send-email-arnd@arndb.de>
On 06/01/16 00:12, Arnd Bergmann wrote:
> SND_SOC_HDMI_CODEC can be enabled without HDMI support, leading
> to a link error:
>
> In function `hdmi_codec_hw_params':
> sound/soc/codecs/hdmi-codec.c:188: undefined reference to `hdmi_audio_infoframe_init'
> sound/built-in.o:(.debug_addr+0x1a5c0): undefined reference to `hdmi_audio_infoframe_init'
>
> This changes the Kconfig file to select HDMI, as the other codec using
> hdmi_audio_infoframe_init already does.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 09184118a8ab ("ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders")
Oops. I wonder how I missed that. Something in omap2plus_defconfig must
trigger the selecting of HDMI.
Acked-by: Jyri Sarha <jsarha@ti.com>
> ---
> sound/soc/codecs/Kconfig | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 4d82a58ff6b0..f3fb98f0a995 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -483,9 +483,10 @@ config SND_SOC_DMIC
> tristate
>
> config SND_SOC_HDMI_CODEC
> - tristate
> - select SND_PCM_ELD
> - select SND_PCM_IEC958
> + tristate
> + select SND_PCM_ELD
> + select SND_PCM_IEC958
> + select HDMI
>
> config SND_SOC_ES8328
> tristate "Everest Semi ES8328 CODEC"
>
next prev parent reply other threads:[~2016-06-01 6:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 21:12 [PATCH] ASoC: hdmi-codec: select CONFIG_HDMI Arnd Bergmann
2016-06-01 6:32 ` Jyri Sarha [this message]
2016-06-01 6:32 ` Jyri Sarha
2016-06-02 15:50 ` Applied "ASoC: hdmi-codec: select CONFIG_HDMI" to the asoc tree Mark Brown
2016-06-02 15:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574E818A.4000708@ti.com \
--to=jsarha@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.pouliquen@st.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pc.liao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.