From: Michael Tokarev <mjt@tls.msk.ru>
To: Alberto Garcia <berto@igalia.com>,
Changlong Xie <xiecl.fnst@cn.fujitsu.com>,
Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] docs: Fix a couple of typos in throttle.txt
Date: Wed, 1 Jun 2016 11:01:19 +0300 [thread overview]
Message-ID: <574E964F.90000@msgid.tls.msk.ru> (raw)
In-Reply-To: <w51k2ib50ih.fsf@maestria.local.igalia.com>
30.05.2016 13:00, Alberto Garcia wrote:
> On Mon 30 May 2016 08:49:18 AM CEST, Changlong Xie wrote:
>>>> - Water leaks from the bucket at a rate of 100 IOPS.
>>>> - Water can be added to the bucket at a rate of 2000 IOPS.
>>>> - The size of the bucket is 2000 x 60 = 120000
>>>> - - If 'iops-total-max-length' is unset then the bucket size is 100.
>>>> + - If 'iops-total-max' is unset then the bucket size is 100.
>>
>> Sorry to brother, why the bucket size is 100 rather than 100 x 60?
>
> Oh, that's because 'iops-total-max-length' can only be set if
> 'iops-total-max' is set as well. It's explained earlier in the document,
> maybe I should make it clear there as well.
>
> Michael, shall I send a new patch on top of my previous one or can the
> previous one be replaced?
I fixed it in the original commit, thanks!
/mjt
WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Alberto Garcia <berto@igalia.com>,
Changlong Xie <xiecl.fnst@cn.fujitsu.com>,
Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] docs: Fix a couple of typos in throttle.txt
Date: Wed, 1 Jun 2016 11:01:19 +0300 [thread overview]
Message-ID: <574E964F.90000@msgid.tls.msk.ru> (raw)
In-Reply-To: <w51k2ib50ih.fsf@maestria.local.igalia.com>
30.05.2016 13:00, Alberto Garcia wrote:
> On Mon 30 May 2016 08:49:18 AM CEST, Changlong Xie wrote:
>>>> - Water leaks from the bucket at a rate of 100 IOPS.
>>>> - Water can be added to the bucket at a rate of 2000 IOPS.
>>>> - The size of the bucket is 2000 x 60 = 120000
>>>> - - If 'iops-total-max-length' is unset then the bucket size is 100.
>>>> + - If 'iops-total-max' is unset then the bucket size is 100.
>>
>> Sorry to brother, why the bucket size is 100 rather than 100 x 60?
>
> Oh, that's because 'iops-total-max-length' can only be set if
> 'iops-total-max' is set as well. It's explained earlier in the document,
> maybe I should make it clear there as well.
>
> Michael, shall I send a new patch on top of my previous one or can the
> previous one be replaced?
I fixed it in the original commit, thanks!
/mjt
next prev parent reply other threads:[~2016-06-01 8:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 11:59 [Qemu-trivial] [PATCH] docs: Fix a couple of typos in throttle.txt Alberto Garcia
2016-05-24 11:59 ` [Qemu-devel] " Alberto Garcia
2016-05-24 23:11 ` [Qemu-trivial] " Eric Blake
2016-05-24 23:11 ` Eric Blake
2016-05-30 6:49 ` [Qemu-trivial] " Changlong Xie
2016-05-30 6:49 ` Changlong Xie
2016-05-30 10:00 ` [Qemu-trivial] " Alberto Garcia
2016-05-30 10:00 ` Alberto Garcia
2016-05-30 10:19 ` [Qemu-trivial] " Changlong Xie
2016-05-30 10:19 ` Changlong Xie
2016-06-01 8:01 ` Michael Tokarev [this message]
2016-06-01 8:01 ` Michael Tokarev
2016-05-29 8:39 ` [Qemu-trivial] " Michael Tokarev
2016-05-29 8:39 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574E964F.90000@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=berto@igalia.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=xiecl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.