All of lore.kernel.org
 help / color / mirror / Atom feed
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm: atmel-hlcdc: actually disable scaling when no scaling is required
Date: Thu, 2 Jun 2016 11:44:10 +0200	[thread overview]
Message-ID: <574FFFEA.5060309@atmel.com> (raw)
In-Reply-To: <1464781370-19277-1-git-send-email-boris.brezillon@free-electrons.com>

Le 01/06/2016 13:42, Boris Brezillon a ?crit :
> The driver is only enabling scaling, but never disabling it, thus, if you
> enable the scaling feature once it stays enabled forever.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Reported-by: Alex Vazquez <avazquez.dev@gmail.com>
> Fixes: 1a396789f65a ("drm: add Atmel HLCDC Display Controller support")
> Cc: <stable@vger.kernel.org>

Reviewed-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Thanks!

> ---
>  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> index aef3ca8..016c191 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> @@ -339,6 +339,8 @@ atmel_hlcdc_plane_update_pos_and_size(struct atmel_hlcdc_plane *plane,
>  
>  		atmel_hlcdc_layer_update_cfg(&plane->layer, 13, 0xffffffff,
>  					     factor_reg);
> +	} else {
> +		atmel_hlcdc_layer_update_cfg(&plane->layer, 13, 0xffffffff, 0);
>  	}
>  }
>  
> 


-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH] drm: atmel-hlcdc: actually disable scaling when no scaling is required
Date: Thu, 2 Jun 2016 11:44:10 +0200	[thread overview]
Message-ID: <574FFFEA.5060309@atmel.com> (raw)
In-Reply-To: <1464781370-19277-1-git-send-email-boris.brezillon@free-electrons.com>

Le 01/06/2016 13:42, Boris Brezillon a écrit :
> The driver is only enabling scaling, but never disabling it, thus, if you
> enable the scaling feature once it stays enabled forever.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Reported-by: Alex Vazquez <avazquez.dev@gmail.com>
> Fixes: 1a396789f65a ("drm: add Atmel HLCDC Display Controller support")
> Cc: <stable@vger.kernel.org>

Reviewed-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Thanks!

> ---
>  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> index aef3ca8..016c191 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> @@ -339,6 +339,8 @@ atmel_hlcdc_plane_update_pos_and_size(struct atmel_hlcdc_plane *plane,
>  
>  		atmel_hlcdc_layer_update_cfg(&plane->layer, 13, 0xffffffff,
>  					     factor_reg);
> +	} else {
> +		atmel_hlcdc_layer_update_cfg(&plane->layer, 13, 0xffffffff, 0);
>  	}
>  }
>  
> 


-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
	"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	<dri-devel@lists.freedesktop.org>
Cc: <linux-arm-kernel@lists.infradead.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH] drm: atmel-hlcdc: actually disable scaling when no scaling is required
Date: Thu, 2 Jun 2016 11:44:10 +0200	[thread overview]
Message-ID: <574FFFEA.5060309@atmel.com> (raw)
In-Reply-To: <1464781370-19277-1-git-send-email-boris.brezillon@free-electrons.com>

Le 01/06/2016 13:42, Boris Brezillon a �crit :
> The driver is only enabling scaling, but never disabling it, thus, if you
> enable the scaling feature once it stays enabled forever.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Reported-by: Alex Vazquez <avazquez.dev@gmail.com>
> Fixes: 1a396789f65a ("drm: add Atmel HLCDC Display Controller support")
> Cc: <stable@vger.kernel.org>

Reviewed-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Thanks!

> ---
>  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> index aef3ca8..016c191 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> @@ -339,6 +339,8 @@ atmel_hlcdc_plane_update_pos_and_size(struct atmel_hlcdc_plane *plane,
>  
>  		atmel_hlcdc_layer_update_cfg(&plane->layer, 13, 0xffffffff,
>  					     factor_reg);
> +	} else {
> +		atmel_hlcdc_layer_update_cfg(&plane->layer, 13, 0xffffffff, 0);
>  	}
>  }
>  
> 


-- 
Nicolas Ferre

  reply	other threads:[~2016-06-02  9:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-01 11:42 [PATCH] drm: atmel-hlcdc: actually disable scaling when no scaling is required Boris Brezillon
2016-06-01 11:42 ` Boris Brezillon
2016-06-01 11:42 ` Boris Brezillon
2016-06-02  9:44 ` Nicolas Ferre [this message]
2016-06-02  9:44   ` Nicolas Ferre
2016-06-02  9:44   ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=574FFFEA.5060309@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.