From: Sudeep Holla <sudeep.holla@arm.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Sudeep Holla <sudeep.holla@arm.com>,
rtc-linux@googlegroups.com, stable@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: [rtc-linux] Re: [PATCH] rtc: ab8500: move device_init_wakeup() call
Date: Fri, 3 Jun 2016 10:04:38 +0100 [thread overview]
Message-ID: <57514826.8030801@arm.com> (raw)
In-Reply-To: <1464875584-31505-1-git-send-email-linus.walleij@linaro.org>
On 02/06/16 14:53, Linus Walleij wrote:
> commit 93a6f9168f2f ("rtc: ab8500: remove misuse of IRQF_NO_SUSPEND flag")
> introduced the dev_pm_set_wake_irq() call to register a wake
> IRQ for the AB8500 driver.
>
> However this causes a regression since device_init_wakeup() must be
> called *after* dev_pm_set_wake_irq() not *before* it. Before this
> patch we get an error message like this during system resume from
> sleep:
>
I am unable to understand this. Because it's the exact same sequence in
rtc-pl031.c which works fine for me on ARM64 Juno platform. So I am
struggle to understand the linkage of the backtrace to this calling
sequence as I can't see any dependency. Let me know if you have already
figured out where exactly does it go wrong.
Prior to commit 93a6f9168f2f, set_irq_wake was never tested and hence
one possible reason I can think of is set_irq_wake_real may be failing
on suspend but the error value is ignored.
--
Regards,
Sudeep
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Sudeep Holla <sudeep.holla@arm.com>,
rtc-linux@googlegroups.com, stable@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH] rtc: ab8500: move device_init_wakeup() call
Date: Fri, 3 Jun 2016 10:04:38 +0100 [thread overview]
Message-ID: <57514826.8030801@arm.com> (raw)
In-Reply-To: <1464875584-31505-1-git-send-email-linus.walleij@linaro.org>
On 02/06/16 14:53, Linus Walleij wrote:
> commit 93a6f9168f2f ("rtc: ab8500: remove misuse of IRQF_NO_SUSPEND flag")
> introduced the dev_pm_set_wake_irq() call to register a wake
> IRQ for the AB8500 driver.
>
> However this causes a regression since device_init_wakeup() must be
> called *after* dev_pm_set_wake_irq() not *before* it. Before this
> patch we get an error message like this during system resume from
> sleep:
>
I am unable to understand this. Because it's the exact same sequence in
rtc-pl031.c which works fine for me on ARM64 Juno platform. So I am
struggle to understand the linkage of the backtrace to this calling
sequence as I can't see any dependency. Let me know if you have already
figured out where exactly does it go wrong.
Prior to commit 93a6f9168f2f, set_irq_wake was never tested and hence
one possible reason I can think of is set_irq_wake_real may be failing
on suspend but the error value is ignored.
--
Regards,
Sudeep
next prev parent reply other threads:[~2016-06-03 9:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 13:53 [rtc-linux] [PATCH] rtc: ab8500: move device_init_wakeup() call Linus Walleij
2016-06-02 13:53 ` Linus Walleij
2016-06-02 13:56 ` [rtc-linux] " Linus Walleij
2016-06-02 13:56 ` Linus Walleij
2016-06-03 9:04 ` Sudeep Holla [this message]
2016-06-03 9:04 ` Sudeep Holla
2016-06-03 9:40 ` [rtc-linux] " Ulf Hansson
2016-06-03 9:40 ` Ulf Hansson
-- strict thread matches above, loose matches on Subject: below --
2016-04-11 7:54 [rtc-linux] " Linus Walleij
2016-04-11 8:56 ` [rtc-linux] " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57514826.8030801@arm.com \
--to=sudeep.holla@arm.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=linus.walleij@linaro.org \
--cc=rtc-linux@googlegroups.com \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.