From: Ben Greear <greearb@candelatech.com>
To: "Valo, Kalle" <kvalo@qca.qualcomm.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Manoharan, Rajkumar" <rmanohar@qti.qualcomm.com>,
Rajkumar Manoharan <rmanohar@codeaurora.org>
Subject: Re: [PATCH 2/2] ath10k: remove 10.1 firmware support
Date: Fri, 3 Jun 2016 09:46:56 -0700 [thread overview]
Message-ID: <5751B480.2060106@candelatech.com> (raw)
In-Reply-To: <87oa7iut9x.fsf@kamboji.qca.qualcomm.com>
On 06/03/2016 09:33 AM, Valo, Kalle wrote:
> Ben Greear <greearb@candelatech.com> writes:
>
>>>> Is it possible to upgrade CT firmware to 10.2 WMI/HTT interfaces?
>>>
>>> That's a good idea. That shouldn't be too hard, right? I don't think HTT needs
>>> any changes, but for WMI few commands and ids need to be changed.
>>
>> I was thinking the 10.2 mgt-over-htt API would be trouble-some to make work on
>> 10.1 firmware.
>
> Yeah, that would be harder. But I don't see Rajkumar removing support
> for that (yet) or am I missing something?
What I mean is that to just make my 10.1 firmware act like 10.2 would require
my 10.1 to suddenly support 10.2's mgt-over-htt. I think that will be difficult,
and there is plenty of risk that some subtle WMI change would cause hard-to-detect
bugs.
I have done an initial port of my 10.1 changes to 10.2, it is just that the
result is poor, and so I quit messing with 10.2 and re-focussed on 10.1
for the time being.
Another way to help with this problem in general is to quit adding so many
new firmware API. It is a lot easier to make a new firmware backwards compat
than it is to make an old firmware forwards compat. When you are designing your
WMI changes in new firmware, do it with care, and then you can reuse the vast bulk
of your driver. I managed to add quite a few new features to my 10.1 in this
manner, and the driver patches (mostly keyed off of feature flags) are not that
invasive.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: "Valo, Kalle" <kvalo@qca.qualcomm.com>
Cc: Rajkumar Manoharan <rmanohar@codeaurora.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Manoharan, Rajkumar" <rmanohar@qti.qualcomm.com>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH 2/2] ath10k: remove 10.1 firmware support
Date: Fri, 3 Jun 2016 09:46:56 -0700 [thread overview]
Message-ID: <5751B480.2060106@candelatech.com> (raw)
In-Reply-To: <87oa7iut9x.fsf@kamboji.qca.qualcomm.com>
On 06/03/2016 09:33 AM, Valo, Kalle wrote:
> Ben Greear <greearb@candelatech.com> writes:
>
>>>> Is it possible to upgrade CT firmware to 10.2 WMI/HTT interfaces?
>>>
>>> That's a good idea. That shouldn't be too hard, right? I don't think HTT needs
>>> any changes, but for WMI few commands and ids need to be changed.
>>
>> I was thinking the 10.2 mgt-over-htt API would be trouble-some to make work on
>> 10.1 firmware.
>
> Yeah, that would be harder. But I don't see Rajkumar removing support
> for that (yet) or am I missing something?
What I mean is that to just make my 10.1 firmware act like 10.2 would require
my 10.1 to suddenly support 10.2's mgt-over-htt. I think that will be difficult,
and there is plenty of risk that some subtle WMI change would cause hard-to-detect
bugs.
I have done an initial port of my 10.1 changes to 10.2, it is just that the
result is poor, and so I quit messing with 10.2 and re-focussed on 10.1
for the time being.
Another way to help with this problem in general is to quit adding so many
new firmware API. It is a lot easier to make a new firmware backwards compat
than it is to make an old firmware forwards compat. When you are designing your
WMI changes in new firmware, do it with care, and then you can reuse the vast bulk
of your driver. I managed to add quite a few new features to my 10.1 in this
manner, and the driver patches (mostly keyed off of feature flags) are not that
invasive.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2016-06-03 17:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 15:33 [PATCH 1/2] ath10k: handle testmode events for 10.2 based firmware Rajkumar Manoharan
2016-06-03 15:33 ` Rajkumar Manoharan
2016-06-03 15:33 ` [PATCH 2/2] ath10k: remove 10.1 firmware support Rajkumar Manoharan
2016-06-03 15:33 ` Rajkumar Manoharan
2016-06-03 15:48 ` Ben Greear
2016-06-03 15:48 ` Ben Greear
2016-06-03 15:55 ` Rajkumar Manoharan
2016-06-03 15:55 ` Rajkumar Manoharan
2016-06-03 16:07 ` Ben Greear
2016-06-03 16:07 ` Ben Greear
2016-06-03 16:28 ` Rajkumar Manoharan
2016-06-03 16:28 ` Rajkumar Manoharan
2016-06-03 16:36 ` Ben Greear
2016-06-03 16:36 ` Ben Greear
2016-06-03 16:09 ` Valo, Kalle
2016-06-03 16:09 ` Valo, Kalle
2016-06-03 16:20 ` Ben Greear
2016-06-03 16:20 ` Ben Greear
2016-06-03 16:33 ` Valo, Kalle
2016-06-03 16:33 ` Valo, Kalle
2016-06-03 16:46 ` Ben Greear [this message]
2016-06-03 16:46 ` Ben Greear
2016-09-14 12:24 ` [1/2] ath10k: handle testmode events for 10.2 based firmware Kalle Valo
2016-09-14 12:24 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5751B480.2060106@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@codeaurora.org \
--cc=rmanohar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.