From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
linux-kernel@vger.kernel.org, mugunthanvnm@ti.com
Cc: linux-omap@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: ti: cpsw: fix rx-usecs interrupt pacing consistency
Date: Fri, 3 Jun 2016 19:47:05 +0300 [thread overview]
Message-ID: <5751B489.9070809@ti.com> (raw)
In-Reply-To: <575034D8.4040500@linaro.org>
On 06/02/2016 04:30 PM, Ivan Khoronzhuk wrote:
> On 02.06.16 16:14, Ivan Khoronzhuk wrote:
>> The rx-usecs shouldn't be changed while interface down/up.
>> Currently, for instance, if it's set to 100us, after interface
>> down/up it's 500us. It's a hidden bug that can lead to lavish
>> interrupt pacing time increasing while "down/up" up to max value.
>>
>> Steps to reproduce:
>> - set rx-usecs to be 100us
>> - down/up interface
>> - read new unexpected rx-usecs
>>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
>> ---
>>
>> Based on ti-linux-4.4.y
> Please ignore this line, it's added by mistake.
> The patch is based on master.
>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
>
>>
>> drivers/net/ethernet/ti/cpsw.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/ti/cpsw.c
>> b/drivers/net/ethernet/ti/cpsw.c
>> index 7b44587..9919cb3 100644
>> --- a/drivers/net/ethernet/ti/cpsw.c
>> +++ b/drivers/net/ethernet/ti/cpsw.c
>> @@ -1352,7 +1352,7 @@ static int cpsw_ndo_open(struct net_device *ndev)
>> if (priv->coal_intvl != 0) {
>> struct ethtool_coalesce coal;
>>
>> - coal.rx_coalesce_usecs = (priv->coal_intvl << 4);
>> + coal.rx_coalesce_usecs = priv->coal_intvl;
>> cpsw_set_coalesce(ndev, &coal);
>> }
>>
>>
>
--
regards,
-grygorii
WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
<linux-kernel@vger.kernel.org>, <mugunthanvnm@ti.com>
Cc: <linux-omap@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: ethernet: ti: cpsw: fix rx-usecs interrupt pacing consistency
Date: Fri, 3 Jun 2016 19:47:05 +0300 [thread overview]
Message-ID: <5751B489.9070809@ti.com> (raw)
In-Reply-To: <575034D8.4040500@linaro.org>
On 06/02/2016 04:30 PM, Ivan Khoronzhuk wrote:
> On 02.06.16 16:14, Ivan Khoronzhuk wrote:
>> The rx-usecs shouldn't be changed while interface down/up.
>> Currently, for instance, if it's set to 100us, after interface
>> down/up it's 500us. It's a hidden bug that can lead to lavish
>> interrupt pacing time increasing while "down/up" up to max value.
>>
>> Steps to reproduce:
>> - set rx-usecs to be 100us
>> - down/up interface
>> - read new unexpected rx-usecs
>>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
>> ---
>>
>> Based on ti-linux-4.4.y
> Please ignore this line, it's added by mistake.
> The patch is based on master.
>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
>
>>
>> drivers/net/ethernet/ti/cpsw.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/ti/cpsw.c
>> b/drivers/net/ethernet/ti/cpsw.c
>> index 7b44587..9919cb3 100644
>> --- a/drivers/net/ethernet/ti/cpsw.c
>> +++ b/drivers/net/ethernet/ti/cpsw.c
>> @@ -1352,7 +1352,7 @@ static int cpsw_ndo_open(struct net_device *ndev)
>> if (priv->coal_intvl != 0) {
>> struct ethtool_coalesce coal;
>>
>> - coal.rx_coalesce_usecs = (priv->coal_intvl << 4);
>> + coal.rx_coalesce_usecs = priv->coal_intvl;
>> cpsw_set_coalesce(ndev, &coal);
>> }
>>
>>
>
--
regards,
-grygorii
next prev parent reply other threads:[~2016-06-03 16:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 13:14 [PATCH] net: ethernet: ti: cpsw: fix rx-usecs interrupt pacing consistency Ivan Khoronzhuk
2016-06-02 13:30 ` Ivan Khoronzhuk
2016-06-03 16:47 ` Grygorii Strashko [this message]
2016-06-03 16:47 ` Grygorii Strashko
2016-06-03 23:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5751B489.9070809@ti.com \
--to=grygorii.strashko@ti.com \
--cc=ivan.khoronzhuk@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.