From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
mugunthanvnm@ti.com, linux-kernel@vger.kernel.org
Cc: linux-omap@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: ti: cpsw: remove unused priv lock
Date: Fri, 3 Jun 2016 19:47:55 +0300 [thread overview]
Message-ID: <5751B4BB.5060005@ti.com> (raw)
In-Reply-To: <1464907028-19622-1-git-send-email-ivan.khoronzhuk@linaro.org>
On 06/03/2016 01:37 AM, Ivan Khoronzhuk wrote:
> There is no reason in this lock. At least for now.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> ---
>
> Based on master
>
> drivers/net/ethernet/ti/cpsw.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index 9919cb3..8d1d373 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -365,7 +365,6 @@ static inline void slave_write(struct cpsw_slave *slave, u32 val, u32 offset)
> }
>
> struct cpsw_priv {
> - spinlock_t lock;
> struct platform_device *pdev;
> struct net_device *ndev;
> struct napi_struct napi_rx;
> @@ -2413,7 +2412,6 @@ static int cpsw_probe_dual_emac(struct platform_device *pdev,
> }
>
> priv_sl2 = netdev_priv(ndev);
> - spin_lock_init(&priv_sl2->lock);
> priv_sl2->data = *data;
> priv_sl2->pdev = pdev;
> priv_sl2->ndev = ndev;
> @@ -2533,7 +2531,6 @@ static int cpsw_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, ndev);
> priv = netdev_priv(ndev);
> - spin_lock_init(&priv->lock);
> priv->pdev = pdev;
> priv->ndev = ndev;
> priv->dev = &ndev->dev;
>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
regards,
-grygorii
WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
<mugunthanvnm@ti.com>, <linux-kernel@vger.kernel.org>
Cc: <linux-omap@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: ethernet: ti: cpsw: remove unused priv lock
Date: Fri, 3 Jun 2016 19:47:55 +0300 [thread overview]
Message-ID: <5751B4BB.5060005@ti.com> (raw)
In-Reply-To: <1464907028-19622-1-git-send-email-ivan.khoronzhuk@linaro.org>
On 06/03/2016 01:37 AM, Ivan Khoronzhuk wrote:
> There is no reason in this lock. At least for now.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> ---
>
> Based on master
>
> drivers/net/ethernet/ti/cpsw.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index 9919cb3..8d1d373 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -365,7 +365,6 @@ static inline void slave_write(struct cpsw_slave *slave, u32 val, u32 offset)
> }
>
> struct cpsw_priv {
> - spinlock_t lock;
> struct platform_device *pdev;
> struct net_device *ndev;
> struct napi_struct napi_rx;
> @@ -2413,7 +2412,6 @@ static int cpsw_probe_dual_emac(struct platform_device *pdev,
> }
>
> priv_sl2 = netdev_priv(ndev);
> - spin_lock_init(&priv_sl2->lock);
> priv_sl2->data = *data;
> priv_sl2->pdev = pdev;
> priv_sl2->ndev = ndev;
> @@ -2533,7 +2531,6 @@ static int cpsw_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, ndev);
> priv = netdev_priv(ndev);
> - spin_lock_init(&priv->lock);
> priv->pdev = pdev;
> priv->ndev = ndev;
> priv->dev = &ndev->dev;
>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
regards,
-grygorii
next prev parent reply other threads:[~2016-06-03 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 22:37 [PATCH] net: ethernet: ti: cpsw: remove unused priv lock Ivan Khoronzhuk
2016-06-03 16:47 ` Grygorii Strashko [this message]
2016-06-03 16:47 ` Grygorii Strashko
2016-06-03 23:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5751B4BB.5060005@ti.com \
--to=grygorii.strashko@ti.com \
--cc=ivan.khoronzhuk@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.