From: daniel@iogearbox.net (Daniel Borkmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next 1/3] arm64: bpf: implement bpf_tail_call() helper
Date: Sun, 05 Jun 2016 09:53:05 +0200 [thread overview]
Message-ID: <5753DA61.3000505@iogearbox.net> (raw)
In-Reply-To: <201606050700.BLJUHUk2%fengguang.wu@intel.com>
On 06/05/2016 01:46 AM, kbuild test robot wrote:
> Hi,
>
> [auto build test ERROR on net-next/master]
>
> url: https://github.com/0day-ci/linux/commits/Zi-Shen-Lim/arm64-bpf-implement-bpf_tail_call-helper/20160605-060435
> config: arm64-defconfig (attached as .config)
> compiler: aarch64-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
> reproduce:
> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> make.cross ARCH=arm64
>
> All errors (new ones prefixed by >>):
>
> In file included from arch/arm64/net/bpf_jit_comp.c:21:0:
> include/linux/bpf.h: In function 'bpf_prog_get':
>>> include/linux/bpf.h:235:9: error: implicit declaration of function 'ERR_PTR' [-Werror=implicit-function-declaration]
> return ERR_PTR(-EOPNOTSUPP);
> ^
> include/linux/bpf.h:235:9: warning: return makes pointer from integer without a cast [-Wint-conversion]
> In file included from include/linux/rwsem.h:17:0,
> from include/linux/mm_types.h:10,
> from include/linux/sched.h:27,
> from arch/arm64/include/asm/compat.h:25,
> from arch/arm64/include/asm/stat.h:23,
> from include/linux/stat.h:5,
> from include/linux/compat.h:12,
> from include/linux/filter.h:10,
> from arch/arm64/net/bpf_jit_comp.c:22:
> include/linux/err.h: At top level:
>>> include/linux/err.h:23:35: error: conflicting types for 'ERR_PTR'
> static inline void * __must_check ERR_PTR(long error)
> ^
> In file included from arch/arm64/net/bpf_jit_comp.c:21:0:
> include/linux/bpf.h:235:9: note: previous implicit declaration of 'ERR_PTR' was here
> return ERR_PTR(-EOPNOTSUPP);
> ^
> cc1: some warnings being treated as errors
Looks like including linux/bpf.h at the very beginning causes issues when bpf
syscall is disabled. We should probably just include linux/err.h from bpf.h.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Borkmann <daniel@iogearbox.net>
To: kbuild test robot <lkp@intel.com>, Zi Shen Lim <zlim.lnx@gmail.com>
Cc: kbuild-all@01.org, "David S. Miller" <davem@davemloft.net>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>, Yang Shi <yang.shi@linaro.org>,
Alexei Starovoitov <ast@kernel.org>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] arm64: bpf: implement bpf_tail_call() helper
Date: Sun, 05 Jun 2016 09:53:05 +0200 [thread overview]
Message-ID: <5753DA61.3000505@iogearbox.net> (raw)
In-Reply-To: <201606050700.BLJUHUk2%fengguang.wu@intel.com>
On 06/05/2016 01:46 AM, kbuild test robot wrote:
> Hi,
>
> [auto build test ERROR on net-next/master]
>
> url: https://github.com/0day-ci/linux/commits/Zi-Shen-Lim/arm64-bpf-implement-bpf_tail_call-helper/20160605-060435
> config: arm64-defconfig (attached as .config)
> compiler: aarch64-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
> reproduce:
> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> make.cross ARCH=arm64
>
> All errors (new ones prefixed by >>):
>
> In file included from arch/arm64/net/bpf_jit_comp.c:21:0:
> include/linux/bpf.h: In function 'bpf_prog_get':
>>> include/linux/bpf.h:235:9: error: implicit declaration of function 'ERR_PTR' [-Werror=implicit-function-declaration]
> return ERR_PTR(-EOPNOTSUPP);
> ^
> include/linux/bpf.h:235:9: warning: return makes pointer from integer without a cast [-Wint-conversion]
> In file included from include/linux/rwsem.h:17:0,
> from include/linux/mm_types.h:10,
> from include/linux/sched.h:27,
> from arch/arm64/include/asm/compat.h:25,
> from arch/arm64/include/asm/stat.h:23,
> from include/linux/stat.h:5,
> from include/linux/compat.h:12,
> from include/linux/filter.h:10,
> from arch/arm64/net/bpf_jit_comp.c:22:
> include/linux/err.h: At top level:
>>> include/linux/err.h:23:35: error: conflicting types for 'ERR_PTR'
> static inline void * __must_check ERR_PTR(long error)
> ^
> In file included from arch/arm64/net/bpf_jit_comp.c:21:0:
> include/linux/bpf.h:235:9: note: previous implicit declaration of 'ERR_PTR' was here
> return ERR_PTR(-EOPNOTSUPP);
> ^
> cc1: some warnings being treated as errors
Looks like including linux/bpf.h at the very beginning causes issues when bpf
syscall is disabled. We should probably just include linux/err.h from bpf.h.
next prev parent reply other threads:[~2016-06-05 7:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-04 22:00 [PATCH net-next 1/3] arm64: bpf: implement bpf_tail_call() helper Zi Shen Lim
2016-06-04 22:00 ` Zi Shen Lim
2016-06-04 22:00 ` [PATCH net-next 2/3] arm64: bpf: optimize JMP_CALL Zi Shen Lim
2016-06-04 22:00 ` Zi Shen Lim
2016-06-06 17:05 ` Will Deacon
2016-06-06 17:05 ` Will Deacon
2016-06-07 4:36 ` Z Lim
2016-06-07 4:36 ` Z Lim
2016-06-07 8:10 ` Will Deacon
2016-06-07 8:10 ` Will Deacon
2016-06-04 22:00 ` [PATCH net-next 3/3] arm64: bpf: optimize LD_ABS, LD_IND Zi Shen Lim
2016-06-04 22:00 ` Zi Shen Lim
2016-06-04 23:46 ` [PATCH net-next 1/3] arm64: bpf: implement bpf_tail_call() helper kbuild test robot
2016-06-04 23:46 ` kbuild test robot
2016-06-05 7:53 ` Daniel Borkmann [this message]
2016-06-05 7:53 ` Daniel Borkmann
2016-06-06 4:56 ` Z Lim
2016-06-06 4:56 ` Z Lim
2016-06-06 8:11 ` Daniel Borkmann
2016-06-06 8:11 ` Daniel Borkmann
2016-06-07 2:33 ` Zi Shen Lim
2016-06-07 2:33 ` Zi Shen Lim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5753DA61.3000505@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.