From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/7] mdio: mux: Enhanced MDIO mux framework for integrated multiplexers
Date: Mon, 6 Jun 2016 11:33:50 -0700 [thread overview]
Message-ID: <5755C20E.5040308@gmail.com> (raw)
In-Reply-To: <1465216900-11755-2-git-send-email-pramod.kumar@broadcom.com>
On 06/06/2016 05:41 AM, Pramod Kumar wrote:
> An integrated multiplexer uses same address space for
> "muxed bus selection" and "generation of mdio transaction"
> hence its good to register parent bus from mux driver.
>
> Hence added a mechanism where mux driver could register a
> parent bus and pass it down to framework via mdio_mux_init api.
>
> Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> diff --git a/include/linux/mdio-mux.h b/include/linux/mdio-mux.h
> index a243dbb..61f5b21 100644
> --- a/include/linux/mdio-mux.h
> +++ b/include/linux/mdio-mux.h
> @@ -10,11 +10,13 @@
> #ifndef __LINUX_MDIO_MUX_H
> #define __LINUX_MDIO_MUX_H
> #include <linux/device.h>
> +#include <linux/phy.h>
You could have added just a forward declaration, this is a pointer to
the structure so you don't need the compiler to have full knowledge of
the storage type. Not a biggie.
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Pramod Kumar <pramod.kumar@broadcom.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
"David S. Miller" <davem@davemloft.net>
Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/7] mdio: mux: Enhanced MDIO mux framework for integrated multiplexers
Date: Mon, 6 Jun 2016 11:33:50 -0700 [thread overview]
Message-ID: <5755C20E.5040308@gmail.com> (raw)
In-Reply-To: <1465216900-11755-2-git-send-email-pramod.kumar@broadcom.com>
On 06/06/2016 05:41 AM, Pramod Kumar wrote:
> An integrated multiplexer uses same address space for
> "muxed bus selection" and "generation of mdio transaction"
> hence its good to register parent bus from mux driver.
>
> Hence added a mechanism where mux driver could register a
> parent bus and pass it down to framework via mdio_mux_init api.
>
> Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> diff --git a/include/linux/mdio-mux.h b/include/linux/mdio-mux.h
> index a243dbb..61f5b21 100644
> --- a/include/linux/mdio-mux.h
> +++ b/include/linux/mdio-mux.h
> @@ -10,11 +10,13 @@
> #ifndef __LINUX_MDIO_MUX_H
> #define __LINUX_MDIO_MUX_H
> #include <linux/device.h>
> +#include <linux/phy.h>
You could have added just a forward declaration, this is a pointer to
the structure so you don't need the compiler to have full knowledge of
the storage type. Not a biggie.
--
Florian
next prev parent reply other threads:[~2016-06-06 18:33 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 12:41 [PATCH v4 0/7] Add MDIO bus multiplexer support for iProc SoCs Pramod Kumar
2016-06-06 12:41 ` Pramod Kumar
2016-06-06 12:41 ` [PATCH v4 1/7] mdio: mux: Enhanced MDIO mux framework for integrated multiplexers Pramod Kumar
2016-06-06 12:41 ` Pramod Kumar
2016-06-06 14:17 ` Andrew Lunn
2016-06-06 14:17 ` Andrew Lunn
2016-06-06 18:33 ` Florian Fainelli [this message]
2016-06-06 18:33 ` Florian Fainelli
2016-06-06 12:41 ` [PATCH v4 2/7] binding: Make "mdio-parent-bus" property from mandatory to optional Pramod Kumar
2016-06-06 12:41 ` Pramod Kumar
2016-06-06 14:17 ` Andrew Lunn
2016-06-06 14:17 ` Andrew Lunn
2016-06-08 19:39 ` Rob Herring
2016-06-08 19:39 ` Rob Herring
2016-06-06 12:41 ` [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for Broadcom MDIO bus multiplexer Pramod Kumar
2016-06-06 12:41 ` Pramod Kumar
2016-06-06 18:36 ` Florian Fainelli
2016-06-06 18:36 ` Florian Fainelli
2016-06-07 11:57 ` Pramod Kumar
2016-06-07 11:57 ` Pramod Kumar
2016-06-07 11:57 ` Pramod Kumar
2016-06-08 19:40 ` Rob Herring
2016-06-08 19:40 ` Rob Herring
2016-06-08 19:43 ` Rob Herring
2016-06-08 19:43 ` Rob Herring
2016-06-08 19:43 ` Rob Herring
2016-06-06 12:41 ` [PATCH v4 4/7] dt: mdio-mux: Add mdio multiplexer driver node Pramod Kumar
2016-06-06 12:41 ` Pramod Kumar
2016-06-06 12:41 ` Pramod Kumar
2016-06-06 18:37 ` Florian Fainelli
2016-06-06 18:37 ` Florian Fainelli
2016-06-10 4:24 ` Pramod Kumar
2016-06-10 4:24 ` Pramod Kumar
2016-06-06 12:41 ` [PATCH v4 5/7] net: mdio-mux: Add MDIO mux driver for iProc SoCs Pramod Kumar
2016-06-06 12:41 ` Pramod Kumar
2016-06-06 14:15 ` Andrew Lunn
2016-06-06 14:15 ` Andrew Lunn
2016-06-06 14:15 ` Andrew Lunn
2016-06-06 18:42 ` Florian Fainelli
2016-06-06 18:42 ` Florian Fainelli
2016-06-06 12:41 ` [PATCH v4 6/7] binding: PHY: Binding doc for NS2 PCIe PHYs Pramod Kumar
2016-06-06 12:41 ` Pramod Kumar
2016-06-06 12:41 ` [PATCH v4 7/7] phy: Add Northstar2 PCI Phy support Pramod Kumar
2016-06-06 12:41 ` Pramod Kumar
2016-06-06 18:42 ` Florian Fainelli
2016-06-06 18:42 ` Florian Fainelli
2016-06-06 18:42 ` Florian Fainelli
2016-06-07 12:25 ` Pramod Kumar
2016-06-07 12:25 ` Pramod Kumar
2016-06-30 12:16 ` Kishon Vijay Abraham I
2016-06-30 12:16 ` Kishon Vijay Abraham I
2016-06-30 12:16 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5755C20E.5040308@gmail.com \
--to=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.