fio bw and iops logs broken

fio bw and iops logs broken

[Jeff Furlong]

Hi All,
Somewhere between fio-2.11 and fio-2.11-14-gf031 the bw and iops logs no longer get written.

# fio --name=test_job --ioengine=libaio --direct=1 --rw=write --iodepth=32 --size=100% --numjobs=1 --bs=1m --filename=/dev/nvme0n1 --group_reporting --write_bw_log=test_job --write_iops_log=test_job --write_lat_log=test_job --log_avg_msec=1000 --disable_lat=0 --disable_clat=0 --disable_slat=0 --runtime=10s --ramp_time=5s --output=test_job

# ls -l
-rw-r--r--  1 root root 1537 Jun  6 15:01 test_job
-rw-r--r--  1 root root    0 Jun  6 15:01 test_job_bw.1.log
-rw-r--r--  1 root root  199 Jun  6 15:01 test_job_clat.1.log
-rw-r--r--  1 root root    0 Jun  6 15:01 test_job_iops.1.log
-rw-r--r--  1 root root  200 Jun  6 15:01 test_job_lat.1.log
-rw-r--r--  1 root root  254 Jun  6 15:01 test_job_slat.1.log

See above file sizes of zero for the bw and iops logs.  However, lat/slat/clat are written.  Thoughts on which recent commit broke the functionality?  Thanks.

Regards,
Jeff


Western Digital Corporation (and its subsidiaries) E-mail Confidentiality Notice & Disclaimer:

This e-mail and any files transmitted with it may contain confidential or legally privileged information of WDC and/or its affiliates, and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.

Re: fio bw and iops logs broken

[Jens Axboe]

On 06/06/2016 04:07 PM, Jeff Furlong wrote:
> Hi All,
> Somewhere between fio-2.11 and fio-2.11-14-gf031 the bw and iops logs no longer get written.
>
> # fio --name=test_job --ioengine=libaio --direct=1 --rw=write --iodepth=32 --size=100% --numjobs=1 --bs=1m --filename=/dev/nvme0n1 --group_reporting --write_bw_log=test_job --write_iops_log=test_job --write_lat_log=test_job --log_avg_msec=1000 --disable_lat=0 --disable_clat=0 --disable_slat=0 --runtime=10s --ramp_time=5s --output=test_job
>
> # ls -l
> -rw-r--r--  1 root root 1537 Jun  6 15:01 test_job
> -rw-r--r--  1 root root    0 Jun  6 15:01 test_job_bw.1.log
> -rw-r--r--  1 root root  199 Jun  6 15:01 test_job_clat.1.log
> -rw-r--r--  1 root root    0 Jun  6 15:01 test_job_iops.1.log
> -rw-r--r--  1 root root  200 Jun  6 15:01 test_job_lat.1.log
> -rw-r--r--  1 root root  254 Jun  6 15:01 test_job_slat.1.log
>
> See above file sizes of zero for the bw and iops logs.  However, lat/slat/clat are written.  Thoughts on which recent commit broke the functionality?  Thanks.

I'll take a look.

-- 
Jens Axboe

Re: fio bw and iops logs broken

[Jens Axboe]

On 06/06/2016 09:08 PM, Jens Axboe wrote:
> On 06/06/2016 04:07 PM, Jeff Furlong wrote:
>> Hi All,
>> Somewhere between fio-2.11 and fio-2.11-14-gf031 the bw and iops logs
>> no longer get written.
>>
>> # fio --name=test_job --ioengine=libaio --direct=1 --rw=write
>> --iodepth=32 --size=100% --numjobs=1 --bs=1m --filename=/dev/nvme0n1
>> --group_reporting --write_bw_log=test_job --write_iops_log=test_job
>> --write_lat_log=test_job --log_avg_msec=1000 --disable_lat=0
>> --disable_clat=0 --disable_slat=0 --runtime=10s --ramp_time=5s
>> --output=test_job
>>
>> # ls -l
>> -rw-r--r--  1 root root 1537 Jun  6 15:01 test_job
>> -rw-r--r--  1 root root    0 Jun  6 15:01 test_job_bw.1.log
>> -rw-r--r--  1 root root  199 Jun  6 15:01 test_job_clat.1.log
>> -rw-r--r--  1 root root    0 Jun  6 15:01 test_job_iops.1.log
>> -rw-r--r--  1 root root  200 Jun  6 15:01 test_job_lat.1.log
>> -rw-r--r--  1 root root  254 Jun  6 15:01 test_job_slat.1.log
>>
>> See above file sizes of zero for the bw and iops logs.  However,
>> lat/slat/clat are written.  Thoughts on which recent commit broke the
>> functionality?  Thanks.
>
> I'll take a look.

Got broken earlier today, with the ramp time fix. The two functions have 
opposite return values... Current -git should work, this is the fix:

http://git.kernel.dk/cgit/fio/commit/?id=6a89b401289ef823c51760c71018b43d0c17532b

-- 
Jens Axboe

RE: fio bw and iops logs broken

[Jeff Furlong]

Indeed, the fix in the current git resolves the issue.  Thanks.

Regards,
Jeff


-----Original Message-----
From: Jens Axboe [mailto:axboe@kernel.dk] 
Sent: Monday, June 6, 2016 8:26 PM
To: Jeff Furlong <jeff.furlong@hgst.com>; fio@vger.kernel.org
Subject: Re: fio bw and iops logs broken

On 06/06/2016 09:08 PM, Jens Axboe wrote:
> On 06/06/2016 04:07 PM, Jeff Furlong wrote:
>> Hi All,
>> Somewhere between fio-2.11 and fio-2.11-14-gf031 the bw and iops logs 
>> no longer get written.
>>
>> # fio --name=test_job --ioengine=libaio --direct=1 --rw=write
>> --iodepth=32 --size=100% --numjobs=1 --bs=1m --filename=/dev/nvme0n1 
>> --group_reporting --write_bw_log=test_job --write_iops_log=test_job 
>> --write_lat_log=test_job --log_avg_msec=1000 --disable_lat=0
>> --disable_clat=0 --disable_slat=0 --runtime=10s --ramp_time=5s 
>> --output=test_job
>>
>> # ls -l
>> -rw-r--r--  1 root root 1537 Jun  6 15:01 test_job
>> -rw-r--r--  1 root root    0 Jun  6 15:01 test_job_bw.1.log
>> -rw-r--r--  1 root root  199 Jun  6 15:01 test_job_clat.1.log
>> -rw-r--r--  1 root root    0 Jun  6 15:01 test_job_iops.1.log
>> -rw-r--r--  1 root root  200 Jun  6 15:01 test_job_lat.1.log
>> -rw-r--r--  1 root root  254 Jun  6 15:01 test_job_slat.1.log
>>
>> See above file sizes of zero for the bw and iops logs.  However, 
>> lat/slat/clat are written.  Thoughts on which recent commit broke the 
>> functionality?  Thanks.
>
> I'll take a look.

Got broken earlier today, with the ramp time fix. The two functions have opposite return values... Current -git should work, this is the fix:

http://git.kernel.dk/cgit/fio/commit/?id=6a89b401289ef823c51760c71018b43d0c17532b

--
Jens Axboe

Western Digital Corporation (and its subsidiaries) E-mail Confidentiality Notice & Disclaimer:

This e-mail and any files transmitted with it may contain confidential or legally privileged information of WDC and/or its affiliates, and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.