All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>,
	Linus Walleij
	<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] pinctrl: tegra: Fix build dependency
Date: Tue, 7 Jun 2016 10:20:46 +0100	[thread overview]
Message-ID: <575691EE.8020409@nvidia.com> (raw)
In-Reply-To: <5756913F.1000108-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>


On 07/06/16 10:17, Jon Hunter wrote:
> 
> On 04/06/16 07:35, Axel Lin wrote:
>> I got below build error:
>> ERROR: "tegra_xusb_padctl_legacy_probe" [drivers/phy/tegra/phy-tegra-xusb.ko] undefined!
>> with below build configuration:
>> CONFIG_ARCH_TEGRA=y
>> CONFIG_PINCTRL_TEGRA_XUSB=y
>> CONFIG_PHY_TEGRA_XUSB=y
> 
> The above does not make sense because the error is from building a
> module but you say you have CONFIG_PINCTRL_TEGRA_XUSB=y. Shouldn't this
> be CONFIG_PINCTRL_TEGRA_XUSB=m? However, the error will occur either if
> you compile as a module or not, but the changelog should be accurate
> nonetheless.

Sorry I meant CONFIG_PHY_TEGRA_XUSB=m and NOT
CONFIG_PINCTRL_TEGRA_XUSB=m as you are building the phy-tegra-xusb as a
module.

Jon

--
nvpublic

WARNING: multiple messages have this Message-ID (diff)
From: Jon Hunter <jonathanh@nvidia.com>
To: Axel Lin <axel.lin@ingics.com>, Linus Walleij <linus.walleij@linaro.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	<linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: tegra: Fix build dependency
Date: Tue, 7 Jun 2016 10:20:46 +0100	[thread overview]
Message-ID: <575691EE.8020409@nvidia.com> (raw)
In-Reply-To: <5756913F.1000108@nvidia.com>


On 07/06/16 10:17, Jon Hunter wrote:
> 
> On 04/06/16 07:35, Axel Lin wrote:
>> I got below build error:
>> ERROR: "tegra_xusb_padctl_legacy_probe" [drivers/phy/tegra/phy-tegra-xusb.ko] undefined!
>> with below build configuration:
>> CONFIG_ARCH_TEGRA=y
>> CONFIG_PINCTRL_TEGRA_XUSB=y
>> CONFIG_PHY_TEGRA_XUSB=y
> 
> The above does not make sense because the error is from building a
> module but you say you have CONFIG_PINCTRL_TEGRA_XUSB=y. Shouldn't this
> be CONFIG_PINCTRL_TEGRA_XUSB=m? However, the error will occur either if
> you compile as a module or not, but the changelog should be accurate
> nonetheless.

Sorry I meant CONFIG_PHY_TEGRA_XUSB=m and NOT
CONFIG_PINCTRL_TEGRA_XUSB=m as you are building the phy-tegra-xusb as a
module.

Jon

--
nvpublic

  parent reply	other threads:[~2016-06-07  9:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-04  6:35 [PATCH] pinctrl: tegra: Fix build dependency Axel Lin
2016-06-07  9:17 ` Jon Hunter
2016-06-07  9:17   ` Jon Hunter
     [not found]   ` <5756913F.1000108-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-06-07  9:20     ` Jon Hunter [this message]
2016-06-07  9:20       ` Jon Hunter
     [not found] ` <1465022156.547.2.camel-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
2016-06-08 11:50   ` Linus Walleij
2016-06-08 11:50     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=575691EE.8020409@nvidia.com \
    --to=jonathanh-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
    --cc=axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org \
    --cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.