From: Michael Tokarev <mjt@tls.msk.ru>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [PULL 24/52] docs: Fix a couple of typos in throttle.txt
Date: Wed, 8 Jun 2016 12:44:35 +0300 [thread overview]
Message-ID: <5757E903.7020308@msgid.tls.msk.ru> (raw)
In-Reply-To: <w51eg8812e1.fsf@maestria.local.igalia.com>
08.06.2016 12:00, Alberto Garcia wrote:
> On Sun 05 Jun 2016 09:43:01 AM CEST, Michael Tokarev wrote:
>
>> - Water leaks from the bucket at a rate of 100 IOPS.
>> - Water can be added to the bucket at a rate of 2000 IOPS.
>> - The size of the bucket is 2000 x 60 = 120000
>> - - If 'iops-total-max-length' is unset then the bucket size is 100.
>> + - If 'iops-total-max' is unset then the bucket size is 100 x 60.
>
> Sorry, I should have noticed this here in the pull request, but this is
> wrong.
This has been discussed before, and it looks like the original
version which I applied was actually right... :)
I can just drop this patch from the pull request, since it hasn't
been applied yet. Esp. since the subject line is now wrong too :)
Thanks,
/mjt
WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PULL 24/52] docs: Fix a couple of typos in throttle.txt
Date: Wed, 8 Jun 2016 12:44:35 +0300 [thread overview]
Message-ID: <5757E903.7020308@msgid.tls.msk.ru> (raw)
In-Reply-To: <w51eg8812e1.fsf@maestria.local.igalia.com>
08.06.2016 12:00, Alberto Garcia wrote:
> On Sun 05 Jun 2016 09:43:01 AM CEST, Michael Tokarev wrote:
>
>> - Water leaks from the bucket at a rate of 100 IOPS.
>> - Water can be added to the bucket at a rate of 2000 IOPS.
>> - The size of the bucket is 2000 x 60 = 120000
>> - - If 'iops-total-max-length' is unset then the bucket size is 100.
>> + - If 'iops-total-max' is unset then the bucket size is 100 x 60.
>
> Sorry, I should have noticed this here in the pull request, but this is
> wrong.
This has been discussed before, and it looks like the original
version which I applied was actually right... :)
I can just drop this patch from the pull request, since it hasn't
been applied yet. Esp. since the subject line is now wrong too :)
Thanks,
/mjt
next prev parent reply other threads:[~2016-06-08 9:44 UTC|newest]
Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-05 7:42 [Qemu-trivial] [PULL 00/52] Trivial patches for 2016-06-05 Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 01/52] s390x/virtio-ccw: fix spelling Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 02/52] hw/ipmi: " Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 03/52] docs: "specify" spell fix Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 04/52] qga: spelling fix Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 05/52] fsdev: " Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 06/52] target-moxie: Remove unused struct elements Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 07/52] po/Makefile: call rm -f directly Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 08/52] gdbstub: set listen backlog to 1 Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 09/52] scripts: add muldiv64() checking coccinelle scripts Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 10/52] The only 64bit parameter of muldiv64() is the first one Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 11/52] remove useless muldiv64() Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 12/52] replace muldiv64(a, b, c) by (uint64_t)a * b / c Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 13/52] ppc: Remove a potential overflow in muldiv64() Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 14/52] Fix linking relocatable objects on Sparc Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 15/52] qemu-options.hx: Specify the units for -machine kvm_shadow_mem Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 16/52] configure: Use $(..) instead of deprecated `..` Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 17/52] scripts: " Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 18/52] ICH9: fix typo Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 19/52] monitor: Typo fix Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 20/52] qdev: Clean up around properties Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 21/52] fw_cfg: follow CODING_STYLE Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:42 ` [Qemu-trivial] [PULL 22/52] replay: Clean up includes Michael Tokarev
2016-06-05 7:42 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 23/52] hw: " Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 24/52] docs: Fix a couple of typos in throttle.txt Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-08 9:00 ` [Qemu-trivial] " Alberto Garcia
2016-06-08 9:00 ` [Qemu-devel] " Alberto Garcia
2016-06-08 9:44 ` Michael Tokarev [this message]
2016-06-08 9:44 ` Michael Tokarev
2016-06-08 10:23 ` [Qemu-trivial] " Alberto Garcia
2016-06-08 10:23 ` [Qemu-devel] " Alberto Garcia
2016-06-05 7:43 ` [Qemu-trivial] [PULL 25/52] Fix configure test for PBKDF2 in nettle Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 26/52] e1000: Removing unnecessary if statement Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 27/52] pc: cleanup unused struct PcRomPciInfo Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 28/52] clean-includes: Add glib.h to list of unneeded includes Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 29/52] tests: Remove unnecessary glib.h includes Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 30/52] qga: " Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 31/52] all: " Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 32/52] docs/multi-thread-compression: Fix wrong command string Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 33/52] host-utils: Prefer 'false' for bool type Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 34/52] qemu-common.h: Drop WORDS_ALIGNED define Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 35/52] thunk: Drop unused NO_THUNK_TYPE_SIZE guards Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 36/52] thunk: Rename args and fields in host-target bitmask conversion code Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 37/52] coccinelle: use macro DIV_ROUND_UP instead of (((n) + (d) - 1) /(d)) Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 38/52] parallels: Use DIV_ROUND_UP Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 39/52] qcow/qcow2: " Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 40/52] qed: " Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 41/52] block: " Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 42/52] crypto: " Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 43/52] xen: " Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 44/52] audio: " Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 45/52] SPICE: " Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 46/52] rocker: " Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 47/52] usb: " Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 48/52] slirp: " Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 49/52] linux-user: " Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 50/52] pc-bios/s390-ccw: " Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-06 13:17 ` [Qemu-trivial] " Laurent Vivier
2016-06-06 13:17 ` [Qemu-devel] " Laurent Vivier
2016-06-07 15:07 ` [Qemu-trivial] " Michael Tokarev
2016-06-07 15:07 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 51/52] qemu-timer: " Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-05 7:43 ` [Qemu-trivial] [PULL 52/52] hbitmap: " Michael Tokarev
2016-06-05 7:43 ` [Qemu-devel] " Michael Tokarev
2016-06-06 9:16 ` [Qemu-trivial] [Qemu-devel] [PULL 00/52] Trivial patches for 2016-06-05 Peter Maydell
2016-06-06 9:16 ` Peter Maydell
2016-06-06 11:12 ` [Qemu-trivial] [PATCH v3] Fix linking relocatable objects on Sparc James Clarke
2016-06-06 11:12 ` [Qemu-devel] " James Clarke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5757E903.7020308@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=berto@igalia.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.