Re: [Qemu-devel] [PATCH v7 00/15] Add param Error ** for msi_init()

[Cao jin <caoj.fnst@cn.fujitsu.com>]

ping~

On 06/06/2016 04:00 PM, Cao jin wrote:
> v7 changelog:
> 1. 4 new patches, patch 11, 13, 14, 15. previous patch 11 numbered 12 now.
> 2. patch 2: remove comment of "errp", add it in patch 12
> 3. patch 4: fix commit message as sugguestion
> 4. replace all "msi == ON_OFF_AUTO_ON || msi == ON_OFF_AUTO_AUTO" to
>     "msi != ON_OFF_AUTO_OFF", before patch 12
> 5. patch 7: correct a error in intel_hda_update_irq(), and change the
>     variant type from int to bool
> 6. patch 13: fix the issue that code would overwrite user configuration.
>     patch 14&15 actually almost the same with 13, remove unnecessary flag.
> 7. patch 12 use tightened error checking as suggestions, but not sure
>     megasas/mptsas is modified as sugguestion perfectly, RFC.
>
> cc: Gerd Hoffmann <kraxel@redhat.com>
> cc: John Snow <jsnow@redhat.com>
> cc: Dmitry Fleytman <dmitry@daynix.com>
> cc: Jason Wang <jasowang@redhat.com>
> cc: Michael S. Tsirkin <mst@redhat.com>
> cc: Hannes Reinecke <hare@suse.de>
> cc: Paolo Bonzini <pbonzini@redhat.com>
> cc: Alex Williamson <alex.williamson@redhat.com>
> cc: Markus Armbruster <armbru@redhat.com>
> cc: Marcel Apfelbaum <marcel@redhat.com>
>
> Cao jin (15):
>    pci core: assert ENOSPC when add capability
>    fix some coding style problems
>    change pvscsi_init_msi() type to void
>    megasas: Fix check for msi_init() failure
>    mptsas: change .realize function name
>    usb xhci: change msi/msix property type
>    intel-hda: change msi property type
>    mptsas: change msi property type
>    megasas: change msi/msix property type
>    pci bridge dev: change msi property type
>    msi_init: change return value to 0 on success
>    pci: Convert msi_init() to Error and fix callers to check it
>    megasas: remove unnecessary megasas_use_msi()
>    mptsas: remove unnecessary internal msi state flag
>    vmw_pvscsi: remove unnecessary internal msi state flag
>
>   hw/audio/intel-hda.c               | 30 ++++++++++++++++----
>   hw/ide/ich.c                       | 15 ++++++----
>   hw/net/vmxnet3.c                   | 40 +++++++++-----------------
>   hw/pci-bridge/ioh3420.c            | 13 +++++++--
>   hw/pci-bridge/pci_bridge_dev.c     | 35 +++++++++++++++++------
>   hw/pci-bridge/xio3130_downstream.c | 12 ++++++--
>   hw/pci-bridge/xio3130_upstream.c   |  9 +++++-
>   hw/pci/msi.c                       | 27 ++++++++++++++++--
>   hw/pci/pci.c                       |  6 ++--
>   hw/scsi/megasas.c                  | 58 ++++++++++++++++++++------------------
>   hw/scsi/mptsas.c                   | 40 +++++++++++++++++---------
>   hw/scsi/mptsas.h                   |  5 ++--
>   hw/scsi/vmw_pvscsi.c               | 22 +++++----------
>   hw/usb/hcd-xhci.c                  | 35 +++++++++++++++++------
>   hw/vfio/pci.c                      |  7 +++--
>   include/hw/pci/msi.h               |  3 +-
>   16 files changed, 226 insertions(+), 131 deletions(-)
>

-- 
Yours Sincerely,

Cao jin