From: Marc Zyngier <marc.zyngier@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: KVM: fix build with CONFIG_ARM_PMU disabled
Date: Wed, 8 Jun 2016 11:48:13 +0100 [thread overview]
Message-ID: <5757F7ED.9060308@arm.com> (raw)
In-Reply-To: <1465382335-5024-1-git-send-email-sudeep.holla@arm.com>
On 08/06/16 11:38, Sudeep Holla wrote:
> When CONFIG_ARM_PMU is disabled, we get the following build error:
>
> arch/arm64/kvm/sys_regs.c: In function 'pmu_counter_idx_valid':
> arch/arm64/kvm/sys_regs.c:564:27: error: 'ARMV8_PMU_CYCLE_IDX' undeclared (first use in this function)
> if (idx >= val && idx != ARMV8_PMU_CYCLE_IDX)
> ^
> arch/arm64/kvm/sys_regs.c:564:27: note: each undeclared identifier is reported only once for each function it appears in
> arch/arm64/kvm/sys_regs.c: In function 'access_pmu_evcntr':
> arch/arm64/kvm/sys_regs.c:592:10: error: 'ARMV8_PMU_CYCLE_IDX' undeclared (first use in this function)
> idx = ARMV8_PMU_CYCLE_IDX;
> ^
> arch/arm64/kvm/sys_regs.c: In function 'access_pmu_evtyper':
> arch/arm64/kvm/sys_regs.c:638:14: error: 'ARMV8_PMU_CYCLE_IDX' undeclared (first use in this function)
> if (idx == ARMV8_PMU_CYCLE_IDX)
> ^
> arch/arm64/kvm/hyp/switch.c:86:15: error: 'ARMV8_PMU_USERENR_MASK' undeclared (first use in this function)
> write_sysreg(ARMV8_PMU_USERENR_MASK, pmuserenr_el0);
>
> This patch fixes the build with CONFIG_ARM_PMU disabled.
>
> Cc: Christoffer Dall <christoffer.dall@linaro.org>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: KVM: fix build with CONFIG_ARM_PMU disabled
Date: Wed, 8 Jun 2016 11:48:13 +0100 [thread overview]
Message-ID: <5757F7ED.9060308@arm.com> (raw)
In-Reply-To: <1465382335-5024-1-git-send-email-sudeep.holla@arm.com>
On 08/06/16 11:38, Sudeep Holla wrote:
> When CONFIG_ARM_PMU is disabled, we get the following build error:
>
> arch/arm64/kvm/sys_regs.c: In function 'pmu_counter_idx_valid':
> arch/arm64/kvm/sys_regs.c:564:27: error: 'ARMV8_PMU_CYCLE_IDX' undeclared (first use in this function)
> if (idx >= val && idx != ARMV8_PMU_CYCLE_IDX)
> ^
> arch/arm64/kvm/sys_regs.c:564:27: note: each undeclared identifier is reported only once for each function it appears in
> arch/arm64/kvm/sys_regs.c: In function 'access_pmu_evcntr':
> arch/arm64/kvm/sys_regs.c:592:10: error: 'ARMV8_PMU_CYCLE_IDX' undeclared (first use in this function)
> idx = ARMV8_PMU_CYCLE_IDX;
> ^
> arch/arm64/kvm/sys_regs.c: In function 'access_pmu_evtyper':
> arch/arm64/kvm/sys_regs.c:638:14: error: 'ARMV8_PMU_CYCLE_IDX' undeclared (first use in this function)
> if (idx == ARMV8_PMU_CYCLE_IDX)
> ^
> arch/arm64/kvm/hyp/switch.c:86:15: error: 'ARMV8_PMU_USERENR_MASK' undeclared (first use in this function)
> write_sysreg(ARMV8_PMU_USERENR_MASK, pmuserenr_el0);
>
> This patch fixes the build with CONFIG_ARM_PMU disabled.
>
> Cc: Christoffer Dall <christoffer.dall@linaro.org>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2016-06-08 10:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 10:38 [PATCH] arm64: KVM: fix build with CONFIG_ARM_PMU disabled Sudeep Holla
2016-06-08 10:38 ` Sudeep Holla
2016-06-08 10:48 ` Marc Zyngier [this message]
2016-06-08 10:48 ` Marc Zyngier
2016-06-27 11:08 ` Christoffer Dall
2016-06-27 11:08 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5757F7ED.9060308@arm.com \
--to=marc.zyngier@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.