Re: [PATCH 3/8] mfd: tps65218: Use mfd_add_devices instead of of_platform_populate

[Keerthy <a0393675@ti.com>]

On Wednesday 08 June 2016 09:20 PM, Lee Jones wrote:
> On Wed, 11 May 2016, Keerthy wrote:
>
>> mfd_add_devices enables parsing device tree nodes without compatibles
>> for child nodes. Replace of_platform_populate with mfd_add_devices.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>>   drivers/mfd/tps65218.c | 10 ++++++++--
>>   1 file changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c
>> index f20a531..b8b3a58 100644
>> --- a/drivers/mfd/tps65218.c
>> +++ b/drivers/mfd/tps65218.c
>> @@ -33,6 +33,10 @@
>>
>>   #define TPS65218_PASSWORD_REGS_UNLOCK   0x7D
>>
>> +static const struct mfd_cell tps65218_cells[] = {
>> +	{ .name = "tps65218-regulator", },
>> +};
>
> What other devices does the TPS65218 consist of?

As of now only regulators driver is in kernel. The PMIC contains
a bunch of GPIOs, Over temperature warning / shutdown unit.

>
>>   /**
>>    * tps65218_reg_write: Write a single tps65218 register.
>>    *
>> @@ -236,8 +240,10 @@ static int tps65218_probe(struct i2c_client *client,
>>   	if (ret < 0)
>>   		return ret;
>>
>> -	ret = of_platform_populate(client->dev.of_node, NULL, NULL,
>> -				   &client->dev);
>> +	ret = mfd_add_devices(tps->dev, PLATFORM_DEVID_AUTO, tps65218_cells,
>> +			      ARRAY_SIZE(tps65218_cells), NULL, 0,
>> +			      regmap_irq_get_domain(tps->irq_data));
>> +
>>   	if (ret < 0)
>>   		goto err_irq;
>>
>