From: Dave Hansen <dave.hansen@intel.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Lukasz Odzioba <lukasz.odzioba@intel.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
aarcange@redhat.com, vdavydov@parallels.com, mingli199x@qq.com,
minchan@kernel.org, lukasz.anaczkowski@intel.com, "Shutemov,
Kirill" <kirill.shutemov@intel.com>
Subject: Re: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page arrival
Date: Wed, 8 Jun 2016 09:34:01 -0700 [thread overview]
Message-ID: <575848F9.2060501@intel.com> (raw)
In-Reply-To: <20160608160653.GB21838@dhcp22.suse.cz>
On 06/08/2016 09:06 AM, Michal Hocko wrote:
>> > Do we have any statistics that tell us how many pages are sitting the
>> > lru pvecs? Although this helps the problem overall, don't we still have
>> > a problem with memory being held in such an opaque place?
> Is it really worth bothering when we are talking about 56kB per CPU
> (after this patch)?
That was the logic why we didn't have it up until now: we didn't
*expect* it to get large. A code change blew it up by 512x, and we had
no instrumentation to tell us where all the memory went.
I guess we don't have any other ways to group pages than compound pages,
and _that_ one is covered now... for one of the 5 classes of pvecs.
Is there a good reason we don't have to touch the other 4 pagevecs, btw?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Lukasz Odzioba <lukasz.odzioba@intel.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
aarcange@redhat.com, vdavydov@parallels.com, mingli199x@qq.com,
minchan@kernel.org, lukasz.anaczkowski@intel.com, "Shutemov,
Kirill" <kirill.shutemov@intel.com>
Subject: Re: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page arrival
Date: Wed, 8 Jun 2016 09:34:01 -0700 [thread overview]
Message-ID: <575848F9.2060501@intel.com> (raw)
In-Reply-To: <20160608160653.GB21838@dhcp22.suse.cz>
On 06/08/2016 09:06 AM, Michal Hocko wrote:
>> > Do we have any statistics that tell us how many pages are sitting the
>> > lru pvecs? Although this helps the problem overall, don't we still have
>> > a problem with memory being held in such an opaque place?
> Is it really worth bothering when we are talking about 56kB per CPU
> (after this patch)?
That was the logic why we didn't have it up until now: we didn't
*expect* it to get large. A code change blew it up by 512x, and we had
no instrumentation to tell us where all the memory went.
I guess we don't have any other ways to group pages than compound pages,
and _that_ one is covered now... for one of the 5 classes of pvecs.
Is there a good reason we don't have to touch the other 4 pagevecs, btw?
next prev parent reply other threads:[~2016-06-08 16:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 14:35 [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page arrival Lukasz Odzioba
2016-06-08 14:35 ` Lukasz Odzioba
2016-06-08 15:04 ` Michal Hocko
2016-06-08 15:04 ` Michal Hocko
2016-06-09 8:01 ` Odzioba, Lukasz
2016-06-09 8:01 ` Odzioba, Lukasz
2016-06-08 15:31 ` Dave Hansen
2016-06-08 15:31 ` Dave Hansen
2016-06-08 16:06 ` Michal Hocko
2016-06-08 16:06 ` Michal Hocko
2016-06-08 16:34 ` Dave Hansen [this message]
2016-06-08 16:34 ` Dave Hansen
2016-06-09 12:21 ` Michal Hocko
2016-06-09 12:21 ` Michal Hocko
2016-06-16 18:08 ` Odzioba, Lukasz
2016-06-16 18:08 ` Odzioba, Lukasz
2016-06-16 18:19 ` Michal Hocko
2016-06-16 18:19 ` Michal Hocko
2016-06-16 20:03 ` Odzioba, Lukasz
2016-06-16 20:03 ` Odzioba, Lukasz
2016-06-09 8:50 ` Odzioba, Lukasz
2016-06-09 8:50 ` Odzioba, Lukasz
2016-06-09 15:41 ` Dave Hansen
2016-06-09 15:41 ` Dave Hansen
2016-06-13 21:01 ` Odzioba, Lukasz
2016-06-13 21:01 ` Odzioba, Lukasz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575848F9.2060501@intel.com \
--to=dave.hansen@intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lukasz.anaczkowski@intel.com \
--cc=lukasz.odzioba@intel.com \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=mingli199x@qq.com \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.