From: Roger Quadros <rogerq@ti.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kukjin Kim <kgene@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Cc: Felipe Balbi <balbi@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Peter Chen <peter.chen@freescale.com>,
"Ivan T. Ivanov" <iivanov@mm-sol.com>,
kishon@ti.com
Subject: Re: [RFC v4 2/7] Revert "extcon: usb-gpio: switch to use pm wakeirq apis"
Date: Thu, 9 Jun 2016 11:20:29 +0300 [thread overview]
Message-ID: <575926CD.80608@ti.com> (raw)
In-Reply-To: <5759247E.6060901@samsung.com>
On 09/06/16 11:10, Krzysztof Kozlowski wrote:
> On 06/09/2016 10:00 AM, Roger Quadros wrote:
>> -balbi@ti
>> +balbi@kernel
>>
>> Hi,
>>
>> On 08/06/16 16:48, Krzysztof Kozlowski wrote:
>>> This reverts commit 8106e404174253639731cc30a44f5b3ab764c5b7.
>>
>> The above commit id is not present in v4.7-rc1 and this patch doesn't apply properly.
>> Can you please rebase this series on v4.7-rc1?
>
> The commit is present in extcon tree for v4.8. The extcon patches will
> be applied (probably) to that tree so what is the point of rebasing on
> v4.7-rc1?
OK, please ignore my comment. Would be nice if you mention in the cover letter
which tree the series is based on.
>
> Also the point of this particular patch is to show that previous change
> should be just dropped. Don't replace things to complicated devm-like
> functions just to simplify one path in the driver...
>
--
cheers,
0roger
WARNING: multiple messages have this Message-ID (diff)
From: rogerq@ti.com (Roger Quadros)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC v4 2/7] Revert "extcon: usb-gpio: switch to use pm wakeirq apis"
Date: Thu, 9 Jun 2016 11:20:29 +0300 [thread overview]
Message-ID: <575926CD.80608@ti.com> (raw)
In-Reply-To: <5759247E.6060901@samsung.com>
On 09/06/16 11:10, Krzysztof Kozlowski wrote:
> On 06/09/2016 10:00 AM, Roger Quadros wrote:
>> -balbi at ti
>> +balbi at kernel
>>
>> Hi,
>>
>> On 08/06/16 16:48, Krzysztof Kozlowski wrote:
>>> This reverts commit 8106e404174253639731cc30a44f5b3ab764c5b7.
>>
>> The above commit id is not present in v4.7-rc1 and this patch doesn't apply properly.
>> Can you please rebase this series on v4.7-rc1?
>
> The commit is present in extcon tree for v4.8. The extcon patches will
> be applied (probably) to that tree so what is the point of rebasing on
> v4.7-rc1?
OK, please ignore my comment. Would be nice if you mention in the cover letter
which tree the series is based on.
>
> Also the point of this particular patch is to show that previous change
> should be just dropped. Don't replace things to complicated devm-like
> functions just to simplify one path in the driver...
>
--
cheers,
0roger
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kukjin Kim <kgene@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>
Cc: Peter Chen <peter.chen@freescale.com>,
"Ivan T. Ivanov" <iivanov@mm-sol.com>,
Felipe Balbi <balbi@kernel.org>, <kishon@ti.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [RFC v4 2/7] Revert "extcon: usb-gpio: switch to use pm wakeirq apis"
Date: Thu, 9 Jun 2016 11:20:29 +0300 [thread overview]
Message-ID: <575926CD.80608@ti.com> (raw)
In-Reply-To: <5759247E.6060901@samsung.com>
On 09/06/16 11:10, Krzysztof Kozlowski wrote:
> On 06/09/2016 10:00 AM, Roger Quadros wrote:
>> -balbi@ti
>> +balbi@kernel
>>
>> Hi,
>>
>> On 08/06/16 16:48, Krzysztof Kozlowski wrote:
>>> This reverts commit 8106e404174253639731cc30a44f5b3ab764c5b7.
>>
>> The above commit id is not present in v4.7-rc1 and this patch doesn't apply properly.
>> Can you please rebase this series on v4.7-rc1?
>
> The commit is present in extcon tree for v4.8. The extcon patches will
> be applied (probably) to that tree so what is the point of rebasing on
> v4.7-rc1?
OK, please ignore my comment. Would be nice if you mention in the cover letter
which tree the series is based on.
>
> Also the point of this particular patch is to show that previous change
> should be just dropped. Don't replace things to complicated devm-like
> functions just to simplify one path in the driver...
>
--
cheers,
0roger
next prev parent reply other threads:[~2016-06-09 8:20 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160608134820epcas1p4ee75a89888f2ae2adb733124a330bd2c@epcas1p4.samsung.com>
2016-06-08 13:47 ` [RFC v4 0/7] extcon: usb-gpio: fixes and improvements Krzysztof Kozlowski
2016-06-08 13:47 ` Krzysztof Kozlowski
2016-06-08 13:48 ` [RFC v4 1/7] Documentation: extcon: usb-gpio: update usb-gpio binding description Krzysztof Kozlowski
2016-06-08 13:48 ` Krzysztof Kozlowski
[not found] ` <1465393686-16644-2-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-06-10 14:00 ` Rob Herring
2016-06-10 14:00 ` Rob Herring
2016-06-10 14:00 ` Rob Herring
2016-06-08 13:48 ` [RFC v4 2/7] Revert "extcon: usb-gpio: switch to use pm wakeirq apis" Krzysztof Kozlowski
2016-06-08 13:48 ` Krzysztof Kozlowski
[not found] ` <1465393686-16644-3-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-06-09 8:00 ` Roger Quadros
2016-06-09 8:00 ` Roger Quadros
2016-06-09 8:00 ` Roger Quadros
2016-06-09 8:10 ` Krzysztof Kozlowski
2016-06-09 8:10 ` Krzysztof Kozlowski
2016-06-09 8:20 ` Roger Quadros [this message]
2016-06-09 8:20 ` Roger Quadros
2016-06-09 8:20 ` Roger Quadros
2016-06-08 13:48 ` [RFC v4 3/7] extcon: Add raw VBUS and ID cable states Krzysztof Kozlowski
2016-06-08 13:48 ` Krzysztof Kozlowski
2016-06-08 13:48 ` Krzysztof Kozlowski
2016-06-08 13:48 ` [RFC v4 4/7] extcon: usb-gpio: Add support for VBUS detection Krzysztof Kozlowski
2016-06-08 13:48 ` Krzysztof Kozlowski
2016-06-08 13:48 ` Krzysztof Kozlowski
2016-06-09 8:38 ` Roger Quadros
2016-06-09 8:38 ` Roger Quadros
2016-06-09 8:38 ` Roger Quadros
2016-06-09 8:41 ` Roger Quadros
2016-06-09 8:41 ` Roger Quadros
2016-06-09 8:41 ` Roger Quadros
2016-06-09 8:43 ` Krzysztof Kozlowski
2016-06-09 8:43 ` Krzysztof Kozlowski
2016-06-09 12:13 ` Roger Quadros
2016-06-09 12:13 ` Roger Quadros
2016-06-09 12:13 ` Roger Quadros
2016-06-08 13:48 ` [RFC v4 5/7] extcon: usb-gpio: make debounce value configurable in devicetree Krzysztof Kozlowski
2016-06-08 13:48 ` Krzysztof Kozlowski
2016-06-08 13:48 ` [RFC v4 6/7] ARM: exynos_defconfig: Enable EXTCON_USB_GPIO for Odroid XU3 USB OTG Krzysztof Kozlowski
2016-06-08 13:48 ` Krzysztof Kozlowski
2016-06-08 13:48 ` [RFC v4 7/7] ARM: dts: exynos: Add extcon-usb-gpio node for Odroid XU3 Krzysztof Kozlowski
2016-06-08 13:48 ` Krzysztof Kozlowski
2016-06-09 8:35 ` [RFC v4 0/7] extcon: usb-gpio: fixes and improvements Chanwoo Choi
2016-06-09 8:35 ` Chanwoo Choi
2016-06-09 8:39 ` Krzysztof Kozlowski
2016-06-09 8:39 ` Krzysztof Kozlowski
[not found] ` <57592B4A.4000407-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-06-09 9:32 ` Chanwoo Choi
2016-06-09 9:32 ` Chanwoo Choi
2016-06-09 9:32 ` Chanwoo Choi
[not found] ` <575937BA.1070609-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-08-01 12:23 ` Roger Quadros
2016-08-01 12:23 ` Roger Quadros
2016-08-01 12:23 ` Roger Quadros
2016-08-01 12:57 ` Chanwoo Choi
2016-08-01 12:57 ` Chanwoo Choi
2016-06-26 16:39 ` Tobias Jakobi
2016-06-26 16:39 ` Tobias Jakobi
2016-06-27 5:22 ` Krzysztof Kozlowski
2016-06-27 5:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575926CD.80608@ti.com \
--to=rogerq@ti.com \
--cc=b.zolnierkie@samsung.com \
--cc=balbi@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=iivanov@mm-sol.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=peter.chen@freescale.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.