From: Michael Wood <michael.g.wood@intel.com>
To: toaster@yoctoproject.org
Subject: Re: [PATCH][v2] toaster: fix typo which prevents filters from working
Date: Thu, 9 Jun 2016 14:42:40 +0100 [thread overview]
Message-ID: <57597250.6060406@intel.com> (raw)
In-Reply-To: <1465313375-19742-1-git-send-email-elliot.smith@intel.com>
Thanks pushed to toaster-next
On 07/06/16 16:29, Elliot Smith wrote:
> 'k' was replaced by 'key' at some point but not fixed in the
> body of the loop. This caused a failure when the the query
> was constructed for a filtered queryset, due to the variable
> not being defined.
>
> Signed-off-by: Elliot Smith <elliot.smith@intel.com>
> ---
> bitbake/lib/toaster/toastergui/views.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bitbake/lib/toaster/toastergui/views.py b/bitbake/lib/toaster/toastergui/views.py
> index 16f98ee..9d06000 100755
> --- a/bitbake/lib/toaster/toastergui/views.py
> +++ b/bitbake/lib/toaster/toastergui/views.py
> @@ -268,7 +268,7 @@ def _get_filtering_query(filter_string):
> or_values = kv[1].split(OR_VALUE_SEPARATOR)
> query = None
> for key, val in zip(or_keys, or_values):
> - x = __get_q_for_val(k, val)
> + x = __get_q_for_val(key, val)
> query = query | x if query else x
>
> and_query = and_query & query if and_query else query
prev parent reply other threads:[~2016-06-09 13:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 15:29 [PATCH][v2] toaster: fix typo which prevents filters from working Elliot Smith
2016-06-09 13:42 ` Michael Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57597250.6060406@intel.com \
--to=michael.g.wood@intel.com \
--cc=toaster@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.