All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
To: Yoshihiro Shimoda
	<yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>,
	"peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org"
	<peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: "balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org"
	<tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
	"gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org"
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	"dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
	<dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"mathias.nyman-VuQAYsv1563Yd54FQh9/CA@public.gmane.org"
	<mathias.nyman-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	"Joao.Pinto-HKixBCOQz3hWk0Htik3J/w@public.gmane.org"
	<Joao.Pinto-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>,
	"sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org"
	<sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>,
	"jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org"
	<jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	"grygorii.strashko-l0cyMroinI0@public.gmane.org"
	<grygorii.strashko-l0cyMroinI0@public.gmane.org>,
	"robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"nsekhar-l0cyMroinI0@public.gmane.org"
	<nsekhar-l0cyMroinI0@public.gmane.org>,
	"b-liu-l0cyMroinI0@public.gmane.org"
	<b-liu-l0cyMroinI0@public.gmane.org>,
	"linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v9 13/14] usb: gadget: udc: adapt to OTG core
Date: Fri, 10 Jun 2016 10:06:24 +0300	[thread overview]
Message-ID: <575A66F0.4090307@ti.com> (raw)
In-Reply-To: <SG2PR06MB09198DD132E005FFD4F4CAEED85F0-ESzmfEwOt/zNQ8RBPPB5A20DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>

Hi Yoshihiro,

On 09/06/16 13:49, Yoshihiro Shimoda wrote:
> Hi Roger,
> 
>> From: Roger Quadros
>> Sent: Wednesday, June 08, 2016 6:04 PM
>>
>> The OTG state machine needs a mechanism to start and
>> stop the gadget controller as well as connect/disconnect
>> from the bus. Add usb_gadget_start(), usb_gadget_stop()
>> and usb_gadget_connect_control().
>>
>> Introduce usb_otg_add_gadget_udc() to allow controller drivers
>> to register a gadget controller that is part of an OTG instance.
>>
>> Register with OTG core when UDC is added in usb_add_gadget_udc_release()
>> and unregister on usb_del_gadget_udc().
>>
>> Notify the OTG core when gadget function driver is available on
>> udc_bind_to_driver() and when it is removed in usb_gadget_remove_driver().
>>
>> We need to unlock the usb_lock mutex before calling
>> usb_otg_register_gadget() else it will cause a circular
>> locking dependency.
>>
>> Ignore softconnect sysfs control when we're in OTG
>> mode as OTG FSM should care of gadget softconnect using
>> the b_bus_req mechanism.
>>
>> Signed-off-by: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
>> ---
>>  drivers/usb/gadget/udc/udc-core.c | 202 ++++++++++++++++++++++++++++++++++++--
>>  include/linux/usb/gadget.h        |   4 +
>>  2 files changed, 196 insertions(+), 10 deletions(-)
> 
> I tried to apply this patch on the Felipe's usb.git / testing/next branch,
> but I couldn't apply because the udc-core.c was renamed to core.c.
> https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=a22b539c7082b6a3046b3a9cebb356a047a2d81d
> 
> I guess this patch needs rebase for that.

OK. I'll respin the whole series on Felipe's usb.git /testing/next.

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	"peter.chen@freescale.com" <peter.chen@freescale.com>
Cc: "balbi@kernel.org" <balbi@kernel.org>,
	"tony@atomide.com" <tony@atomide.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"mathias.nyman@linux.intel.com" <mathias.nyman@linux.intel.com>,
	"Joao.Pinto@synopsys.com" <Joao.Pinto@synopsys.com>,
	"sergei.shtylyov@cogentembedded.com" 
	<sergei.shtylyov@cogentembedded.com>,
	"jun.li@freescale.com" <jun.li@freescale.com>,
	"grygorii.strashko@ti.com" <grygorii.strashko@ti.com>,
	"robh@kernel.org" <robh@kernel.org>,
	"nsekhar@ti.com" <nsekhar@ti.com>, "b-liu@ti.com" <b-liu@ti.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v9 13/14] usb: gadget: udc: adapt to OTG core
Date: Fri, 10 Jun 2016 10:06:24 +0300	[thread overview]
Message-ID: <575A66F0.4090307@ti.com> (raw)
In-Reply-To: <SG2PR06MB09198DD132E005FFD4F4CAEED85F0@SG2PR06MB0919.apcprd06.prod.outlook.com>

Hi Yoshihiro,

On 09/06/16 13:49, Yoshihiro Shimoda wrote:
> Hi Roger,
> 
>> From: Roger Quadros
>> Sent: Wednesday, June 08, 2016 6:04 PM
>>
>> The OTG state machine needs a mechanism to start and
>> stop the gadget controller as well as connect/disconnect
>> from the bus. Add usb_gadget_start(), usb_gadget_stop()
>> and usb_gadget_connect_control().
>>
>> Introduce usb_otg_add_gadget_udc() to allow controller drivers
>> to register a gadget controller that is part of an OTG instance.
>>
>> Register with OTG core when UDC is added in usb_add_gadget_udc_release()
>> and unregister on usb_del_gadget_udc().
>>
>> Notify the OTG core when gadget function driver is available on
>> udc_bind_to_driver() and when it is removed in usb_gadget_remove_driver().
>>
>> We need to unlock the usb_lock mutex before calling
>> usb_otg_register_gadget() else it will cause a circular
>> locking dependency.
>>
>> Ignore softconnect sysfs control when we're in OTG
>> mode as OTG FSM should care of gadget softconnect using
>> the b_bus_req mechanism.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>>  drivers/usb/gadget/udc/udc-core.c | 202 ++++++++++++++++++++++++++++++++++++--
>>  include/linux/usb/gadget.h        |   4 +
>>  2 files changed, 196 insertions(+), 10 deletions(-)
> 
> I tried to apply this patch on the Felipe's usb.git / testing/next branch,
> but I couldn't apply because the udc-core.c was renamed to core.c.
> https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=a22b539c7082b6a3046b3a9cebb356a047a2d81d
> 
> I guess this patch needs rebase for that.

OK. I'll respin the whole series on Felipe's usb.git /testing/next.

cheers,
-roger

  parent reply	other threads:[~2016-06-10  7:06 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08  9:03 [PATCH v9 00/14] USB OTG/dual-role framework Roger Quadros
2016-06-08  9:03 ` Roger Quadros
2016-06-08  9:03 ` [PATCH v9 01/14] usb: hcd: Initialize hcd->flags to 0 Roger Quadros
2016-06-08  9:03   ` Roger Quadros
2016-06-08  9:03 ` [PATCH v9 02/14] usb: otg-fsm: Prevent build warning "VDBG" redefined Roger Quadros
2016-06-08  9:03   ` Roger Quadros
2016-06-08  9:03 ` [PATCH v9 03/14] usb: hcd.h: Add OTG to HCD interface Roger Quadros
2016-06-08  9:03   ` Roger Quadros
     [not found]   ` <1465376626-30122-4-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-06-08 11:39     ` Sergei Shtylyov
2016-06-08 11:39       ` Sergei Shtylyov
2016-06-08 12:04       ` Roger Quadros
2016-06-08 12:04         ` Roger Quadros
     [not found]         ` <575809E9.7010409-l0cyMroinI0@public.gmane.org>
2016-06-08 12:10           ` Sergei Shtylyov
2016-06-08 12:10             ` Sergei Shtylyov
     [not found]             ` <f5f068ae-c46a-5bad-45e1-f0f9cb5f8592-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-06-09  7:31               ` Roger Quadros
2016-06-09  7:31                 ` Roger Quadros
2016-06-09 10:16                 ` Sergei Shtylyov
     [not found]                   ` <5201761f-4efa-f941-b05f-e4a2b91c75c0-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-06-09 14:11                     ` Alan Stern
2016-06-09 14:11                       ` Alan Stern
2016-06-10  7:01                       ` Roger Quadros
2016-06-10  7:01                         ` Roger Quadros
2016-06-09  7:51   ` [PATCH v10 " Roger Quadros
2016-06-09  7:51     ` Roger Quadros
2016-06-08  9:03 ` [PATCH v9 04/14] usb: otg-fsm: use usb_otg wherever possible Roger Quadros
2016-06-08  9:03   ` Roger Quadros
2016-06-08  9:03 ` [PATCH v9 05/14] usb: otg-fsm: move host controller operations into usb_otg->hcd_ops Roger Quadros
2016-06-08  9:03   ` Roger Quadros
2016-06-08  9:03 ` [PATCH v9 06/14] usb: gadget.h: Add OTG to gadget interface Roger Quadros
2016-06-08  9:03   ` Roger Quadros
2016-06-08  9:03 ` [PATCH v9 07/14] usb: otg: get rid of CONFIG_USB_OTG_FSM in favour of CONFIG_USB_OTG Roger Quadros
2016-06-08  9:03   ` Roger Quadros
2016-06-08  9:03 ` [PATCH v9 08/14] usb: otg: add OTG/dual-role core Roger Quadros
2016-06-08  9:03   ` Roger Quadros
2016-06-08  9:53   ` Peter Chen
2016-06-08 10:12     ` Roger Quadros
2016-06-08 10:12       ` Roger Quadros
     [not found]       ` <5757EF7A.20604-l0cyMroinI0@public.gmane.org>
2016-06-08 12:42         ` Peter Chen
2016-06-08 12:42           ` Peter Chen
2016-06-09  7:24           ` Roger Quadros
2016-06-09  7:24             ` Roger Quadros
     [not found]             ` <575919BC.8080003-l0cyMroinI0@public.gmane.org>
2016-06-12  6:26               ` Peter Chen
2016-06-12  6:26                 ` Peter Chen
2016-06-12 10:56                 ` Peter Chen
2016-06-09  7:53   ` [PATCH v10 " Roger Quadros
2016-06-09  7:53     ` Roger Quadros
2016-06-09 12:34     ` Sergei Shtylyov
2016-06-10  7:04       ` Roger Quadros
2016-06-10  7:04         ` Roger Quadros
2016-06-10 10:19       ` Roger Quadros
2016-06-10 10:19         ` Roger Quadros
     [not found]         ` <575A9430.6070508-l0cyMroinI0@public.gmane.org>
2016-06-10 10:44           ` Sergei Shtylyov
2016-06-10 10:44             ` Sergei Shtylyov
2016-06-10 10:54             ` Roger Quadros
2016-06-10 10:54               ` Roger Quadros
     [not found]               ` <575A9C7C.7020902-l0cyMroinI0@public.gmane.org>
2016-06-10 11:02                 ` Felipe Balbi
2016-06-10 11:02                   ` Felipe Balbi
2016-06-08  9:03 ` [PATCH v9 09/14] usb: of: add an API to get OTG device from USB controller node Roger Quadros
2016-06-08  9:03   ` Roger Quadros
2016-06-08  9:03 ` [PATCH v9 10/14] usb: otg: add hcd companion support Roger Quadros
2016-06-08  9:03   ` Roger Quadros
2016-06-08  9:03 ` [PATCH v9 11/14] usb: otg: use dev_dbg() instead of VDBG() Roger Quadros
2016-06-08  9:03   ` Roger Quadros
     [not found]   ` <1465376626-30122-12-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-06-08 15:10     ` Joe Perches
2016-06-08 15:10       ` Joe Perches
     [not found]       ` <1465398640.25087.50.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2016-06-09  7:25         ` Roger Quadros
2016-06-09  7:25           ` Roger Quadros
2016-06-09  7:55     ` [PATCH v10 " Roger Quadros
2016-06-09  7:55       ` Roger Quadros
     [not found]       ` <575920D9.7080905-l0cyMroinI0@public.gmane.org>
2016-06-09 15:43         ` Joe Perches
2016-06-09 15:43           ` Joe Perches
     [not found]           ` <1465487024.25087.72.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2016-06-10  7:05             ` Roger Quadros
2016-06-10  7:05               ` Roger Quadros
2016-06-08  9:03 ` [PATCH v9 12/14] usb: hcd: Adapt to OTG core Roger Quadros
2016-06-08  9:03   ` Roger Quadros
2016-06-08 11:42   ` Sergei Shtylyov
     [not found]     ` <22442eeb-e927-d7ac-52c6-3aebd2106837-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-06-08 12:06       ` Roger Quadros
2016-06-08 12:06         ` Roger Quadros
2016-06-08 12:11         ` Sergei Shtylyov
     [not found]           ` <21edbb67-8219-14ac-5c33-cabfd62d5fa1-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-06-09  7:27             ` Roger Quadros
2016-06-09  7:27               ` Roger Quadros
2016-06-08  9:03 ` [PATCH v9 13/14] usb: gadget: udc: adapt " Roger Quadros
2016-06-08  9:03   ` Roger Quadros
     [not found]   ` <1465376626-30122-14-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-06-09 10:49     ` Yoshihiro Shimoda
2016-06-09 10:49       ` Yoshihiro Shimoda
     [not found]       ` <SG2PR06MB09198DD132E005FFD4F4CAEED85F0-ESzmfEwOt/zNQ8RBPPB5A20DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-06-10  7:06         ` Roger Quadros [this message]
2016-06-10  7:06           ` Roger Quadros
2016-06-08  9:03 ` [PATCH v9 14/14] usb: host: xhci-plat: Add otg device to platform data Roger Quadros
2016-06-08  9:03   ` Roger Quadros
     [not found] ` <1465376626-30122-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-06-09  5:27   ` [PATCH v9 00/14] USB OTG/dual-role framework Peter Chen
2016-06-09  5:27     ` Peter Chen
     [not found]     ` <CAL411-owotvsJVEnbFh5g8yK7YEPnnpBhYx9_tRf6NQET38L+A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-09  7:30       ` Roger Quadros
2016-06-09  7:30         ` Roger Quadros
2016-06-09 10:13         ` Yoshihiro Shimoda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=575A66F0.4090307@ti.com \
    --to=rogerq-l0cymroini0@public.gmane.org \
    --cc=Joao.Pinto-HKixBCOQz3hWk0Htik3J/w@public.gmane.org \
    --cc=b-liu-l0cyMroinI0@public.gmane.org \
    --cc=balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=grygorii.strashko-l0cyMroinI0@public.gmane.org \
    --cc=jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mathias.nyman-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=nsekhar-l0cyMroinI0@public.gmane.org \
    --cc=peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    --cc=yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.