From: Laxman Dewangan <ldewangan@nvidia.com>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>, <linux-clk@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] clk: max77620: Add clock driver for MAX77620/MAX20024
Date: Fri, 10 Jun 2016 18:43:52 +0530 [thread overview]
Message-ID: <575ABD10.60208@nvidia.com> (raw)
In-Reply-To: <CABxcv=mrmN5Mzt595ZFgGbOoHJWQMwQ1wiCvcHEiWh_79EbJqQ@mail.gmail.com>
On Friday 10 June 2016 06:50 PM, Javier Martinez Canillas wrote:
> Hello Laxman,
>
> On Fri, Jun 10, 2016 at 6:12 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>> MAXIM MAX77620 is the power management IC with multiple DCDC/LDO(
>> regulators, RTC, GPIOs, Watchdog, 32KHz clock source etc.
>>
>> Add support for controlling the 32KHz clock source via clock
>> framework.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> ---
> It looks very similar to the max77686 and max77802 drivers (with only
> the difference in number of clock outputs), can you use the helpers in
> drivers/clk/clk-max-gen.c ?
I have explored that option.
The bit location for clock bit on register are same in case of max77686
and max77802 but it is different for the max77620.
So until I change it too generic, it will not be possible.
Also if it is require then what about all max77686/max77802 and max77620
in single file, the way we did for RTC.
We dont need 4 files for the similar driver then.
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>,
linux-clk@vger.kernel.org,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] clk: max77620: Add clock driver for MAX77620/MAX20024
Date: Fri, 10 Jun 2016 18:43:52 +0530 [thread overview]
Message-ID: <575ABD10.60208@nvidia.com> (raw)
In-Reply-To: <CABxcv=mrmN5Mzt595ZFgGbOoHJWQMwQ1wiCvcHEiWh_79EbJqQ@mail.gmail.com>
On Friday 10 June 2016 06:50 PM, Javier Martinez Canillas wrote:
> Hello Laxman,
>
> On Fri, Jun 10, 2016 at 6:12 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>> MAXIM MAX77620 is the power management IC with multiple DCDC/LDO(
>> regulators, RTC, GPIOs, Watchdog, 32KHz clock source etc.
>>
>> Add support for controlling the 32KHz clock source via clock
>> framework.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> ---
> It looks very similar to the max77686 and max77802 drivers (with only
> the difference in number of clock outputs), can you use the helpers in
> drivers/clk/clk-max-gen.c ?
I have explored that option.
The bit location for clock bit on register are same in case of max77686
and max77802 but it is different for the max77620.
So until I change it too generic, it will not be possible.
Also if it is require then what about all max77686/max77802 and max77620
in single file, the way we did for RTC.
We dont need 4 files for the similar driver then.
next prev parent reply other threads:[~2016-06-10 13:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 10:12 [PATCH 1/2] clk: max77620: Add DT binding doc for MAX77620 clock Laxman Dewangan
2016-06-10 10:12 ` Laxman Dewangan
2016-06-10 10:12 ` [PATCH 2/2] clk: max77620: Add clock driver for MAX77620/MAX20024 Laxman Dewangan
2016-06-10 10:12 ` Laxman Dewangan
2016-06-10 13:20 ` Javier Martinez Canillas
2016-06-10 13:13 ` Laxman Dewangan [this message]
2016-06-10 13:13 ` Laxman Dewangan
2016-06-10 13:32 ` Javier Martinez Canillas
2016-06-10 13:31 ` Laxman Dewangan
2016-06-10 13:31 ` Laxman Dewangan
2016-06-10 14:11 ` Krzysztof Kozlowski
2016-06-10 13:26 ` [PATCH 1/2] clk: max77620: Add DT binding doc for MAX77620 clock Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575ABD10.60208@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=javier@dowhile0.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.