From: Juergen Gross <jgross@suse.com>
To: Gerd Hoffmann <kraxel@redhat.com>, Olaf Hering <olaf@aepfle.de>
Cc: qemu-devel@nongnu.org, Anthony Perard <anthony.perard@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
"open list:X86" <xen-devel@lists.xensource.com>
Subject: Re: [Qemu-devel] [Xen-devel] [PULL 3/4] xen: add pvUSB backend
Date: Mon, 13 Jun 2016 09:55:01 +0200 [thread overview]
Message-ID: <575E66D5.4070109@suse.com> (raw)
In-Reply-To: <1465555123.2920.9.camel@redhat.com>
On 10/06/16 12:38, Gerd Hoffmann wrote:
> On Di, 2016-06-07 at 10:35 +0200, Olaf Hering wrote:
>> On Mon, May 23, Gerd Hoffmann wrote:
>>
>>> +++ b/hw/usb/Makefile.objs
>>> +common-obj-$(CONFIG_XEN_BACKEND) += xen-usb.o
>>> +++ b/hw/usb/xen-usb.c
>>> + usb_bus_new(&usbif->bus, sizeof(usbif->bus), &xen_usb_bus_ops, xen_sysdev);
>>
>> xen_sysdev is in an i386-only file, as a result qemu fails to link.
>
> Ping. Juergen? Xen folks? Can anyone have a look please?
Sorry, just was 3 weeks offline due to moving across Germany (900 km).
> I think the fix would be s/xen_sysdev/xendev/, but I can't test that
> myself.
I think the proper solution is to move the xen_sysdev definition and
initialization from hw/xenpv/xen_machine_pv.c to hw/xen/xen_backend.c
I'll send a patch.
Juergen
WARNING: multiple messages have this Message-ID (diff)
From: Juergen Gross <jgross@suse.com>
To: Gerd Hoffmann <kraxel@redhat.com>, Olaf Hering <olaf@aepfle.de>
Cc: Anthony Perard <anthony.perard@citrix.com>,
"open list:X86" <xen-devel@lists.xensource.com>,
Stefano Stabellini <sstabellini@kernel.org>,
qemu-devel@nongnu.org
Subject: Re: [Xen-devel] [PULL 3/4] xen: add pvUSB backend
Date: Mon, 13 Jun 2016 09:55:01 +0200 [thread overview]
Message-ID: <575E66D5.4070109@suse.com> (raw)
In-Reply-To: <1465555123.2920.9.camel@redhat.com>
On 10/06/16 12:38, Gerd Hoffmann wrote:
> On Di, 2016-06-07 at 10:35 +0200, Olaf Hering wrote:
>> On Mon, May 23, Gerd Hoffmann wrote:
>>
>>> +++ b/hw/usb/Makefile.objs
>>> +common-obj-$(CONFIG_XEN_BACKEND) += xen-usb.o
>>> +++ b/hw/usb/xen-usb.c
>>> + usb_bus_new(&usbif->bus, sizeof(usbif->bus), &xen_usb_bus_ops, xen_sysdev);
>>
>> xen_sysdev is in an i386-only file, as a result qemu fails to link.
>
> Ping. Juergen? Xen folks? Can anyone have a look please?
Sorry, just was 3 weeks offline due to moving across Germany (900 km).
> I think the fix would be s/xen_sysdev/xendev/, but I can't test that
> myself.
I think the proper solution is to move the xen_sysdev definition and
initialization from hw/xenpv/xen_machine_pv.c to hw/xen/xen_backend.c
I'll send a patch.
Juergen
next prev parent reply other threads:[~2016-06-13 7:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 13:11 [Qemu-devel] [PULL 0/4] usb: add xen pvUSB backend Gerd Hoffmann
2016-05-23 13:12 ` [Qemu-devel] [PULL 1/4] xen: introduce dummy system device Gerd Hoffmann
2016-05-23 13:12 ` Gerd Hoffmann
2016-05-23 13:12 ` [Qemu-devel] [PULL 2/4] xen: write information about supported backends Gerd Hoffmann
2016-05-23 13:12 ` Gerd Hoffmann
2016-05-23 13:12 ` [Qemu-devel] [PULL 3/4] xen: add pvUSB backend Gerd Hoffmann
2016-05-23 13:12 ` Gerd Hoffmann
2016-06-07 8:35 ` [Qemu-devel] [Xen-devel] " Olaf Hering
2016-06-07 8:35 ` Olaf Hering
2016-06-10 10:38 ` [Qemu-devel] " Gerd Hoffmann
2016-06-10 10:38 ` Gerd Hoffmann
2016-06-13 7:55 ` Juergen Gross [this message]
2016-06-13 7:55 ` [Xen-devel] " Juergen Gross
2016-05-23 13:12 ` [Qemu-devel] [PULL 4/4] usb/ohci: Fix crash with when specifying too many num-ports Gerd Hoffmann
2016-05-23 15:15 ` [Qemu-devel] [PULL 0/4] usb: add xen pvUSB backend Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575E66D5.4070109@suse.com \
--to=jgross@suse.com \
--cc=anthony.perard@citrix.com \
--cc=kraxel@redhat.com \
--cc=olaf@aepfle.de \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.