From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Stephan Linz <linz@li-pro.net>
Cc: linux-leds@vger.kernel.org, linux-ide@vger.kernel.org,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 7/7] unicore32: use the new LED disk activity trigger
Date: Mon, 13 Jun 2016 09:57:53 +0200 [thread overview]
Message-ID: <575E6781.7090503@samsung.com> (raw)
In-Reply-To: <20160610060021.12382-7-linz@li-pro.net>
Hi Guan,
For consistency reasons this patch should be merged through LED tree,
but I need an ack for this.
Thanks,
Jacek Anaszewski
On 06/10/2016 08:00 AM, Stephan Linz wrote:
> - platform: rename 'ide-disk' to 'disk-activity'
> - defconfig: rename 'LEDS_TRIGGER_IDE_DISK' to 'LEDS_TRIGGER_DISK'
>
> Signed-off-by: Stephan Linz <linz@li-pro.net>
> ---
> arch/unicore32/configs/unicore32_defconfig | 2 +-
> arch/unicore32/kernel/gpio.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/unicore32/configs/unicore32_defconfig b/arch/unicore32/configs/unicore32_defconfig
> index 45f47f8..aebd01f 100644
> --- a/arch/unicore32/configs/unicore32_defconfig
> +++ b/arch/unicore32/configs/unicore32_defconfig
> @@ -161,7 +161,7 @@ CONFIG_LEDS_GPIO=y
> # LED Triggers
> CONFIG_LEDS_TRIGGERS=y
> CONFIG_LEDS_TRIGGER_TIMER=y
> -CONFIG_LEDS_TRIGGER_IDE_DISK=y
> +CONFIG_LEDS_TRIGGER_DISK=y
> CONFIG_LEDS_TRIGGER_HEARTBEAT=y
>
> # Real Time Clock
> diff --git a/arch/unicore32/kernel/gpio.c b/arch/unicore32/kernel/gpio.c
> index 49347a0..bf164bb 100644
> --- a/arch/unicore32/kernel/gpio.c
> +++ b/arch/unicore32/kernel/gpio.c
> @@ -27,7 +27,7 @@ static const struct gpio_led puv3_gpio_leds[] = {
> { .name = "cpuhealth", .gpio = GPO_CPU_HEALTH, .active_low = 0,
> .default_trigger = "heartbeat", },
> { .name = "hdd_led", .gpio = GPO_HDD_LED, .active_low = 1,
> - .default_trigger = "ide-disk", },
> + .default_trigger = "disk-activity", },
> };
>
> static const struct gpio_led_platform_data puv3_gpio_led_data = {
>
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2016-06-13 7:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 5:59 [PATCH v4 1/7] leds: convert IDE trigger to common disk trigger Stephan Linz
2016-06-10 5:59 ` [PATCH v4 2/7] leds: documentation: 'ide-disk' to 'disk-activity' Stephan Linz
2016-06-10 18:07 ` Rob Herring
[not found] ` <20160610060021.12382-1-linz-LlUBiLVY8XKsTnJN9+BGXg@public.gmane.org>
2016-06-10 5:59 ` [PATCH v4 3/7] powerpc: use the new LED disk activity trigger Stephan Linz
2016-06-10 5:59 ` Stephan Linz
2016-06-13 7:46 ` Jacek Anaszewski
2016-06-10 5:59 ` [PATCH v4 4/7] arm: " Stephan Linz
2016-06-13 7:42 ` Jacek Anaszewski
2016-06-13 7:49 ` Tony Lindgren
2016-06-13 8:12 ` Sekhar Nori
2016-06-13 8:12 ` Sekhar Nori
2016-06-16 7:16 ` Robert Jarzmik
2016-06-10 6:00 ` [PATCH v4 5/7] mips: " Stephan Linz
2016-06-13 7:53 ` Jacek Anaszewski
2016-06-10 6:00 ` [PATCH v4 6/7] parisc: " Stephan Linz
2016-06-13 7:56 ` Jacek Anaszewski
2016-06-13 13:24 ` Helge Deller
2016-06-10 6:00 ` [PATCH v4 7/7] unicore32: " Stephan Linz
2016-06-13 7:57 ` Jacek Anaszewski [this message]
2016-06-14 2:11 ` Xuetao Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575E6781.7090503@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linz@li-pro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.