Re: [PATCH V6 9/9] irqchip/gic: Add platform driver for non-root GICs that require RPM

[Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>]

On 13/06/16 11:13, Marc Zyngier wrote:

...

> OK, that's because ARM_GIC_PM is never selected (and there is no way I
> can actually select). Do you have some additional patches that selects
> it for Tegra?

Yes locally, I have the following for testing ...

diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig
index 03089ad2fc65..ffd02a3c093a 100644
--- a/drivers/soc/tegra/Kconfig
+++ b/drivers/soc/tegra/Kconfig
@@ -63,6 +63,7 @@ config ARCH_TEGRA_132_SOC

 config ARCH_TEGRA_210_SOC
        bool "NVIDIA Tegra210 SoC"
+       select ARM_GIC_PM
        select PINCTRL_TEGRA210

>> The correct fix is ...
>>
>> diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
>> index 57423f3b218b..1de07eb5839c 100644
>> --- a/drivers/irqchip/irq-gic.c
>> +++ b/drivers/irqchip/irq-gic.c
>> @@ -1272,7 +1272,7 @@ static bool gic_check_eoimode(struct device_node *node, void __iomem **base)
>>         return true;
>>  }
>>  
>> -static int __init gic_of_setup(struct gic_chip_data *gic, struct device_node *node)
>> +static int gic_of_setup(struct gic_chip_data *gic, struct device_node *node)
>>  {
>>         if (!gic || !node)
>>                 return -EINVAL;
> 
> OK, I've applied this locally (no need to resend).

Great. Thanks. Sorry about this.

Jon

-- 
nvpublic