All of lore.kernel.org
 help / color / mirror / Atom feed
* [j.anaszewski-leds:for-next 4/4] drivers/leds/leds-pca9532.c:464:10: warning: cast from pointer to integer of different size
@ 2016-06-13 10:27 kbuild test robot
  2016-06-13 11:47 ` Jacek Anaszewski
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2016-06-13 10:27 UTC (permalink / raw)
  Cc: kbuild-all, linux-leds, Jacek Anaszewski, Phil Reid

[-- Attachment #1: Type: text/plain, Size: 2166 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds for-next
head:   fa50a4fde61a4620ecbfac6f51be3913a6800bb7
commit: fa50a4fde61a4620ecbfac6f51be3913a6800bb7 [4/4] leds: pca9532: Add device tree binding
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout fa50a4fde61a4620ecbfac6f51be3913a6800bb7
        # save the attached .config to linux build tree
        make.cross ARCH=sparc64 

All warnings (new ones prefixed by >>):

   drivers/leds/leds-pca9532.c: In function 'pca9532_of_populate_pdata':
>> drivers/leds/leds-pca9532.c:464:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     devid = (int)match->data;
             ^
   drivers/leds/leds-pca9532.c: In function 'pca9532_probe':
   drivers/leds/leds-pca9532.c:506:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
      devid = (int)of_match_device(
              ^

vim +464 drivers/leds/leds-pca9532.c

   448		return err;
   449	}
   450	
   451	struct pca9532_platform_data *pca9532_of_populate_pdata(struct device *dev,
   452							      struct device_node *np)
   453	{
   454		struct pca9532_platform_data *pdata;
   455		struct device_node *child;
   456		const struct of_device_id *match;
   457		int devid, maxleds;
   458		int i = 0;
   459	
   460		match = of_match_device(of_pca9532_leds_match, dev);
   461		if (!match)
   462			return ERR_PTR(-ENODEV);
   463	
 > 464		devid = (int)match->data;
   465		maxleds = pca9532_chip_info_tbl[devid].num_leds;
   466	
   467		pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
   468		if (!pdata)
   469			return ERR_PTR(-ENOMEM);
   470	
   471		for_each_child_of_node(np, child) {
   472			if (of_property_read_string(child, "label",

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 46449 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [j.anaszewski-leds:for-next 4/4] drivers/leds/leds-pca9532.c:464:10: warning: cast from pointer to integer of different size
  2016-06-13 10:27 [j.anaszewski-leds:for-next 4/4] drivers/leds/leds-pca9532.c:464:10: warning: cast from pointer to integer of different size kbuild test robot
@ 2016-06-13 11:47 ` Jacek Anaszewski
  2016-06-14  7:31   ` Phil Reid
  0 siblings, 1 reply; 3+ messages in thread
From: Jacek Anaszewski @ 2016-06-13 11:47 UTC (permalink / raw)
  To: Phil Reid; +Cc: kbuild test robot, linux-leds

Hi Phil,

Please cast to uintptr_t instead of int.

Besides, pca9532_of_populate_pdata() is local, please add 'static'
modifier to its definition.

For now, I'm dropping the patch.

Thanks,
Jacek Anaszewski

On 06/13/2016 12:27 PM, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds for-next
> head:   fa50a4fde61a4620ecbfac6f51be3913a6800bb7
> commit: fa50a4fde61a4620ecbfac6f51be3913a6800bb7 [4/4] leds: pca9532: Add device tree binding
> config: sparc64-allyesconfig (attached as .config)
> compiler: sparc64-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
> reproduce:
>          wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          git checkout fa50a4fde61a4620ecbfac6f51be3913a6800bb7
>          # save the attached .config to linux build tree
>          make.cross ARCH=sparc64
>
> All warnings (new ones prefixed by >>):
>
>     drivers/leds/leds-pca9532.c: In function 'pca9532_of_populate_pdata':
>>> drivers/leds/leds-pca9532.c:464:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>       devid = (int)match->data;
>               ^
>     drivers/leds/leds-pca9532.c: In function 'pca9532_probe':
>     drivers/leds/leds-pca9532.c:506:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>        devid = (int)of_match_device(
>                ^
>
> vim +464 drivers/leds/leds-pca9532.c
>
>     448		return err;
>     449	}
>     450	
>     451	struct pca9532_platform_data *pca9532_of_populate_pdata(struct device *dev,
>     452							      struct device_node *np)
>     453	{
>     454		struct pca9532_platform_data *pdata;
>     455		struct device_node *child;
>     456		const struct of_device_id *match;
>     457		int devid, maxleds;
>     458		int i = 0;
>     459	
>     460		match = of_match_device(of_pca9532_leds_match, dev);
>     461		if (!match)
>     462			return ERR_PTR(-ENODEV);
>     463	
>   > 464		devid = (int)match->data;
>     465		maxleds = pca9532_chip_info_tbl[devid].num_leds;
>     466	
>     467		pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
>     468		if (!pdata)
>     469			return ERR_PTR(-ENOMEM);
>     470	
>     471		for_each_child_of_node(np, child) {
>     472			if (of_property_read_string(child, "label",
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>


-- 
Best regards,
Jacek Anaszewski

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [j.anaszewski-leds:for-next 4/4] drivers/leds/leds-pca9532.c:464:10: warning: cast from pointer to integer of different size
  2016-06-13 11:47 ` Jacek Anaszewski
@ 2016-06-14  7:31   ` Phil Reid
  0 siblings, 0 replies; 3+ messages in thread
From: Phil Reid @ 2016-06-14  7:31 UTC (permalink / raw)
  To: Jacek Anaszewski; +Cc: kbuild test robot, linux-leds

On 13/06/2016 19:47, Jacek Anaszewski wrote:
> Hi Phil,
>
> Please cast to uintptr_t instead of int.
>
> Besides, pca9532_of_populate_pdata() is local, please add 'static'
> modifier to its definition.
>

PATCH v5 sent addressing the issues.

> For now, I'm dropping the patch.
>
> Thanks,
> Jacek Anaszewski
>
> On 06/13/2016 12:27 PM, kbuild test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds for-next
>> head:   fa50a4fde61a4620ecbfac6f51be3913a6800bb7
>> commit: fa50a4fde61a4620ecbfac6f51be3913a6800bb7 [4/4] leds: pca9532: Add device tree binding
>> config: sparc64-allyesconfig (attached as .config)
>> compiler: sparc64-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
>> reproduce:
>>          wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>>          chmod +x ~/bin/make.cross
>>          git checkout fa50a4fde61a4620ecbfac6f51be3913a6800bb7
>>          # save the attached .config to linux build tree
>>          make.cross ARCH=sparc64
>>
>> All warnings (new ones prefixed by >>):
>>
>>     drivers/leds/leds-pca9532.c: In function 'pca9532_of_populate_pdata':
>>>> drivers/leds/leds-pca9532.c:464:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>>       devid = (int)match->data;
>>               ^
>>     drivers/leds/leds-pca9532.c: In function 'pca9532_probe':
>>     drivers/leds/leds-pca9532.c:506:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>>        devid = (int)of_match_device(
>>                ^
>>
>> vim +464 drivers/leds/leds-pca9532.c
>>
>>     448        return err;
>>     449    }
>>     450
>>     451    struct pca9532_platform_data *pca9532_of_populate_pdata(struct device *dev,
>>     452                                  struct device_node *np)
>>     453    {
>>     454        struct pca9532_platform_data *pdata;
>>     455        struct device_node *child;
>>     456        const struct of_device_id *match;
>>     457        int devid, maxleds;
>>     458        int i = 0;
>>     459
>>     460        match = of_match_device(of_pca9532_leds_match, dev);
>>     461        if (!match)
>>     462            return ERR_PTR(-ENODEV);
>>     463
>>   > 464        devid = (int)match->data;
>>     465        maxleds = pca9532_chip_info_tbl[devid].num_leds;
>>     466
>>     467        pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
>>     468        if (!pdata)
>>     469            return ERR_PTR(-ENOMEM);
>>     470
>>     471        for_each_child_of_node(np, child) {
>>     472            if (of_property_read_string(child, "label",
>>
>> ---
>> 0-DAY kernel test infrastructure                Open Source Technology Center
>> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>>
>
>


-- 
Regards
Phil Reid

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-06-14  7:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-13 10:27 [j.anaszewski-leds:for-next 4/4] drivers/leds/leds-pca9532.c:464:10: warning: cast from pointer to integer of different size kbuild test robot
2016-06-13 11:47 ` Jacek Anaszewski
2016-06-14  7:31   ` Phil Reid

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.