* [PATCH] multipath-tools: add Pure Storage device to hardware table @ 2016-06-13 16:30 Xose Vazquez Perez 2016-06-14 5:56 ` Hannes Reinecke 2016-06-14 12:32 ` Xose Vazquez Perez 0 siblings, 2 replies; 7+ messages in thread From: Xose Vazquez Perez @ 2016-06-13 16:30 UTC (permalink / raw) Cc: Xose Vazquez Perez, device-mapper development based on documentation provided by the manufacturer: https://support.purestorage.com/@api/deki/files/1733/=Pure_Storage_Oracle_DB_Best_Practices.pdf?revision=2 vendor "PURE" product "FlashArray" (extracted from outputs) path_selector "round-robin 0" path_grouping_policy multibus rr_min_io 1 path_checker tur fast_io_fail_tmo 10 dev_loss_tmo 30 Cc: Benjamin Marzinski <bmarzins@redhat.com> Cc: Hannes Reinecke <hare@suse.de> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com> Cc: device-mapper development <dm-devel@redhat.com> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com> --- libmultipath/hwtable.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index a126b7c..c4258e1 100644 --- a/libmultipath/hwtable.c +++ b/libmultipath/hwtable.c @@ -1195,6 +1195,22 @@ static struct hwentry default_hw[] = { .minio = 128, }, /* + * Pure Storage, Inc. + * + * Maintainer : Christophe Varoqui + * Mail : christophe.varoqui@opensvc.com + */ + { + .vendor = "PURE", + .product = "FlashArray", + .selector = "round-robin 0", + .pgpolicy = MULTIBUS, + .minio = 1, + .checker_name = TUR, + .fast_io_fail = 10, + .dev_loss = 30, + }, + /* * EOL */ { -- 2.5.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] multipath-tools: add Pure Storage device to hardware table 2016-06-13 16:30 [PATCH] multipath-tools: add Pure Storage device to hardware table Xose Vazquez Perez @ 2016-06-14 5:56 ` Hannes Reinecke 2016-06-16 15:55 ` Xose Vazquez Perez 2016-06-14 12:32 ` Xose Vazquez Perez 1 sibling, 1 reply; 7+ messages in thread From: Hannes Reinecke @ 2016-06-14 5:56 UTC (permalink / raw) To: Xose Vazquez Perez; +Cc: device-mapper development On 06/13/2016 06:30 PM, Xose Vazquez Perez wrote: > based on documentation provided by the manufacturer: > https://support.purestorage.com/@api/deki/files/1733/=Pure_Storage_Oracle_DB_Best_Practices.pdf?revision=2 > > vendor "PURE" > product "FlashArray" (extracted from outputs) > path_selector "round-robin 0" > path_grouping_policy multibus > rr_min_io 1 > path_checker tur > fast_io_fail_tmo 10 > dev_loss_tmo 30 > > Cc: Benjamin Marzinski <bmarzins@redhat.com> > Cc: Hannes Reinecke <hare@suse.de> > Cc: Christophe Varoqui <christophe.varoqui@opensvc.com> > Cc: device-mapper development <dm-devel@redhat.com> > Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com> > --- > libmultipath/hwtable.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c > index a126b7c..c4258e1 100644 > --- a/libmultipath/hwtable.c > +++ b/libmultipath/hwtable.c > @@ -1195,6 +1195,22 @@ static struct hwentry default_hw[] = { > .minio = 128, > }, > /* > + * Pure Storage, Inc. > + * > + * Maintainer : Christophe Varoqui > + * Mail : christophe.varoqui@opensvc.com > + */ Please drop the 'Maintainer' line. Christophe is the maintainer of the multipath-tools package itself, so everything which doesn't have an explicit owner is maintained by him anyway. Plus I think it's a bad style, appointing someone to become a maintainer without having asked first. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] multipath-tools: add Pure Storage device to hardware table 2016-06-14 5:56 ` Hannes Reinecke @ 2016-06-16 15:55 ` Xose Vazquez Perez 0 siblings, 0 replies; 7+ messages in thread From: Xose Vazquez Perez @ 2016-06-16 15:55 UTC (permalink / raw) To: Hannes Reinecke; +Cc: device-mapper development On 06/14/2016 07:56 AM, Hannes Reinecke wrote: > On 06/13/2016 06:30 PM, Xose Vazquez Perez wrote: > [...] >> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c >> index a126b7c..c4258e1 100644 >> --- a/libmultipath/hwtable.c >> +++ b/libmultipath/hwtable.c >> @@ -1195,6 +1195,22 @@ static struct hwentry default_hw[] = { >> .minio = 128, >> }, >> /* >> + * Pure Storage, Inc. >> + * >> + * Maintainer : Christophe Varoqui >> + * Mail : christophe.varoqui@opensvc.com >> + */ >> > Please drop the 'Maintainer' line. > Christophe is the maintainer of the multipath-tools package itself, so > everything which doesn't have an explicit owner is maintained by him anyway. > > Plus I think it's a bad style, appointing someone to become a maintainer > without having asked first. It was made that way originally, see 1b6188ce. So I followed the stream. But I see lately any patch for new hardware includes a maintainer. Even the controller/vendor families were disorganized. I will do it. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] multipath-tools: add Pure Storage device to hardware table 2016-06-13 16:30 [PATCH] multipath-tools: add Pure Storage device to hardware table Xose Vazquez Perez 2016-06-14 5:56 ` Hannes Reinecke @ 2016-06-14 12:32 ` Xose Vazquez Perez 2016-06-14 12:37 ` Menny_Hamburger 1 sibling, 1 reply; 7+ messages in thread From: Xose Vazquez Perez @ 2016-06-14 12:32 UTC (permalink / raw) To: Christophe Varoqui, device-mapper development, Brian Bunker On 06/13/2016 06:30 PM, Xose Vazquez Perez wrote: > based on documentation provided by the manufacturer: > https://support.purestorage.com/@api/deki/files/1733/=Pure_Storage_Oracle_DB_Best_Practices.pdf?revision=2 > > vendor "PURE" > product "FlashArray" (extracted from outputs) Please DROP this one. It was already included by Brian Bunker <brian@purestorage.com> > + { > + .vendor = "PURE", > + .product = "FlashArray", > + .selector = "round-robin 0", > + .pgpolicy = MULTIBUS, > + .minio = 1, > + .checker_name = TUR, > + .fast_io_fail = 10, > + .dev_loss = 30, > + }, Though it's a bit different. Why ? + .vendor = "PURE", + .product = "FlashArray", + .features = DEFAULT_FEATURES, + .hwhandler = DEFAULT_HWHANDLER, + .selector = "queue-length 0", + .pgpolicy = MULTIBUS, + .pgfailback = -FAILBACK_IMMEDIATE, + .checker_name = TUR, + .fast_io_fail = 10, + .user_friendly_names = USER_FRIENDLY_NAMES_OFF, + .prio_name = DEFAULT_PRIO, + .no_path_retry = 0, + .dev_loss = 60, + .prio_args = NULL, ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] multipath-tools: add Pure Storage device to hardware table 2016-06-14 12:32 ` Xose Vazquez Perez @ 2016-06-14 12:37 ` Menny_Hamburger 2016-06-14 13:55 ` Brian Bunker 0 siblings, 1 reply; 7+ messages in thread From: Menny_Hamburger @ 2016-06-14 12:37 UTC (permalink / raw) To: xose.vazquez, christophe.varoqui, dm-devel, brian If driver names are different between tophat and magichat you can stick with different names instead of an alias in modprobe.conf and do "install x modprobe install y" in modprobe.conf ________________________________________ From: dm-devel-bounces@redhat.com <dm-devel-bounces@redhat.com> on behalf of Xose Vazquez Perez <xose.vazquez@gmail.com> Sent: Tuesday, June 14, 2016 3:32 PM To: Christophe Varoqui; device-mapper development; Brian Bunker Subject: Re: [dm-devel] [PATCH] multipath-tools: add Pure Storage device to hardware table On 06/13/2016 06:30 PM, Xose Vazquez Perez wrote: > based on documentation provided by the manufacturer: > https://support.purestorage.com/@api/deki/files/1733/=Pure_Storage_Oracle_DB_Best_Practices.pdf?revision=2 > > vendor "PURE" > product "FlashArray" (extracted from outputs) Please DROP this one. It was already included by Brian Bunker <brian@purestorage.com> > + { > + .vendor = "PURE", > + .product = "FlashArray", > + .selector = "round-robin 0", > + .pgpolicy = MULTIBUS, > + .minio = 1, > + .checker_name = TUR, > + .fast_io_fail = 10, > + .dev_loss = 30, > + }, Though it's a bit different. Why ? + .vendor = "PURE", + .product = "FlashArray", + .features = DEFAULT_FEATURES, + .hwhandler = DEFAULT_HWHANDLER, + .selector = "queue-length 0", + .pgpolicy = MULTIBUS, + .pgfailback = -FAILBACK_IMMEDIATE, + .checker_name = TUR, + .fast_io_fail = 10, + .user_friendly_names = USER_FRIENDLY_NAMES_OFF, + .prio_name = DEFAULT_PRIO, + .no_path_retry = 0, + .dev_loss = 60, + .prio_args = NULL, -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] multipath-tools: add Pure Storage device to hardware table 2016-06-14 12:37 ` Menny_Hamburger @ 2016-06-14 13:55 ` Brian Bunker 2016-06-14 14:27 ` Xose Vazquez Perez 0 siblings, 1 reply; 7+ messages in thread From: Brian Bunker @ 2016-06-14 13:55 UTC (permalink / raw) To: Menny_Hamburger; +Cc: device-mapper development, xose.vazquez [-- Attachment #1.1: Type: text/plain, Size: 2435 bytes --] Hello all, Definitely we want the one we included with the queue length vs. round robin and 60 second devloss timeout. Not sure where the other one came from. Thanks Brian Brian Bunker PURE Storage, Inc. On Jun 14, 2016 5:40 AM, <Menny_Hamburger@dell.com> wrote: > If driver names are different between tophat and magichat you can stick > with different names instead of an alias in modprobe.conf and do "install x > modprobe install y" in modprobe.conf > ________________________________________ > From: dm-devel-bounces@redhat.com <dm-devel-bounces@redhat.com> on behalf > of Xose Vazquez Perez <xose.vazquez@gmail.com> > Sent: Tuesday, June 14, 2016 3:32 PM > To: Christophe Varoqui; device-mapper development; Brian Bunker > Subject: Re: [dm-devel] [PATCH] multipath-tools: add Pure Storage device > to hardware table > > On 06/13/2016 06:30 PM, Xose Vazquez Perez wrote: > > > based on documentation provided by the manufacturer: > > > https://support.purestorage.com/@api/deki/files/1733/=Pure_Storage_Oracle_DB_Best_Practices.pdf?revision=2 > > > > vendor "PURE" > > product "FlashArray" (extracted from outputs) > > Please DROP this one. It was already included by Brian Bunker < > brian@purestorage.com> > > > + { > > + .vendor = "PURE", > > + .product = "FlashArray", > > + .selector = "round-robin 0", > > + .pgpolicy = MULTIBUS, > > + .minio = 1, > > + .checker_name = TUR, > > + .fast_io_fail = 10, > > + .dev_loss = 30, > > + }, > > Though it's a bit different. Why ? > > + .vendor = "PURE", > + .product = "FlashArray", > + .features = DEFAULT_FEATURES, > + .hwhandler = DEFAULT_HWHANDLER, > + .selector = "queue-length 0", > + .pgpolicy = MULTIBUS, > + .pgfailback = -FAILBACK_IMMEDIATE, > + .checker_name = TUR, > + .fast_io_fail = 10, > + .user_friendly_names = USER_FRIENDLY_NAMES_OFF, > + .prio_name = DEFAULT_PRIO, > + .no_path_retry = 0, > + .dev_loss = 60, > + .prio_args = NULL, > > -- > dm-devel mailing list > dm-devel@redhat.com > https://www.redhat.com/mailman/listinfo/dm-devel > [-- Attachment #1.2: Type: text/html, Size: 3758 bytes --] [-- Attachment #2: Type: text/plain, Size: 0 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] multipath-tools: add Pure Storage device to hardware table 2016-06-14 13:55 ` Brian Bunker @ 2016-06-14 14:27 ` Xose Vazquez Perez 0 siblings, 0 replies; 7+ messages in thread From: Xose Vazquez Perez @ 2016-06-14 14:27 UTC (permalink / raw) To: Brian Bunker, Menny_Hamburger; +Cc: device-mapper development On 06/14/2016 03:55 PM, Brian Bunker wrote: > Definitely we want the one we included with the queue > length vs. round robin and 60 second devloss timeout. > > Not sure where the other one came from. https://www.google.es/search?q=site%3Apurestorage.com+%22multipath.conf%22+%22round-robin%22 And also Brocade: http://www.brocade.com/content/html/en/validation-test-report/brocade-vcs-pure-m20-fos-741-vt/GUID-3F7ACBC0-627C-4FEB-A99D-599577726C0E.html Thank you. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-06-16 15:55 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-06-13 16:30 [PATCH] multipath-tools: add Pure Storage device to hardware table Xose Vazquez Perez 2016-06-14 5:56 ` Hannes Reinecke 2016-06-16 15:55 ` Xose Vazquez Perez 2016-06-14 12:32 ` Xose Vazquez Perez 2016-06-14 12:37 ` Menny_Hamburger 2016-06-14 13:55 ` Brian Bunker 2016-06-14 14:27 ` Xose Vazquez Perez
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.