All of lore.kernel.org
 help / color / mirror / Atom feed
* [Ocfs2-devel] [PATCH] ocfs2: cleanup unneeded goto in ocfs2_create_new_inode_locks
@ 2016-06-16  2:49 Joseph Qi
  2016-06-16  7:03 ` Mark Fasheh
  0 siblings, 1 reply; 2+ messages in thread
From: Joseph Qi @ 2016-06-16  2:49 UTC (permalink / raw)
  To: ocfs2-devel

The last goto is unneeded, so remove it.

Signed-off-by: Joseph Qi <joseph.qi@huawei.com>
---
 fs/ocfs2/dlmglue.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
index 474e57f..1cfa1b6bf 100644
--- a/fs/ocfs2/dlmglue.c
+++ b/fs/ocfs2/dlmglue.c
@@ -1664,10 +1664,8 @@ int ocfs2_create_new_inode_locks(struct inode *inode)
 	}

 	ret = ocfs2_create_new_lock(osb, &OCFS2_I(inode)->ip_open_lockres, 0, 0);
-	if (ret) {
+	if (ret)
 		mlog_errno(ret);
-		goto bail;
-	}

 bail:
 	return ret;
-- 
1.8.4.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Ocfs2-devel] [PATCH] ocfs2: cleanup unneeded goto in ocfs2_create_new_inode_locks
  2016-06-16  2:49 [Ocfs2-devel] [PATCH] ocfs2: cleanup unneeded goto in ocfs2_create_new_inode_locks Joseph Qi
@ 2016-06-16  7:03 ` Mark Fasheh
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Fasheh @ 2016-06-16  7:03 UTC (permalink / raw)
  To: ocfs2-devel

On Thu, Jun 16, 2016 at 10:49:55AM +0800, Joseph Qi wrote:
> The last goto is unneeded, so remove it.
> 
> Signed-off-by: Joseph Qi <joseph.qi@huawei.com>
Reviewed-by: Mark Fasheh <mfasheh@suse.de>

--
Mark Fasheh

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-16  7:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-16  2:49 [Ocfs2-devel] [PATCH] ocfs2: cleanup unneeded goto in ocfs2_create_new_inode_locks Joseph Qi
2016-06-16  7:03 ` Mark Fasheh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.