All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	<javier@osg.samsung.com>, <mturquette@baylibre.com>,
	<robh+dt@kernel.org>, <linux@armlinux.org.uk>
Cc: <linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>,
	Javier Martinez Canillas <javier@dowhile0.org>
Subject: Re: [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks
Date: Thu, 16 Jun 2016 15:22:37 +0530	[thread overview]
Message-ID: <576276E5.5040500@nvidia.com> (raw)
In-Reply-To: <57627757.50101@samsung.com>

Hi Krzysztof/Javier,
Thanks for review of the series.

I will post the V2 after taking care of all comment.

One query about the comment.

Thanks,
Laxman

On Thursday 16 June 2016 03:24 PM, Krzysztof Kozlowski wrote:
> On 06/15/2016 04:13 PM, Laxman Dewangan wrote:
>>   enum chip_name {
>>   	CHIP_MAX77686,
>>   	CHIP_MAX77802,
>> +	CHIP_MAX77620,
> Now it is more obvious why it is here. However I don't like the
> duplication of device IDs, under different names and different values:
> 1. include/linux/mfd/max77686-private.h
> 2. include/linux/mfd/max77620.h
> 3. here
>
> I was thinking about way of combining it... but these headers are
> different. Unless there will be one header for all three devices.
>
> Anyway, please add the max77686 prefix to the enum.

so will it be:

enum max77686_chip_name {
     CHIP_MAX77686,
     CHIP_MAX77802,
     CHIP_MAX77620,
};


Will it be fine here?

WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	javier@osg.samsung.com, mturquette@baylibre.com,
	robh+dt@kernel.org, linux@armlinux.org.uk
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	Javier Martinez Canillas <javier@dowhile0.org>
Subject: Re: [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks
Date: Thu, 16 Jun 2016 15:22:37 +0530	[thread overview]
Message-ID: <576276E5.5040500@nvidia.com> (raw)
In-Reply-To: <57627757.50101@samsung.com>

Hi Krzysztof/Javier,
Thanks for review of the series.

I will post the V2 after taking care of all comment.

One query about the comment.

Thanks,
Laxman

On Thursday 16 June 2016 03:24 PM, Krzysztof Kozlowski wrote:
> On 06/15/2016 04:13 PM, Laxman Dewangan wrote:
>>   enum chip_name {
>>   	CHIP_MAX77686,
>>   	CHIP_MAX77802,
>> +	CHIP_MAX77620,
> Now it is more obvious why it is here. However I don't like the
> duplication of device IDs, under different names and different values:
> 1. include/linux/mfd/max77686-private.h
> 2. include/linux/mfd/max77620.h
> 3. here
>
> I was thinking about way of combining it... but these headers are
> different. Unless there will be one header for all three devices.
>
> Anyway, please add the max77686 prefix to the enum.

so will it be:

enum max77686_chip_name {
     CHIP_MAX77686,
     CHIP_MAX77802,
     CHIP_MAX77620,
};


Will it be fine here?

WARNING: multiple messages have this Message-ID (diff)
From: ldewangan@nvidia.com (Laxman Dewangan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks
Date: Thu, 16 Jun 2016 15:22:37 +0530	[thread overview]
Message-ID: <576276E5.5040500@nvidia.com> (raw)
In-Reply-To: <57627757.50101@samsung.com>

Hi Krzysztof/Javier,
Thanks for review of the series.

I will post the V2 after taking care of all comment.

One query about the comment.

Thanks,
Laxman

On Thursday 16 June 2016 03:24 PM, Krzysztof Kozlowski wrote:
> On 06/15/2016 04:13 PM, Laxman Dewangan wrote:
>>   enum chip_name {
>>   	CHIP_MAX77686,
>>   	CHIP_MAX77802,
>> +	CHIP_MAX77620,
> Now it is more obvious why it is here. However I don't like the
> duplication of device IDs, under different names and different values:
> 1. include/linux/mfd/max77686-private.h
> 2. include/linux/mfd/max77620.h
> 3. here
>
> I was thinking about way of combining it... but these headers are
> different. Unless there will be one header for all three devices.
>
> Anyway, please add the max77686 prefix to the enum.

so will it be:

enum max77686_chip_name {
     CHIP_MAX77686,
     CHIP_MAX77802,
     CHIP_MAX77620,
};


Will it be fine here?

  reply	other threads:[~2016-06-16  9:52 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-15 14:13 [PATCH 0/5] clk: Combine MAX77686 and MAX77802 driver and extend for MAX77620 Laxman Dewangan
2016-06-15 14:13 ` Laxman Dewangan
2016-06-15 14:13 ` Laxman Dewangan
2016-06-15 14:13 ` [PATCH 1/5] clk: max77686: Combine Maxim max77686 and max77802 driver Laxman Dewangan
2016-06-15 14:13   ` Laxman Dewangan
2016-06-15 14:13   ` Laxman Dewangan
2016-06-15 15:12   ` Javier Martinez Canillas
2016-06-15 15:12     ` Javier Martinez Canillas
2016-06-15 15:35   ` kbuild test robot
2016-06-15 15:35     ` kbuild test robot
2016-06-15 15:35     ` kbuild test robot
2016-06-15 15:35   ` [PATCH] clk: max77686: fix semicolon.cocci warnings kbuild test robot
2016-06-15 15:35     ` kbuild test robot
2016-06-15 15:35     ` kbuild test robot
2016-06-16  9:31   ` [PATCH 1/5] clk: max77686: Combine Maxim max77686 and max77802 driver Krzysztof Kozlowski
2016-06-16  9:31     ` Krzysztof Kozlowski
2016-06-16 13:02   ` Krzysztof Kozlowski
2016-06-16 13:02     ` Krzysztof Kozlowski
2016-06-15 14:13 ` [PATCH 2/5] clk: Combine DT binding doc for max77686 and max77802 Laxman Dewangan
2016-06-15 14:13   ` Laxman Dewangan
2016-06-15 14:13   ` Laxman Dewangan
2016-06-15 15:19   ` Javier Martinez Canillas
2016-06-15 15:19     ` Javier Martinez Canillas
2016-06-16  9:34     ` Krzysztof Kozlowski
2016-06-16  9:34       ` Krzysztof Kozlowski
2016-06-16  9:44   ` Krzysztof Kozlowski
2016-06-16  9:44     ` Krzysztof Kozlowski
2016-06-15 14:13 ` [PATCH 3/5] clk: max77686: Add DT binding details for PMIC MAX77620 Laxman Dewangan
2016-06-15 14:13   ` Laxman Dewangan
2016-06-15 14:13   ` Laxman Dewangan
2016-06-15 15:24   ` Javier Martinez Canillas
2016-06-15 15:24     ` Javier Martinez Canillas
2016-06-16  9:49   ` Krzysztof Kozlowski
2016-06-16  9:49     ` Krzysztof Kozlowski
2016-06-15 14:13 ` [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks Laxman Dewangan
2016-06-15 14:13   ` Laxman Dewangan
2016-06-15 14:13   ` Laxman Dewangan
2016-06-15 15:27   ` Javier Martinez Canillas
2016-06-15 15:27     ` Javier Martinez Canillas
2016-06-15 15:27     ` Javier Martinez Canillas
2016-06-16  9:54   ` Krzysztof Kozlowski
2016-06-16  9:54     ` Krzysztof Kozlowski
2016-06-16  9:52     ` Laxman Dewangan [this message]
2016-06-16  9:52       ` Laxman Dewangan
2016-06-16  9:52       ` Laxman Dewangan
2016-06-16 10:11       ` Krzysztof Kozlowski
2016-06-16 10:11         ` Krzysztof Kozlowski
2016-06-16 13:02   ` Krzysztof Kozlowski
2016-06-16 13:02     ` Krzysztof Kozlowski
2016-06-15 14:13 ` [PATCH 5/5] ARM: config: Get rid of config COMMON_CLK_MAX77802 Laxman Dewangan
2016-06-15 14:13   ` Laxman Dewangan
2016-06-15 14:13   ` Laxman Dewangan
2016-06-15 15:39   ` Javier Martinez Canillas
2016-06-15 15:39     ` Javier Martinez Canillas
2016-06-16 12:25     ` Krzysztof Kozlowski
2016-06-16 12:25       ` Krzysztof Kozlowski
2016-06-16 13:06       ` Javier Martinez Canillas
2016-06-16 13:06         ` Javier Martinez Canillas
2016-06-16 13:08         ` Laxman Dewangan
2016-06-16 13:08           ` Laxman Dewangan
2016-06-16 13:08           ` Laxman Dewangan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=576276E5.5040500@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=devicetree@vger.kernel.org \
    --cc=javier@dowhile0.org \
    --cc=javier@osg.samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.