From: Sudeep Holla <sudeep.holla@arm.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Kevin Hilman <khilman@baylibre.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [QUERY] AMBA: PM domains when !CONFIG_PM
Date: Thu, 16 Jun 2016 13:47:31 +0100 [thread overview]
Message-ID: <57629FE3.8050303@arm.com> (raw)
In-Reply-To: <CAPDyKFoV5Y1mHuDZmWgynCicux2deV89npp-siTQDJr0uZFwcg@mail.gmail.com>
On 16/06/16 13:33, Ulf Hansson wrote:
>
>
> On 16 June 2016 at 13:19, Sudeep Holla <sudeep.holla@arm.com
> <mailto:sudeep.holla@arm.com>> wrote:
>
> Hi Ulf, Kevin,
>
> I have a situation where we need to enable the power domain to access an
> AMBA device. This is all fine with patches from Ulf and Marek in
> amba/bus.c
>
> The problem is when we disable CONFIG_PM, dev_pm_domain_attach
> returns -ENODEV irrespective of whether a DT node has a PM domain
> in it or not. If dev_pm_domain_attach returns anything other than
> -EPROBE_DEFER, we ignore the error and proceed to access the device
> which will explode.
>
> Basically, we need a way to prevent addition of that amba device if DT
> node has PD specified but CONFIG_PM=n. Any thoughts ?
>
>
> The solution TEGRA picked for a kind of similar issue was to enable
> CONFIG_PM for a family of SoCs.
>
> I assume this would be applicable here as well, or are you saying this
> platform actually is able to work *without* PM support?
>
I agree, but if someone tries to boot with !CONFIG_PM, it just hangs
without a clue, hence I raised this query. I am fine by forcing it to be
ON always, but just wanted to check if this is something serious that it
needs to be addressed.
Thanks for the quick response.
--
Regards,
Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: sudeep.holla@arm.com (Sudeep Holla)
To: linux-arm-kernel@lists.infradead.org
Subject: [QUERY] AMBA: PM domains when !CONFIG_PM
Date: Thu, 16 Jun 2016 13:47:31 +0100 [thread overview]
Message-ID: <57629FE3.8050303@arm.com> (raw)
In-Reply-To: <CAPDyKFoV5Y1mHuDZmWgynCicux2deV89npp-siTQDJr0uZFwcg@mail.gmail.com>
On 16/06/16 13:33, Ulf Hansson wrote:
>
>
> On 16 June 2016 at 13:19, Sudeep Holla <sudeep.holla@arm.com
> <mailto:sudeep.holla@arm.com>> wrote:
>
> Hi Ulf, Kevin,
>
> I have a situation where we need to enable the power domain to access an
> AMBA device. This is all fine with patches from Ulf and Marek in
> amba/bus.c
>
> The problem is when we disable CONFIG_PM, dev_pm_domain_attach
> returns -ENODEV irrespective of whether a DT node has a PM domain
> in it or not. If dev_pm_domain_attach returns anything other than
> -EPROBE_DEFER, we ignore the error and proceed to access the device
> which will explode.
>
> Basically, we need a way to prevent addition of that amba device if DT
> node has PD specified but CONFIG_PM=n. Any thoughts ?
>
>
> The solution TEGRA picked for a kind of similar issue was to enable
> CONFIG_PM for a family of SoCs.
>
> I assume this would be applicable here as well, or are you saying this
> platform actually is able to work *without* PM support?
>
I agree, but if someone tries to boot with !CONFIG_PM, it just hangs
without a clue, hence I raised this query. I am fine by forcing it to be
ON always, but just wanted to check if this is something serious that it
needs to be addressed.
Thanks for the quick response.
--
Regards,
Sudeep
next prev parent reply other threads:[~2016-06-16 12:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 11:19 [QUERY] AMBA: PM domains when !CONFIG_PM Sudeep Holla
2016-06-16 11:19 ` Sudeep Holla
[not found] ` <CAPDyKFoV5Y1mHuDZmWgynCicux2deV89npp-siTQDJr0uZFwcg@mail.gmail.com>
2016-06-16 12:47 ` Sudeep Holla [this message]
2016-06-16 12:47 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57629FE3.8050303@arm.com \
--to=sudeep.holla@arm.com \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.