All of lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Perier <romain.perier@free-electrons.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Arnaud Ebalard <arno@natisbad.org>,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	"David S. Miller" <davem@davemloft.net>,
	Russell King <linux@arm.linux.org.uk>,
	linux-crypto@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/7] crypto: marvell: Adding a complete operation for async requests
Date: Thu, 16 Jun 2016 15:41:54 +0200	[thread overview]
Message-ID: <5762ACA2.3050703@free-electrons.com> (raw)
In-Reply-To: <20160615225531.4e060f11@bbrezillon>

Hello,

Le 15/06/2016 22:55, Boris Brezillon a écrit :
>> +
>
> Nit: not sure you should mix this cosmetic change with the other
> changes.

Ok


> You already have ivsize initialized.
>
>> +		memcpy_fromio(ablkreq->info, basereq->chain.last->data, ivsize);
>
> Use memcpy() here.

good catch, for both.

Thanks,
Romain
-- 
Romain Perier, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: romain.perier@free-electrons.com (Romain Perier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/7] crypto: marvell: Adding a complete operation for async requests
Date: Thu, 16 Jun 2016 15:41:54 +0200	[thread overview]
Message-ID: <5762ACA2.3050703@free-electrons.com> (raw)
In-Reply-To: <20160615225531.4e060f11@bbrezillon>

Hello,

Le 15/06/2016 22:55, Boris Brezillon a ?crit :
>> +
>
> Nit: not sure you should mix this cosmetic change with the other
> changes.

Ok


> You already have ivsize initialized.
>
>> +		memcpy_fromio(ablkreq->info, basereq->chain.last->data, ivsize);
>
> Use memcpy() here.

good catch, for both.

Thanks,
Romain
-- 
Romain Perier, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-06-16 13:42 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-15 19:15 [PATCH 0/7] Chain crypto requests together at the DMA level Romain Perier
2016-06-15 19:15 ` Romain Perier
2016-06-15 19:15 ` [PATCH 1/7] crypto: marvell: Add a macro constant for the size of the crypto queue Romain Perier
2016-06-15 19:15   ` Romain Perier
2016-06-15 19:20   ` Boris Brezillon
2016-06-15 19:20     ` Boris Brezillon
2016-06-15 19:15 ` [PATCH 2/7] crypto: marvell: Check engine is not already running when enabling a req Romain Perier
2016-06-15 19:15   ` Romain Perier
2016-06-15 19:37   ` Boris Brezillon
2016-06-15 19:37     ` Boris Brezillon
2016-06-16  8:18     ` Romain Perier
2016-06-16  8:18       ` Romain Perier
2016-06-15 19:15 ` [PATCH 3/7] crypto: marvell: Copy IV vectors by DMA transfers for acipher requests Romain Perier
2016-06-15 19:15   ` Romain Perier
2016-06-15 20:07   ` Boris Brezillon
2016-06-15 20:07     ` Boris Brezillon
2016-06-16  8:29     ` Romain Perier
2016-06-16  8:29       ` Romain Perier
2016-06-16  8:32       ` Gregory CLEMENT
2016-06-16  8:32         ` Gregory CLEMENT
2016-06-15 20:48   ` Boris Brezillon
2016-06-15 20:48     ` Boris Brezillon
2016-06-15 19:15 ` [PATCH 4/7] crypto: marvell: Moving the tdma chain out of mv_cesa_tdma_req Romain Perier
2016-06-15 19:15   ` Romain Perier
2016-06-15 20:42   ` Boris Brezillon
2016-06-15 20:42     ` Boris Brezillon
2016-06-16 12:02     ` Romain Perier
2016-06-16 12:02       ` Romain Perier
2016-06-16 12:45       ` Boris Brezillon
2016-06-16 12:45         ` Boris Brezillon
2016-06-16 12:57       ` Boris Brezillon
2016-06-16 12:57         ` Boris Brezillon
2016-06-15 19:15 ` [PATCH 5/7] crypto: marvell: Adding a complete operation for async requests Romain Perier
2016-06-15 19:15   ` Romain Perier
2016-06-15 20:55   ` Boris Brezillon
2016-06-15 20:55     ` Boris Brezillon
2016-06-16 13:41     ` Romain Perier [this message]
2016-06-16 13:41       ` Romain Perier
2016-06-15 19:15 ` [PATCH 6/7] crypto: marvell: Adding load balancing between engines Romain Perier
2016-06-15 19:15   ` Romain Perier
2016-06-15 21:13   ` Boris Brezillon
2016-06-15 21:13     ` Boris Brezillon
2016-06-16 13:44     ` Romain Perier
2016-06-16 13:44       ` Romain Perier
2016-06-15 19:15 ` [PATCH 7/7] crypto: marvell: Add support for chaining crypto requests in TDMA mode Romain Perier
2016-06-15 19:15   ` Romain Perier
2016-06-15 21:43   ` Boris Brezillon
2016-06-15 21:43     ` Boris Brezillon
2016-06-17  9:54     ` Romain Perier
2016-06-17  9:54       ` Romain Perier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5762ACA2.3050703@free-electrons.com \
    --to=romain.perier@free-electrons.com \
    --cc=arno@natisbad.org \
    --cc=boris.brezillon@free-electrons.com \
    --cc=davem@davemloft.net \
    --cc=gregory.clement@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.