From: Olivier Matz <olivier.matz@6wind.com>
To: Lazaros Koromilas <l@nofutznetworks.com>, dev@dpdk.org
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>,
David Hunt <david.hunt@intel.com>
Subject: Re: [PATCH v3 0/3] mempool: user-owned mempool caches
Date: Fri, 17 Jun 2016 12:36:35 +0200 [thread overview]
Message-ID: <5763D2B3.2060407@6wind.com> (raw)
In-Reply-To: <1466074939-29863-1-git-send-email-l@nofutznetworks.com>
Hi Lazaros,
On 06/16/2016 01:02 PM, Lazaros Koromilas wrote:
> Updated version of the user-owned cache patchset. It applies on top of
> the latest external mempool manager patches from David Hunt [1].
>
> [1] http://dpdk.org/ml/archives/dev/2016-June/041479.html
>
> v3 changes:
>
> * Deprecate specific mempool API calls instead of removing them.
> * Split deprecation into a separate commit to limit noise.
> * Fix cache flush by setting cache->len = 0 and make it inline.
> * Remove cache->size == 0 checks and ensure size != 0 at creation.
> * Fix tests to check if cache creation succeeded.
> * Fix tests to free allocated resources on error.
Thanks for the update. The patchset looks good to me.
I have some minor comments for patch 2/3 and 3/3.
One more thing: would you mind adding some words in
doc/guides/prog_guide/mempool_lib.rst ?
Thanks,
Olivier
next prev parent reply other threads:[~2016-06-17 10:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 11:02 [PATCH v3 0/3] mempool: user-owned mempool caches Lazaros Koromilas
2016-06-16 11:02 ` [PATCH v3 1/3] mempool: deprecate specific get/put functions Lazaros Koromilas
2016-06-16 11:02 ` [PATCH v3 2/3] mempool: use bit flags instead of is_mp and is_mc Lazaros Koromilas
2016-06-17 10:36 ` Olivier Matz
2016-06-16 11:02 ` [PATCH v3 3/3] mempool: allow for user-owned mempool caches Lazaros Koromilas
2016-06-17 10:37 ` Olivier Matz
2016-06-18 16:15 ` Lazaros Koromilas
2016-06-20 7:36 ` Olivier Matz
2016-06-17 10:36 ` Olivier Matz [this message]
2016-06-27 15:50 ` [PATCH v4 0/3] mempool: " Olivier Matz
2016-06-27 15:50 ` [PATCH v4 1/3] mempool: deprecate specific get/put functions Olivier Matz
2016-06-27 15:50 ` [PATCH v4 2/3] mempool: use bit flags to set multi consumers or producers Olivier Matz
2016-06-27 15:50 ` [PATCH v4 3/3] mempool: allow for user-owned mempool caches Olivier Matz
2016-06-28 17:20 ` Lazaros Koromilas
2016-06-27 15:52 ` [PATCH v4 0/3] mempool: " Olivier MATZ
2016-06-28 23:47 ` [PATCH v5 " Lazaros Koromilas
2016-06-28 23:47 ` [PATCH v5 1/3] mempool: deprecate specific get and put functions Lazaros Koromilas
2016-06-28 23:47 ` [PATCH v5 2/3] mempool: use bit flags to set multi consumers and producers Lazaros Koromilas
2016-06-28 23:47 ` [PATCH v5 3/3] mempool: allow for user-owned mempool caches Lazaros Koromilas
2016-06-29 12:13 ` Olivier MATZ
2016-06-30 9:29 ` [PATCH v5 0/3] mempool: " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5763D2B3.2060407@6wind.com \
--to=olivier.matz@6wind.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=l@nofutznetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.